[PATCH v8 0/2] sDMA descriptor autoloading feature

[PATCH v8 0/2] sDMA descriptor autoloading feature

[Venkatraman S]

    This patch series is the introduction of new sDMA feature: descriptor
autoloading (v8) and it's adoption by the OMAP HSMMC driver.

   The previous version (v7) was blocked on achieving proper interrupt
syncronisation
between the MMC and DMA callback in the HSMMC driver.
  Thanks to Adrian Hunter's patch, https://patchwork.kernel.org/patch/94670/
this has been cleaned up.

Current version is based on for-next branch + Adrian Hunter's
interrupt syncronisation patch
(https://patchwork.kernel.org/patch/94670)

Changes since v7:
  * Removed the 'fix race condition between DMA and HSMMC callback'
part of the series
  * Added memory barries in start and resume sglist transfer for cpu
buffer syncronization
  * Cleanup and comments

This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP
for MMC file transfer and as boot file system.

Venkatraman S:
    sDMA: descriptor autoloading feature
    MMC: omap hsmmc adoption of descriptor autoloading feature

 arch/arm/plat-omap/dma.c              |  289 ++++++++++++++++++++++++++++++++-
 arch/arm/plat-omap/include/plat/dma.h |  170 +++++++++++++++++++
 drivers/mmc/host/omap_hsmmc.c         |  148 ++++++++++++++---
 3 files changed, 583 insertions(+), 24 deletions(-)

[PATCH v8 0/2] sDMA descriptor autoloading feature

[Madhusudhan]

> -----Original Message-----
> From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of
> Venkatraman S
> Sent: Thursday, April 29, 2010 12:35 PM
> To: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org
> Cc: Madhusudhan Chikkature; Tony Lindgren; Adrian Hunter; Santosh
> Shilimkar
> Subject: [PATCH v8 0/2] sDMA descriptor autoloading feature
> 
>     This patch series is the introduction of new sDMA feature: descriptor
> autoloading (v8) and it's adoption by the OMAP HSMMC driver.
> 
>    The previous version (v7) was blocked on achieving proper interrupt
> syncronisation
> between the MMC and DMA callback in the HSMMC driver.
>   Thanks to Adrian Hunter's patch,
> https://patchwork.kernel.org/patch/94670/
> this has been cleaned up.
> 
> Current version is based on for-next branch + Adrian Hunter's
> interrupt syncronisation patch
> (https://patchwork.kernel.org/patch/94670)
> 
> Changes since v7:
>   * Removed the 'fix race condition between DMA and HSMMC callback'
> part of the series
>   * Added memory barries in start and resume sglist transfer for cpu
> buffer syncronization
>   * Cleanup and comments
> 
> This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP
> for MMC file transfer and as boot file system.
> 

The HSMMC driver changes look good to me. I can ACK that but am not a DMA
expert to review your changes to the DMA driver.

> Venkatraman S:
>     sDMA: descriptor autoloading feature
>     MMC: omap hsmmc adoption of descriptor autoloading feature
> 
>  arch/arm/plat-omap/dma.c              |  289
> ++++++++++++++++++++++++++++++++-
>  arch/arm/plat-omap/include/plat/dma.h |  170 +++++++++++++++++++
>  drivers/mmc/host/omap_hsmmc.c         |  148 ++++++++++++++---
>  3 files changed, 583 insertions(+), 24 deletions(-)

[PATCH v8 0/2] sDMA descriptor autoloading feature

[Venkatraman S]

On Wed, May 5, 2010 at 4:45 AM, Madhusudhan <madhu.cr@ti.com> wrote:
>> -----Original Message-----
>> From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of
>> Venkatraman S
>> Sent: Thursday, April 29, 2010 12:35 PM
>> To: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm-
>> kernel at lists.infradead.org
>> Cc: Madhusudhan Chikkature; Tony Lindgren; Adrian Hunter; Santosh
>> Shilimkar
>> Subject: [PATCH v8 0/2] sDMA descriptor autoloading feature
>>
>> ? ? This patch series is the introduction of new sDMA feature: descriptor
>> autoloading (v8) and it's adoption by the OMAP HSMMC driver.
>>
>> ? ?The previous version (v7) was blocked on achieving proper interrupt
>> syncronisation
>> between the MMC and DMA callback in the HSMMC driver.
>> ? Thanks to Adrian Hunter's patch,
>> https://patchwork.kernel.org/patch/94670/
>> this has been cleaned up.
>>
>> Current version is based on for-next branch + Adrian Hunter's
>> interrupt syncronisation patch
>> (https://patchwork.kernel.org/patch/94670)
>>
>> Changes since v7:
>> ? * Removed the 'fix race condition between DMA and HSMMC callback'
>> part of the series
>> ? * Added memory barries in start and resume sglist transfer for cpu
>> buffer syncronization
>> ? * Cleanup and comments
>>
>> This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP
>> for MMC file transfer and as boot file system.
>>
>
> The HSMMC driver changes look good to me. I can ACK that but am not a DMA
> expert to review your changes to the DMA driver.
>
Thanks. Can you please add your acked-by to 2/2 of this series so that
patchworks can pick it up.

Regards,
Venkat.

[PATCH v8 0/2] sDMA descriptor autoloading feature

[Shilimkar, Santosh]

> -----Original Message-----
> From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of S, Venkatraman
> Sent: Wednesday, May 05, 2010 10:09 AM
> To: Chikkature Rajashekar, Madhusudhan
> Cc: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Tony
> Lindgren; Adrian Hunter; Shilimkar, Santosh
> Subject: Re: [PATCH v8 0/2] sDMA descriptor autoloading feature
> 
> On Wed, May 5, 2010 at 4:45 AM, Madhusudhan <madhu.cr@ti.com> wrote:
> >> -----Original Message-----
> >> From: svenkatr at gmail.com [mailto:svenkatr at gmail.com] On Behalf Of
> >> Venkatraman S
> >> Sent: Thursday, April 29, 2010 12:35 PM
> >> To: linux-omap at vger.kernel.org; linux-mmc at vger.kernel.org; linux-arm-
> >> kernel at lists.infradead.org
> >> Cc: Madhusudhan Chikkature; Tony Lindgren; Adrian Hunter; Santosh
> >> Shilimkar
> >> Subject: [PATCH v8 0/2] sDMA descriptor autoloading feature
> >>
> >> ? ? This patch series is the introduction of new sDMA feature: descriptor
> >> autoloading (v8) and it's adoption by the OMAP HSMMC driver.
> >>
> >> ? ?The previous version (v7) was blocked on achieving proper interrupt
> >> syncronisation
> >> between the MMC and DMA callback in the HSMMC driver.
> >> ? Thanks to Adrian Hunter's patch,
> >> https://patchwork.kernel.org/patch/94670/
> >> this has been cleaned up.
> >>
> >> Current version is based on for-next branch + Adrian Hunter's
> >> interrupt syncronisation patch
> >> (https://patchwork.kernel.org/patch/94670)
> >>
> >> Changes since v7:
> >> ? * Removed the 'fix race condition between DMA and HSMMC callback'
> >> part of the series
> >> ? * Added memory barries in start and resume sglist transfer for cpu
> >> buffer syncronization
> >> ? * Cleanup and comments
> >>
> >> This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP
> >> for MMC file transfer and as boot file system.
> >>
> >
> > The HSMMC driver changes look good to me. I can ACK that but am not a DMA
> > expert to review your changes to the DMA driver.
> >
Venkat, 
Sorry for late comments on your series.
 

[PATCH v8 0/2] sDMA descriptor autoloading feature

[Chris Ball]

Hi Venkatraman,

On Thu, Apr 29, 2010 at 11:04:34PM +0530, Venkatraman S wrote:
>     This patch series is the introduction of new sDMA feature: descriptor
> autoloading (v8) and it's adoption by the OMAP HSMMC driver.
> 
>    The previous version (v7) was blocked on achieving proper interrupt
> syncronisation
> between the MMC and DMA callback in the HSMMC driver.
>   Thanks to Adrian Hunter's patch, https://patchwork.kernel.org/patch/94670/
> this has been cleaned up.
> 
> Current version is based on for-next branch + Adrian Hunter's
> interrupt syncronisation patch
> (https://patchwork.kernel.org/patch/94670)
> 
> Changes since v7:
>   * Removed the 'fix race condition between DMA and HSMMC callback'
> part of the series
>   * Added memory barries in start and resume sglist transfer for cpu
> buffer syncronization
>   * Cleanup and comments
> 
> This has been tested on OMAP3430, OMAP3630 and OMAP4430 SDP
> for MMC file transfer and as boot file system.

The comments on this patchset were positive apart from some stylistic
changes -- would you like to resubmit a new patch?

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child