linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] sdhci-s3c: increase the timeout value
Date: Fri, 27 Aug 2010 20:53:52 +0100	[thread overview]
Message-ID: <20100827195352.GL23079@void.printf.net> (raw)
In-Reply-To: <1276076383-24825-4-git-send-email-m.szyprowski@samsung.com>

Hi Marek,

On Wed, Jun 09, 2010 at 11:39:41AM +0200, Marek Szyprowski wrote:
> This patch increases the timeout value on sdhci-s3c controller by using
> SDHCI_QUIRK_BROKEN_TIMEOUT_VAL quirk. Without it most transfers from
> external mmc cards fails on Samsung s5pv210 SoCs based systems. Tested
> on Samsung Aquila board.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/mmc/host/sdhci-s3c.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index ad30f07..2b6cb44 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -331,6 +331,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
>  	 * transfers, not sure if this is a problem with this specific
>  	 * SDHCI block, or a missing configuration that needs to be set. */
>  	host->quirks |= SDHCI_QUIRK_NO_BUSY_IRQ;
> +	host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>  
>  	host->quirks |= (SDHCI_QUIRK_32BIT_DMA_ADDR |
>  			 SDHCI_QUIRK_32BIT_DMA_SIZE);
> -- 
> 1.7.1.240.g225c

Kukjin Kim suggested using SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK instead,
so this wasn't merged.  Would you like to resubmit with that change?

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2010-08-27 19:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09  9:39 [PATCH] SDHCI-S3C fixes and enhancements (driver specific code) Marek Szyprowski
2010-06-09  9:39 ` [PATCH 1/5] sdhci-s3c: depend on plat-samsung Marek Szyprowski
2010-06-11  0:29   ` Kukjin Kim
2010-06-11  5:24     ` Ben Dooks
2010-06-11  5:42       ` Kyungmin Park
2010-06-11 10:30       ` Mark Brown
2010-06-09  9:39 ` [PATCH 2/5] sdhci-s3c: add missing remove function Marek Szyprowski
2010-06-09  9:39 ` [PATCH 3/5] sdhci-s3c: increase the timeout value Marek Szyprowski
2010-06-10 10:46   ` Kukjin Kim
2010-08-27 19:53   ` Chris Ball [this message]
2010-06-09  9:39 ` [PATCH 4/5] sdhci-s3c: add support for the non standard minimal clock value Marek Szyprowski
2010-08-27 19:54   ` Chris Ball
2010-08-28  0:54     ` Kukjin Kim
2010-06-09  9:39 ` [PATCH 5/5] sdhci-s3c: add support for new card detection methods Marek Szyprowski
2010-06-10 12:06   ` [PATCH 5/5 fixed] " Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100827195352.GL23079@void.printf.net \
    --to=cjb@laptop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).