From mboxrd@z Thu Jan 1 00:00:00 1970 From: cjb@laptop.org (Chris Ball) Date: Fri, 27 Aug 2010 20:53:52 +0100 Subject: [PATCH 3/5] sdhci-s3c: increase the timeout value In-Reply-To: <1276076383-24825-4-git-send-email-m.szyprowski@samsung.com> References: <1276076383-24825-1-git-send-email-m.szyprowski@samsung.com> <1276076383-24825-4-git-send-email-m.szyprowski@samsung.com> Message-ID: <20100827195352.GL23079@void.printf.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marek, On Wed, Jun 09, 2010 at 11:39:41AM +0200, Marek Szyprowski wrote: > This patch increases the timeout value on sdhci-s3c controller by using > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL quirk. Without it most transfers from > external mmc cards fails on Samsung s5pv210 SoCs based systems. Tested > on Samsung Aquila board. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > --- > drivers/mmc/host/sdhci-s3c.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index ad30f07..2b6cb44 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -331,6 +331,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev) > * transfers, not sure if this is a problem with this specific > * SDHCI block, or a missing configuration that needs to be set. */ > host->quirks |= SDHCI_QUIRK_NO_BUSY_IRQ; > + host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; > > host->quirks |= (SDHCI_QUIRK_32BIT_DMA_ADDR | > SDHCI_QUIRK_32BIT_DMA_SIZE); > -- > 1.7.1.240.g225c Kukjin Kim suggested using SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK instead, so this wasn't merged. Would you like to resubmit with that change? -- Chris Ball One Laptop Per Child