From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa168fb: fix clear operation
Date: Mon, 30 Aug 2010 19:44:10 +0200 [thread overview]
Message-ID: <201008301944.10598.marek.vasut@gmail.com> (raw)
In-Reply-To: <1283128337-4605-2-git-send-email-haojian.zhuang@marvell.com>
Dne Po 30. srpna 2010 02:32:17 Haojian Zhuang napsal(a):
> While fb isn't active, we should clear CFG_GRA_ENA bit. The existing code
> can't clear this bit.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
> ---
> drivers/video/pxa168fb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
> index ec2ddb2..3f112c9 100644
> --- a/drivers/video/pxa168fb.c
> +++ b/drivers/video/pxa168fb.c
> @@ -298,8 +298,8 @@ static void set_dma_control0(struct pxa168fb_info *fbi)
> * Set bit to enable graphics DMA.
> */
> x = readl(fbi->reg_base + LCD_SPU_DMA_CTRL0);
> - x |= fbi->active ? 0x00000100 : 0;
> - fbi->active = 0;
> + x &= ~CFG_GRA_ENA_MASK;
> + x |= CFG_GRA_ENA(!!fbi->active);
>
> /*
> * If we are in a pseudo-color mode, we need to enable
Acked-by: Marek Vasut <marek.vasut@gmail.com>
next prev parent reply other threads:[~2010-08-30 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 0:32 [PATCH] pxa168fb: Add .remove function Haojian Zhuang
2010-08-30 0:32 ` [PATCH] pxa168fb: fix clear operation Haojian Zhuang
2010-08-30 17:44 ` Marek Vasut [this message]
2010-09-05 11:56 ` Eric Miao
2010-09-06 11:26 ` Haojian Zhuang
2010-09-07 2:23 ` Eric Miao
2010-08-30 17:43 ` [PATCH] pxa168fb: Add .remove function Marek Vasut
2010-09-05 11:08 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008301944.10598.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).