From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] ARM: Improve the L2 cache performance when PL310 is used
Date: Tue, 31 Aug 2010 14:58:41 +0100 [thread overview]
Message-ID: <20100831135841.21304.55366.stgit@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20100831135435.21304.38960.stgit@e102109-lin.cambridge.arm.com>
With this L2 cache controller, the cache maintenance by PA and sync
operations are atomic and do not require a "wait" loop. This patch
conditionally defines the cache_wait() function.
Since L2x0 cache controllers do not work with ARMv7 CPUs, the patch
automatically enables CACHE_PL310 when only CPU_V7 is defined.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/arm/mm/Kconfig | 8 ++++++++
arch/arm/mm/cache-l2x0.c | 15 ++++++++++++---
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
index a0a2928..4414a01 100644
--- a/arch/arm/mm/Kconfig
+++ b/arch/arm/mm/Kconfig
@@ -779,6 +779,14 @@ config CACHE_L2X0
help
This option enables the L2x0 PrimeCell.
+config CACHE_PL310
+ bool
+ depends on CACHE_L2X0
+ default y if CPU_V7 && !CPU_V6
+ help
+ This option enables optimisations for the PL310 cache
+ controller.
+
config CACHE_TAUROS2
bool "Enable the Tauros2 L2 cache controller"
depends on (ARCH_DOVE || ARCH_MMP)
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 9982eb3..edb43ff 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -29,13 +29,22 @@ static void __iomem *l2x0_base;
static DEFINE_SPINLOCK(l2x0_lock);
static uint32_t l2x0_way_mask; /* Bitmask of active ways */
-static inline void cache_wait(void __iomem *reg, unsigned long mask)
+static inline void cache_wait_way(void __iomem *reg, unsigned long mask)
{
- /* wait for the operation to complete */
+ /* wait for cache operation by line or way to complete */
while (readl_relaxed(reg) & mask)
;
}
+#ifdef CONFIG_CACHE_PL310
+static inline void cache_wait(void __iomem *reg, unsigned long mask)
+{
+ /* cache operations by line are atomic on PL310 */
+}
+#else
+#define cache_wait cache_wait_way
+#endif
+
static inline void cache_sync(void)
{
void __iomem *base = l2x0_base;
@@ -110,7 +119,7 @@ static inline void l2x0_inv_all(void)
/* invalidate all ways */
spin_lock_irqsave(&l2x0_lock, flags);
writel_relaxed(l2x0_way_mask, l2x0_base + L2X0_INV_WAY);
- cache_wait(l2x0_base + L2X0_INV_WAY, l2x0_way_mask);
+ cache_wait_way(l2x0_base + L2X0_INV_WAY, l2x0_way_mask);
cache_sync();
spin_unlock_irqrestore(&l2x0_lock, flags);
}
next prev parent reply other threads:[~2010-08-31 13:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 13:57 [PATCH 0/9] Various patches for 2.6.37-rc1 Catalin Marinas
2010-08-31 13:58 ` [PATCH 1/9] ARM: Allow lazy cache flushing via PG_arch_1 for highmem pages Catalin Marinas
2010-08-31 13:58 ` [PATCH 2/9] ARM: Assume new page cache pages have dirty D-cache Catalin Marinas
2010-08-31 13:58 ` [PATCH 3/9] ARM: Introduce __sync_icache_dcache() for VIPT caches Catalin Marinas
2010-08-31 13:58 ` [PATCH 4/9] ARM: Use lazy cache flushing on ARMv7 SMP systems Catalin Marinas
2010-08-31 13:58 ` [PATCH 5/9] ARM: Remove superfluous flush_kernel_dcache_page() Catalin Marinas
2010-08-31 13:58 ` [PATCH 6/9] ARM: Implement phys_mem_access_prot() to avoid attributes aliasing Catalin Marinas
2010-08-31 13:58 ` Catalin Marinas [this message]
2010-09-13 11:36 ` [PATCH 7/9] ARM: Improve the L2 cache performance when PL310 is used Russell King - ARM Linux
2010-09-13 11:57 ` Catalin Marinas
2010-08-31 13:58 ` [PATCH 8/9] ARM: Remove the domain switching on ARMv6k/v7 CPUs Catalin Marinas
2010-08-31 13:58 ` [PATCH 9/9] ARM: Add SWP/SWPB emulation for ARMv7 processors (v5) Catalin Marinas
2010-08-31 15:05 ` Kirill A. Shutemov
2010-09-06 15:42 ` Catalin Marinas
2010-09-13 11:55 ` Russell King - ARM Linux
2010-09-14 13:50 ` Leif Lindholm
2010-09-01 4:08 ` Olof Johansson
2010-09-02 17:04 ` Leif Lindholm
2010-09-02 17:20 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831135841.21304.55366.stgit@e102109-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).