From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: A serial patchs that support FSL's eSDHC
Date: Wed, 1 Sep 2010 12:15:00 +0200 [thread overview]
Message-ID: <20100901101500.GE11407@pengutronix.de> (raw)
In-Reply-To: <1283334305-12453-1-git-send-email-r65037@freescale.com>
On Wed, Sep 01, 2010 at 05:45:04PM +0800, Richard Zhu wrote:
> Can you help me to review the following serial patchs, that enable the sdhci
> driver to support FSL's eSDHC on i.MX family.
I see two major problems: First, you often modify sdhci.c to work around
the hardware-quirks. See sdhci-of-esdhc.c how it can be handled in a
seperate source-file and keep sdhci.c clean. (While at it, what is
common between the of-driver and the platform-driver should be shared).
Second, your platform-driver is a complete one, but we have a platform
core meanwhile (sdhci-pltfm.c). Please use that.
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100901/3451cf26/attachment.sig>
next prev parent reply other threads:[~2010-09-01 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 9:45 A serial patchs that support FSL's eSDHC Richard Zhu
2010-09-01 9:45 ` [PATCH 1/9] sdhci-1: add host's own set_power func to support the controller that used it's own power mechanism Richard Zhu
2010-09-01 10:15 ` Wolfram Sang [this message]
2010-09-02 10:06 ` A serial patchs that support FSL's eSDHC Zhu Richard-R65037
2010-09-06 10:30 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901101500.GE11407@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).