From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] h1940: use gpiolib for latch access
Date: Thu, 2 Sep 2010 11:53:49 +0100 [thread overview]
Message-ID: <20100902105349.GT26319@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1282230003-2020-2-git-send-email-anarsoul@gmail.com>
On Thu, Aug 19, 2010 at 06:00:01PM +0300, Vasily Khoruzhick wrote:
> diff --git a/arch/arm/mach-s3c2410/mach-h1940.c b/arch/arm/mach-s3c2410/mach-h1940.c
> index 779b45b..9717790 100644
> --- a/arch/arm/mach-s3c2410/mach-h1940.c
> +++ b/arch/arm/mach-s3c2410/mach-h1940.c
> @@ -42,6 +42,7 @@
> #include <mach/regs-gpio.h>
> #include <mach/gpio-fns.h>
> #include <mach/gpio-nrs.h>
> +#include <mach/gpio.h>
linux/gpio.h ?
>
> #include <mach/h1940.h>
> #include <mach/h1940-latch.h>
> @@ -58,6 +59,16 @@
> #include <plat/mci.h>
> #include <plat/ts.h>
>
> +#ifndef __ASSEMBLY__
> +#define H1940_LATCH ((void __force __iomem *)0xF8000000)
> +#else
> +#define H1940_LATCH 0xF8000000
> +#endif
This file can never be built by the assembler, so the above is pointless.
> +
> +#define H1940_PA_LATCH (S3C2410_CS2)
Parents not required.
Rest looks fine to me.
next prev parent reply other threads:[~2010-09-02 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 15:00 [PATCH 0/3] h1940 series Vasily Khoruzhick
2010-08-19 15:00 ` [PATCH 1/3] h1940: use gpiolib for latch access Vasily Khoruzhick
2010-08-24 13:49 ` Marek Vasut
2010-08-24 14:04 ` Vasily Khoruzhick
2010-08-24 14:40 ` Marek Vasut
2010-08-24 14:50 ` Vasily Khoruzhick
2010-08-24 15:04 ` Marek Vasut
2010-09-02 10:53 ` Russell King - ARM Linux [this message]
2010-08-19 15:00 ` [PATCH 2/3] h1940: fix h1940-bluetooth compilation Vasily Khoruzhick
2010-08-24 13:50 ` Marek Vasut
2010-08-24 13:57 ` Vasily Khoruzhick
2010-08-24 14:00 ` Marek Vasut
2010-08-19 15:00 ` [PATCH 3/3] h1940: implement mmc_power function Vasily Khoruzhick
2010-08-24 13:52 ` Marek Vasut
2010-08-24 14:00 ` Vasily Khoruzhick
2010-08-24 14:01 ` Marek Vasut
2010-08-24 14:21 ` Vasily Khoruzhick
2010-08-24 14:41 ` Marek Vasut
2010-08-24 14:56 ` Vasily Khoruzhick
2010-08-24 15:07 ` Marek Vasut
2010-08-24 15:19 ` Vasily Khoruzhick
2010-08-24 13:24 ` [PATCH 0/3] h1940 series Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902105349.GT26319@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).