linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mach-ux500: Added nomadik mtu timer suspend/resume hooks.
Date: Thu, 2 Sep 2010 17:07:08 +0100	[thread overview]
Message-ID: <20100902160708.GS26319@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1283412633-9883-3-git-send-email-jonas.aberg@stericsson.com>

On Thu, Sep 02, 2010 at 09:30:33AM +0200, Jonas Aaberg wrote:
>  struct sys_timer ux500_timer = {
> -	.init	= ux500_timer_init,
> +	.init	 = ux500_timer_init,
> +#ifdef CONFIG_PM
> +	.suspend = nmdk_timer_suspend,
> +	.resume  = nmdk_timer_resume,
> +#endif

It would be better to use the callbacks from the clocksource/clockevent
code so that if your timers aren't being used, they can be shutdown for
power saving.

In any case, with clockevents support enabled, these suspend/resume
callbacks will not be called.

  reply	other threads:[~2010-09-02 16:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-02  7:30 [PATCH 1/3] plat-nomadik: MTU timer Jonas Aaberg
2010-09-02  7:30 ` [PATCH 2/3] plat-nomadik: Added suspend/resume support for " Jonas Aaberg
2010-09-02  7:30   ` [PATCH 3/3] mach-ux500: Added nomadik mtu timer suspend/resume hooks Jonas Aaberg
2010-09-02 16:07     ` Russell King - ARM Linux [this message]
2010-09-06  7:27       ` Jonas Aaberg
2010-09-02 16:04   ` [PATCH 2/3] plat-nomadik: Added suspend/resume support for MTU timer Russell King - ARM Linux
2010-09-02 19:30     ` Linus Walleij
2010-09-03 11:49     ` Alessandro Rubini
2010-09-03 17:37       ` Linus Walleij
2010-09-06  7:20         ` Armando Visconti
2010-09-02 19:44   ` Linus Walleij
2010-09-02 19:45   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100902160708.GS26319@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).