linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] mfd: update chip id of 88pm8607
Date: Mon, 13 Sep 2010 15:48:31 +0200	[thread overview]
Message-ID: <20100913134830.GF2555@sortiz-mobl> (raw)
In-Reply-To: <1283953476-2395-3-git-send-email-haojian.zhuang@marvell.com>

Hi Haojian,

On Wed, Sep 08, 2010 at 09:44:34AM -0400, Haojian Zhuang wrote:
> Chipid of 88pm8607 is 0x40 or 0x50.
Patch applied, many thanks.

Cheers,
Samuel.


> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Samuel Ortiz <sameo@openedhand.com>
> ---
>  drivers/mfd/88pm860x-core.c  |    7 +++++--
>  include/linux/mfd/88pm860x.h |    2 +-
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
> index 4db10a1..20895e7 100644
> --- a/drivers/mfd/88pm860x-core.c
> +++ b/drivers/mfd/88pm860x-core.c
> @@ -645,10 +645,13 @@ static void __devinit device_8607_init(struct pm860x_chip *chip,
>  		dev_err(chip->dev, "Failed to read CHIP ID: %d\n", ret);
>  		goto out;
>  	}
> -	if ((ret & PM8607_VERSION_MASK) == PM8607_VERSION)
> +	switch (ret & PM8607_VERSION_MASK) {
> +	case 0x40:
> +	case 0x50:
>  		dev_info(chip->dev, "Marvell 88PM8607 (ID: %02x) detected\n",
>  			 ret);
> -	else {
> +		break;
> +	default:
>  		dev_err(chip->dev, "Failed to detect Marvell 88PM8607. "
>  			"Chip ID: %02x\n", ret);
>  		goto out;
> diff --git a/include/linux/mfd/88pm860x.h b/include/linux/mfd/88pm860x.h
> index bfd23be..4db1fbd 100644
> --- a/include/linux/mfd/88pm860x.h
> +++ b/include/linux/mfd/88pm860x.h
> @@ -138,7 +138,7 @@ enum {
>  	PM8607_ID_RG_MAX,
>  };
>  
> -#define PM8607_VERSION			(0x40)	/* 8607 chip ID */
> +/* 8607 chip ID is 0x40 or 0x50 */
>  #define PM8607_VERSION_MASK		(0xF0)	/* 8607 chip ID mask */
>  
>  /* Interrupt Registers */
> -- 
> 1.5.6.5
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

      parent reply	other threads:[~2010-09-13 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 13:44 [PATCH 1/5] mfd: add codec resource into 88pm860x driver Haojian Zhuang
2010-09-08 13:44 ` [PATCH 2/5] leds: remove auto blink in 88pm860x Haojian Zhuang
2010-09-08 13:44   ` [PATCH 3/5] mfd: update chip id of 88pm8607 Haojian Zhuang
2010-09-08 13:44     ` [PATCH 4/5] input: monitor both onkey up and down event Haojian Zhuang
2010-09-08 13:44       ` [PATCH 5/5] mfd: fix max8925 irq control bit incorrect setting Haojian Zhuang
2010-09-13 13:50         ` Samuel Ortiz
2010-09-13 13:48     ` Samuel Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100913134830.GF2555@sortiz-mobl \
    --to=sameo@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).