linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] omap3: cm-t3517: add support for usb host.
Date: Thu, 16 Sep 2010 12:00:18 +0300	[thread overview]
Message-ID: <20100916090018.GM3393@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <1284627281-26059-4-git-send-email-grinberg@compulab.co.il>

Hi,

On Thu, Sep 16, 2010 at 03:54:39AM -0500, Igor Grinberg wrote:

put a description here.

>Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>---

[snip]

>+static int cm_t3517_init_usbh(void)
>+{
>+	int err;
>+
>+	err = gpio_request(USB_HUB_RESET_GPIO, "usb hub rst");
>+	if (err) {
>+		pr_err("CM-T3517: usb hub reset gpio request failed: %d\n",
>+		       err);
>+	} else {

if (err) {
	pr_err("...");
	return err;
}

gpio_direction_output(...);

this will save you on identation level.

-- 
balbi

  reply	other threads:[~2010-09-16  9:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16  8:54 [PATCH 0/5] Support for CompuLab CM-T3517 modules Igor Grinberg
2010-09-16  8:54 ` [PATCH 1/5] omap3: Introduce CompuLab CM-T3517 module Igor Grinberg
2010-09-16 17:53   ` Tony Lindgren
2010-09-19  8:58     ` Igor Grinberg
2010-09-16  8:54 ` [PATCH 2/5] omap3: cm-t3517: add support for v3020 rtc Igor Grinberg
2010-09-16  8:54 ` [PATCH 3/5] omap3: cm-t3517: add support for usb host Igor Grinberg
2010-09-16  9:00   ` Felipe Balbi [this message]
2010-09-16  9:12     ` Igor Grinberg
2010-09-16 17:48       ` Tony Lindgren
2010-09-19  9:00         ` Igor Grinberg
2010-09-20  6:39       ` Felipe Balbi
2010-09-20 14:46         ` Igor Grinberg
2010-09-21  7:07           ` Felipe Balbi
2010-09-16  8:54 ` [PATCH 4/5] omap3: cm-t3517: add support for NAND flash Igor Grinberg
2010-09-16  8:54 ` [PATCH 5/5] omap3: cm-t3517: add support for TI HECC Igor Grinberg
  -- strict thread matches above, loose matches on Subject: below --
2010-09-21 16:03 [PATCH 0/5] Support for CompuLab CM-T3517 modules Igor Grinberg
2010-09-21 16:03 ` [PATCH 3/5] omap3: cm-t3517: add support for usb host Igor Grinberg
2010-09-21 16:26   ` Gadiyar, Anand
2010-09-22  8:24     ` Igor Grinberg
2010-09-27 22:28       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100916090018.GM3393@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).