From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v4 1/4] omap3: nand: prefetch in irq mode support
Date: Tue, 21 Sep 2010 07:58:21 -0700 [thread overview]
Message-ID: <20100921145820.GQ4611@atomide.com> (raw)
In-Reply-To: <2A3DCF3DA181AD40BDE86A3150B27B6B031606213F@dbde02.ent.ti.com>
* Ghorai, Sukumar <s-ghorai@ti.com> [100918 11:16]:
> >
> > This handler should be in gpmc.c as it may be needed for other GPMC
> > connected devices on the same system. You can use chained irq handlers
> > to allow all the drivers to use the interrupt then.
>
> [Ghorai]
> You mean as this function used the gpmc-irq number in nand file, so handler should move to gpmc.c file?
Yes, other GPMC connected drivers may want to use it too for their chip selects.
> 1. For that we need to add one io-struct (to keep io buffer status) in gpmc.c;
>
> 2. Also need help how to sync between gpmc.c/omap_nand_irq() and omap2.c/omap_write_buf_irq_pref(), men how read/write function know that work done in interrupt-context? Or you prefer to move the complete IO function (omap_read/write_buf_irq_pref) to gpmc.c?
>
> 3. gpmc does not now about the read and write address that's applicable for NAND. So how to pass the IO address from omap2.c to gpmc.c, interrupt handler?
Hmm, I don't follow you. You can have the interrupt handler
both in gpmc.c and in the nand driver with set_irq_chained_handler()
and set_irq_data(). We are doing that already in lots of places,
like gpio.c and twl4030-irq.c.
> So, please let me know your suggestion again such that I can post this time itself. Otherwise again it will miss from coming release, this was posted/reviewed for last release too. And suggest to void repeating of missing release window again.
Yes would be nice to get this patch in, to me it seems that this
issue is the only blocker. It should be pretty easy change to
make.
Regards,
Tony
next prev parent reply other threads:[~2010-09-21 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 8:00 [PATCH RESEND v4 0/4] nand prefetch-irq support and ecc layout chanage Sukumar Ghorai
2010-09-16 8:00 ` [PATCH RESEND v4 1/4] omap3: nand: prefetch in irq mode support Sukumar Ghorai
2010-09-17 17:55 ` Tony Lindgren
2010-09-18 18:24 ` Ghorai, Sukumar
2010-09-21 14:58 ` Tony Lindgren [this message]
2010-09-24 12:33 ` Ghorai, Sukumar
2010-09-20 13:31 ` Ghorai, Sukumar
2010-09-21 12:54 ` Ghorai, Sukumar
2010-09-16 8:00 ` [PATCH RESEND v4 2/4] omap3: nand: configurable fifo threshold to gain the throughput Sukumar Ghorai
2010-09-16 8:00 ` [PATCH RESEND v4 3/4] omap: nand: ecc layout select from board file Sukumar Ghorai
2010-09-16 8:00 ` [PATCH RESEND v4 4/4] omap: nand: making ecc layout as compatible with romcode ecc Sukumar Ghorai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921145820.GQ4611@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).