From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] [ARM] tegra: add PCI Express support
Date: Tue, 21 Sep 2010 15:33:22 +0200 [thread overview]
Message-ID: <201009211533.23089.arnd@arndb.de> (raw)
In-Reply-To: <cfbe99c95d8d0ed7b5e139afc44ddaac@cox.rootnode.net>
On Tuesday 21 September 2010, Pawel Moll wrote:
> >> #define __io(a) __io(a)
> >> #define __mem_pci(a) (a)
> >
> > I wonder what the #else path is for. If you don't have PCI, who would
> > call __io? And wouldn't that result in a NULL pointer dereference?
>
> If I remember correctly the legacy IDE (ATA) code is scanning "well
> known" IO port numbers...
Right, that's the sort of thing I was worried about. I don't think
IDE is a problem here though, because it would only get probed
if you have a PCI/system/platform/of device registered to the
system, which normally doesn't happen.
Arnd
next prev parent reply other threads:[~2010-09-21 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 12:17 [PATCH v2 0/3] *** SUBJECT HERE *** Mike Rapoport
2010-09-21 12:17 ` [PATCH v2 1/3] [ARM] tegra: add PCI Express clocks Mike Rapoport
2010-09-21 12:17 ` [PATCH v2 2/3] [ARM] tegra: add PCI Express support Mike Rapoport
2010-09-21 12:30 ` Arnd Bergmann
2010-09-21 13:23 ` Pawel Moll
2010-09-21 13:33 ` Arnd Bergmann [this message]
2010-09-21 14:35 ` Mike Rapoport
2010-09-21 15:03 ` Arnd Bergmann
2010-09-21 12:17 ` [PATCH v2 3/3] [ARM] tegra: harmony: enable PCI Express Mike Rapoport
2010-09-23 15:22 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009211533.23089.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox