From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] OMAP: hwmod: Enable module wakeup if in smartidle
Date: Tue, 21 Sep 2010 18:19:34 -0600 [thread overview]
Message-ID: <20100922001931.8621.46565.stgit@twilight.localdomain> (raw)
In-Reply-To: <20100922001834.8621.76144.stgit@twilight.localdomain>
From: Rajendra Nayak <rnayak@ti.com>
If a module's OCP slave port is programmed to be in smartidle,
its also necessary that they have module level wakeup enabled.
Update _sysc_enable in hwmod framework to do this.
The thread "[PATCH 7/8] : Hwmod api changes" archived here:
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg34212.html
has additional technical information on the rationale of this patch.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Signed-off-by: Partha Basak <p-basak2@ti.com>
Signed-off-by: Beno?t Cousson <b-cousson@ti.com>
[paul at pwsan.com: revised patch description]
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
---
arch/arm/mach-omap2/omap_hwmod.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index f320cfb..3f3d61a 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -691,8 +691,6 @@ static void _sysc_enable(struct omap_hwmod *oh)
_set_module_autoidle(oh, idlemode, &v);
}
- /* XXX OCP ENAWAKEUP bit? */
-
/*
* XXX The clock framework should handle this, by
* calling into this code. But this must wait until the
@@ -703,6 +701,10 @@ static void _sysc_enable(struct omap_hwmod *oh)
_set_clockactivity(oh, oh->class->sysc->clockact, &v);
_write_sysconfig(v, oh);
+
+ /* If slave is in SMARTIDLE, also enable wakeup */
+ if ((sf & SYSC_HAS_SIDLEMODE) && !(oh->flags & HWMOD_SWSUP_SIDLE))
+ _enable_wakeup(oh);
}
/**
next prev parent reply other threads:[~2010-09-22 0:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 0:19 [PATCH 0/5] OMAP: hwmod: second set of core patches for 2.6.37 Paul Walmsley
2010-09-22 0:19 ` [PATCH 1/5] OMAP: hwmod: Fix softreset status check for some new OMAP4 IPs Paul Walmsley
2010-09-22 0:19 ` [PATCH 2/5] OMAP: hwmod: Fix softreset for modules with optional clocks Paul Walmsley
2010-09-22 0:19 ` Paul Walmsley [this message]
2010-09-22 9:41 ` [PATCH 3/5] OMAP: hwmod: Enable module wakeup if in smartidle Sergei Shtylyov
2010-09-22 15:22 ` Paul Walmsley
2010-09-22 0:19 ` [PATCH 4/5] OMAP: hwmod: Handle opt clocks node using clk_add_alias Paul Walmsley
2010-09-22 0:19 ` [PATCH 5/5] OMAP: hwmod: improve documentation, clean up function names Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922001931.8621.46565.stgit@twilight.localdomain \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox