From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91sam9g45: fix i2c bus speed
Date: Wed, 22 Sep 2010 16:34:06 +0200 [thread overview]
Message-ID: <20100922143406.GT32018@game.jcrosoft.org> (raw)
In-Reply-To: <87lj6uavde.fsf@macbook.be.48ers.dk>
On 13:08 Wed 22 Sep , Peter Korsgaard wrote:
> >>>>> "Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> writes:
>
> Hi,
>
> >> Use a correct udelay value to get bus speed around 100KHz. The udelay
> >> value was most likely copied from the older devices, but the 9g45
> >> is signicantly faster (400MHz, DDR, ..), so a udelay of 2 gives a
> >> bus speed of around 190KHz, which is too fast for some devices.
> >> A udelay value of 5 gives a bus speed of around 90KHz here.
> >>
> >> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>
> Jean-Christophe> in this case it will be better to overwite it at board
> Jean-Christophe> than force it for all of them
>
> You don't expect most 9g45 users will run at 400MHz? It seems pretty
> likely to me. In any case, a safe (but somewhat slow) default seems
> better than a potentially unsafe one.
>
> Now, I agree that it would be nice to add an interface to tweak this
> delay if needed (extra argument to at91_add_device_i2c()?), but that's
> next to the discussion about what the default should be.
I'd prefer to calculate it
so we specify which max freq we want in my mind it will be good to be as in
spi to specific per device it's max speed so we can adapt the bus freq
Best Regards,
J.
next prev parent reply other threads:[~2010-09-22 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 9:31 [PATCH] at91sam9g45: fix i2c bus speed Peter Korsgaard
2010-09-22 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 11:08 ` Peter Korsgaard
2010-09-22 14:34 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2010-09-22 14:54 ` Wolfgang Wegner
2010-09-22 16:09 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 15:18 ` Peter Korsgaard
2010-09-22 16:05 ` Nicolas Ferre
2010-09-22 16:10 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-22 16:06 ` Nicolas Ferre
2010-09-23 8:18 ` Nicolas Ferre
2010-09-23 9:22 ` Peter Korsgaard
2010-09-23 9:31 ` Russell King - ARM Linux
2010-09-23 10:09 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 10:24 ` Peter Korsgaard
2010-09-23 10:21 ` Peter Korsgaard
2010-09-23 10:36 ` Russell King - ARM Linux
2010-09-23 10:54 ` Peter Korsgaard
2010-09-23 11:16 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 11:32 ` Peter Korsgaard
2010-09-23 12:00 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-23 11:07 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922143406.GT32018@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).