linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] omap2 sparse fixes
Date: Fri, 24 Sep 2010 17:19:15 -0700	[thread overview]
Message-ID: <20100925001914.GO4211@atomide.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DB3F859E@dbde02.ent.ti.com>

* G, Manjunath Kondaiah <manjugk@ti.com> [100924 12:33]:
> 
> Tony,
> Here is new pull request which is rebased to 2.6.36-rc5.
> 
> -Manjunath
> 
> The following changes since commit b30a3f6257ed2105259b404d419b4964e363928c:
>   Linus Torvalds (1):
>         Linux 2.6.36-rc5
> 
> are available in the git repository at:
> 
>   git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
> 
> G, Manjunath Kondaiah (10):
>       OMAP: mach-omap2: Fix incorrect assignment warnings
>       OMAP: mach-omap2: Fix static declaration warnings
>       OMAP: mach-omap2: Fix static function warnings
>       OMAP: mach-omap2: Fix miscellaneous sparse warnings
>       OMAP: plat-omap: Fix static function warnings
>       OMAP: NAND: Fix static declaration warning
>       TWL CORE: Fix sparse warning
>       TWL IRQ: Fix fucntion declaration warnings
>       OMAP2/3: Convert write/read functions to raw read/write
>       OMAP3: Keypad: Fix incorrect type initializer

Hmm tried pulling these, but ran into an issue where at least 2430
takes about a minute to boot with these patches with no output
on the console intially.

Can you please check that? Will not merge for now until we
figure out what changes with these patches.

Then, I also noticed the following exports getting added:

+EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
+EXPORT_SYMBOL(omapfb_reserve_sram);
+EXPORT_SYMBOL(omap_sram_init);

These should not be exported, they are only intended to be called
from the low-level platform init code. So exporting them is not
the right fix for these.

Regards,

Tony

  reply	other threads:[~2010-09-25  0:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22  8:56 [GIT PULL] omap2 sparse fixes G, Manjunath Kondaiah
2010-09-23 22:58 ` Tony Lindgren
2010-09-24 19:43   ` G, Manjunath Kondaiah
2010-09-25  0:19     ` Tony Lindgren [this message]
2010-09-25  6:21       ` G, Manjunath Kondaiah
2010-09-27 13:41       ` G, Manjunath Kondaiah
2010-09-27 14:07         ` Russell King - ARM Linux
2010-09-27 15:00           ` G, Manjunath Kondaiah
2010-09-28  8:12       ` G, Manjunath Kondaiah
2010-09-28 15:21         ` Tony Lindgren
2010-09-28 15:35           ` G, Manjunath Kondaiah
2010-09-28 18:31             ` Tony Lindgren
2010-09-29 19:51               ` G, Manjunath Kondaiah
2010-09-29 21:56                 ` Tony Lindgren
2010-09-29 23:46                   ` G, Manjunath Kondaiah
2010-10-05  2:14                     ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2010-09-22  8:49 G, Manjunath Kondaiah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100925001914.GO4211@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).