From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings
Date: Mon, 27 Sep 2010 16:46:11 +0200 [thread overview]
Message-ID: <20100927144610.GH2560@sortiz-mobl> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DB3F8D1A@dbde02.ent.ti.com>
Hi Manjunath,
On Mon, Sep 27, 2010 at 07:19:33PM +0530, G, Manjunath Kondaiah wrote:
> > > No, we don't want to export those. Try defining them as extern from
> > > twl*-irq.c.
> >
> > Having extern in .c file will generate checkpatch warning as:
> > WARNING: externs should be avoided in .c files
>
> As an alternate, how about having twl-core.h in drivers/mfd and defining them
> as extern so that these API's will be available only to files under drivers/mfd?
>
That would be better, yes. Even though exporting those definititions through
linux/i2c/twl.h is harmless.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-09-27 14:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1285063280-4057-1-git-send-email-manjugk@ti.com>
[not found] ` <1285063280-4057-8-git-send-email-manjugk@ti.com>
2010-09-27 11:07 ` [PATCH v2 07/10] TWL CORE: Fix sparse warning Samuel Ortiz
[not found] ` <1285063280-4057-9-git-send-email-manjugk@ti.com>
2010-09-27 11:16 ` [PATCH v2 08/10] TWL IRQ: Fix fucntion declaration warnings Samuel Ortiz
2010-09-27 13:10 ` G, Manjunath Kondaiah
2010-09-27 13:49 ` G, Manjunath Kondaiah
2010-09-27 14:46 ` Samuel Ortiz [this message]
[not found] ` <1285063280-4057-4-git-send-email-manjugk@ti.com>
2010-09-29 21:35 ` [PATCH v2 03/10] OMAP: mach-omap2: Fix static function warnings Paul Walmsley
2010-09-29 23:49 ` G, Manjunath Kondaiah
[not found] ` <1285063280-4057-10-git-send-email-manjugk@ti.com>
2010-10-07 12:17 ` [PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write Menon, Nishanth
2010-10-07 18:56 ` Russell King - ARM Linux
2010-10-07 19:50 ` Nishanth Menon
2010-10-25 0:01 ` David Woodhouse
2010-10-25 5:34 ` G, Manjunath Kondaiah
2010-10-25 10:11 ` David Woodhouse
2010-10-25 7:54 ` Artem Bityutskiy
2010-10-07 17:39 ` Vimal Singh
[not found] ` <1285063280-4057-2-git-send-email-manjugk@ti.com>
2010-10-08 20:12 ` [PATCH v2 01/10] OMAP: mach-omap2: Fix incorrect assignment warnings Kevin Hilman
2010-10-11 3:51 ` G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927144610.GH2560@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).