* [GIT PULL] omap2 sparse fixes
@ 2010-09-22 8:49 G, Manjunath Kondaiah
0 siblings, 0 replies; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-22 8:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tony,
Please pull omap2 sparse fixes from:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
Regards,
Manjunath
The following changes since commit 8b15575cae7a93a784c3005c42b069edd9ba64dd:
Sage Weil (1):
fs: {lock,unlock}_flocks() stubs to prepare for BKL removal
are available in the git repository at:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
G, Manjunath Kondaiah (10):
OMAP: mach-omap2: Fix incorrect assignment warnings
OMAP: mach-omap2: Fix static declaration warnings
OMAP: mach-omap2: Fix static function warnings
OMAP: mach-omap2: Fix miscellaneous sparse warnings
OMAP: plat-omap: Fix static function warnings
OMAP: NAND: Fix static declaration warning
TWL CORE: Fix sparse warning
TWL IRQ: Fix fucntion declaration warnings
OMAP2/3: Convert write/read functions to raw read/write
OMAP3: Keypad: Fix incorrect type initializer
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-am3517evm.c | 5 +--
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 2 +-
arch/arm/mach-omap2/board-igep0020.c | 4 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-n8x0.c | 16 +------------
arch/arm/mach-omap2/board-omap3evm.c | 8 +++---
arch/arm/mach-omap2/board-omap3stalker.c | 4 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-rx51-peripherals.c | 4 ++-
arch/arm/mach-omap2/board-rx51-sdram.c | 2 +-
arch/arm/mach-omap2/board-rx51-video.c | 2 +
arch/arm/mach-omap2/board-zoom-debugboard.c | 2 +
arch/arm/mach-omap2/board-zoom-peripherals.c | 4 ++-
arch/arm/mach-omap2/control.c | 5 ++-
arch/arm/mach-omap2/gpmc-onenand.c | 8 +++---
arch/arm/mach-omap2/include/mach/board-flash.h | 2 +
arch/arm/mach-omap2/include/mach/board-rx51.h | 11 +++++++++
arch/arm/mach-omap2/irq.c | 1 -
arch/arm/mach-omap2/mux2420.c | 2 +-
arch/arm/mach-omap2/mux2430.c | 2 +-
arch/arm/mach-omap2/mux34xx.c | 12 +++++-----
arch/arm/mach-omap2/pm-debug.c | 2 +-
arch/arm/mach-omap2/pm34xx.c | 2 +-
arch/arm/mach-omap2/powerdomain.c | 28 ------------------------
arch/arm/mach-omap2/prcm.c | 2 +-
arch/arm/mach-omap2/timer-gp.c | 1 +
arch/arm/plat-omap/cpu-omap.c | 4 +-
arch/arm/plat-omap/dmtimer.c | 6 ++--
arch/arm/plat-omap/fb.c | 1 +
arch/arm/plat-omap/include/plat/dmtimer.h | 4 ++-
arch/arm/plat-omap/include/plat/sdrc.h | 1 +
arch/arm/plat-omap/mcbsp.c | 10 ++++----
arch/arm/plat-omap/sram.c | 13 ++++++-----
drivers/mfd/twl-core.c | 2 +-
drivers/mtd/nand/omap2.c | 6 ++--
drivers/mtd/onenand/omap2.c | 2 +-
include/linux/i2c/twl.h | 5 ++++
include/linux/omapfb.h | 5 ++++
40 files changed, 96 insertions(+), 102 deletions(-)
create mode 100644 arch/arm/mach-omap2/include/mach/board-rx51.h
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100922/8d8ec67f/attachment-0001.html>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
@ 2010-09-22 8:56 G, Manjunath Kondaiah
2010-09-23 22:58 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-22 8:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tony,
Please pull omap2 sparse fixes from:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
Regards,
Manjunath
The following changes since commit 8b15575cae7a93a784c3005c42b069edd9ba64dd:
Sage Weil (1):
fs: {lock,unlock}_flocks() stubs to prepare for BKL removal
are available in the git repository at:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
G, Manjunath Kondaiah (10):
OMAP: mach-omap2: Fix incorrect assignment warnings
OMAP: mach-omap2: Fix static declaration warnings
OMAP: mach-omap2: Fix static function warnings
OMAP: mach-omap2: Fix miscellaneous sparse warnings
OMAP: plat-omap: Fix static function warnings
OMAP: NAND: Fix static declaration warning
TWL CORE: Fix sparse warning
TWL IRQ: Fix fucntion declaration warnings
OMAP2/3: Convert write/read functions to raw read/write
OMAP3: Keypad: Fix incorrect type initializer
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-am3517evm.c | 5 +--
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 2 +-
arch/arm/mach-omap2/board-igep0020.c | 4 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-n8x0.c | 16 +------------
arch/arm/mach-omap2/board-omap3evm.c | 8 +++---
arch/arm/mach-omap2/board-omap3stalker.c | 4 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-rx51-peripherals.c | 4 ++-
arch/arm/mach-omap2/board-rx51-sdram.c | 2 +-
arch/arm/mach-omap2/board-rx51-video.c | 2 +
arch/arm/mach-omap2/board-zoom-debugboard.c | 2 +
arch/arm/mach-omap2/board-zoom-peripherals.c | 4 ++-
arch/arm/mach-omap2/control.c | 5 ++-
arch/arm/mach-omap2/gpmc-onenand.c | 8 +++---
arch/arm/mach-omap2/include/mach/board-flash.h | 2 +
arch/arm/mach-omap2/include/mach/board-rx51.h | 11 +++++++++
arch/arm/mach-omap2/irq.c | 1 -
arch/arm/mach-omap2/mux2420.c | 2 +-
arch/arm/mach-omap2/mux2430.c | 2 +-
arch/arm/mach-omap2/mux34xx.c | 12 +++++-----
arch/arm/mach-omap2/pm-debug.c | 2 +-
arch/arm/mach-omap2/pm34xx.c | 2 +-
arch/arm/mach-omap2/powerdomain.c | 28 ------------------------
arch/arm/mach-omap2/prcm.c | 2 +-
arch/arm/mach-omap2/timer-gp.c | 1 +
arch/arm/plat-omap/cpu-omap.c | 4 +-
arch/arm/plat-omap/dmtimer.c | 6 ++--
arch/arm/plat-omap/fb.c | 1 +
arch/arm/plat-omap/include/plat/dmtimer.h | 4 ++-
arch/arm/plat-omap/include/plat/sdrc.h | 1 +
arch/arm/plat-omap/mcbsp.c | 10 ++++----
arch/arm/plat-omap/sram.c | 13 ++++++-----
drivers/mfd/twl-core.c | 2 +-
drivers/mtd/nand/omap2.c | 6 ++--
drivers/mtd/onenand/omap2.c | 2 +-
include/linux/i2c/twl.h | 5 ++++
include/linux/omapfb.h | 5 ++++
40 files changed, 96 insertions(+), 102 deletions(-)
create mode 100644 arch/arm/mach-omap2/include/mach/board-rx51.h
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-22 8:56 [GIT PULL] omap2 sparse fixes G, Manjunath Kondaiah
@ 2010-09-23 22:58 ` Tony Lindgren
2010-09-24 19:43 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2010-09-23 22:58 UTC (permalink / raw)
To: linux-arm-kernel
* G, Manjunath Kondaiah <manjugk@ti.com> [100922 01:48]:
> Hi Tony,
>
> Please pull omap2 sparse fixes from:
>
> git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
>
> Regards,
> Manjunath
>
>
> The following changes since commit 8b15575cae7a93a784c3005c42b069edd9ba64dd:
> Sage Weil (1):
> fs: {lock,unlock}_flocks() stubs to prepare for BKL removal
>
> are available in the git repository at:
>
> git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
>
> G, Manjunath Kondaiah (10):
> OMAP: mach-omap2: Fix incorrect assignment warnings
> OMAP: mach-omap2: Fix static declaration warnings
> OMAP: mach-omap2: Fix static function warnings
> OMAP: mach-omap2: Fix miscellaneous sparse warnings
> OMAP: plat-omap: Fix static function warnings
> OMAP: NAND: Fix static declaration warning
> TWL CORE: Fix sparse warning
> TWL IRQ: Fix fucntion declaration warnings
> OMAP2/3: Convert write/read functions to raw read/write
> OMAP3: Keypad: Fix incorrect type initializer
Manjunath, this looks safe to pull, however one request though:
Can you please rebase it on v2.6.35 or v2.6.36-rc5?
Now your branch is on some commit after the -rc5 tag.
It's better to base branches at the most recent stable tag
(v2.6.35) or a recent -rc tag (v2.6.36-rc5).
Otherwise we end up moving our linux-omap tree forward too unless
I use git pull --rebase option.. I've updated the elinux.org wiki
instructions for that too, sorry if the earlier instructions there
were a bit unclear.
Thanks,
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-23 22:58 ` Tony Lindgren
@ 2010-09-24 19:43 ` G, Manjunath Kondaiah
2010-09-25 0:19 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-24 19:43 UTC (permalink / raw)
To: linux-arm-kernel
Tony,
Here is new pull request which is rebased to 2.6.36-rc5.
-Manjunath
The following changes since commit b30a3f6257ed2105259b404d419b4964e363928c:
Linus Torvalds (1):
Linux 2.6.36-rc5
are available in the git repository at:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
G, Manjunath Kondaiah (10):
OMAP: mach-omap2: Fix incorrect assignment warnings
OMAP: mach-omap2: Fix static declaration warnings
OMAP: mach-omap2: Fix static function warnings
OMAP: mach-omap2: Fix miscellaneous sparse warnings
OMAP: plat-omap: Fix static function warnings
OMAP: NAND: Fix static declaration warning
TWL CORE: Fix sparse warning
TWL IRQ: Fix fucntion declaration warnings
OMAP2/3: Convert write/read functions to raw read/write
OMAP3: Keypad: Fix incorrect type initializer
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-am3517evm.c | 5 +--
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 2 +-
arch/arm/mach-omap2/board-igep0020.c | 4 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-n8x0.c | 16 +------------
arch/arm/mach-omap2/board-omap3evm.c | 8 +++---
arch/arm/mach-omap2/board-omap3stalker.c | 4 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-rx51-peripherals.c | 4 ++-
arch/arm/mach-omap2/board-rx51-sdram.c | 2 +-
arch/arm/mach-omap2/board-rx51-video.c | 2 +
arch/arm/mach-omap2/board-zoom-debugboard.c | 2 +
arch/arm/mach-omap2/board-zoom-peripherals.c | 4 ++-
arch/arm/mach-omap2/control.c | 5 ++-
arch/arm/mach-omap2/gpmc-onenand.c | 8 +++---
arch/arm/mach-omap2/include/mach/board-flash.h | 2 +
arch/arm/mach-omap2/include/mach/board-rx51.h | 11 +++++++++
arch/arm/mach-omap2/irq.c | 1 -
arch/arm/mach-omap2/mux2420.c | 2 +-
arch/arm/mach-omap2/mux2430.c | 2 +-
arch/arm/mach-omap2/mux34xx.c | 12 +++++-----
arch/arm/mach-omap2/pm-debug.c | 2 +-
arch/arm/mach-omap2/pm34xx.c | 2 +-
arch/arm/mach-omap2/powerdomain.c | 28 ------------------------
arch/arm/mach-omap2/prcm.c | 2 +-
arch/arm/mach-omap2/timer-gp.c | 1 +
arch/arm/plat-omap/cpu-omap.c | 4 +-
arch/arm/plat-omap/dmtimer.c | 6 ++--
arch/arm/plat-omap/fb.c | 1 +
arch/arm/plat-omap/include/plat/dmtimer.h | 4 ++-
arch/arm/plat-omap/include/plat/sdrc.h | 1 +
arch/arm/plat-omap/mcbsp.c | 10 ++++----
arch/arm/plat-omap/sram.c | 13 ++++++-----
drivers/mfd/twl-core.c | 2 +-
drivers/mtd/nand/omap2.c | 6 ++--
drivers/mtd/onenand/omap2.c | 2 +-
include/linux/i2c/twl.h | 5 ++++
include/linux/omapfb.h | 5 ++++
40 files changed, 96 insertions(+), 102 deletions(-)
create mode 100644 arch/arm/mach-omap2/include/mach/board-rx51.h
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Friday, September 24, 2010 4:29 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100922 01:48]:
> > Hi Tony,
> >
> > Please pull omap2 sparse fixes from:
> >
> > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > sparse_fixes
> >
> > Regards,
> > Manjunath
> >
> >
> > The following changes since commit
> 8b15575cae7a93a784c3005c42b069edd9ba64dd:
> > Sage Weil (1):
> > fs: {lock,unlock}_flocks() stubs to prepare for BKL removal
> >
> > are available in the git repository at:
> >
> > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > sparse_fixes
> >
> > G, Manjunath Kondaiah (10):
> > OMAP: mach-omap2: Fix incorrect assignment warnings
> > OMAP: mach-omap2: Fix static declaration warnings
> > OMAP: mach-omap2: Fix static function warnings
> > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > OMAP: plat-omap: Fix static function warnings
> > OMAP: NAND: Fix static declaration warning
> > TWL CORE: Fix sparse warning
> > TWL IRQ: Fix fucntion declaration warnings
> > OMAP2/3: Convert write/read functions to raw read/write
> > OMAP3: Keypad: Fix incorrect type initializer
>
> Manjunath, this looks safe to pull, however one request though:
> Can you please rebase it on v2.6.35 or v2.6.36-rc5?
>
> Now your branch is on some commit after the -rc5 tag.
> It's better to base branches at the most recent stable tag
> (v2.6.35) or a recent -rc tag (v2.6.36-rc5).
>
> Otherwise we end up moving our linux-omap tree forward too
> unless I use git pull --rebase option.. I've updated the
> elinux.org wiki instructions for that too, sorry if the
> earlier instructions there were a bit unclear.
>
> Thanks,
>
> Tony
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-24 19:43 ` G, Manjunath Kondaiah
@ 2010-09-25 0:19 ` Tony Lindgren
2010-09-25 6:21 ` G, Manjunath Kondaiah
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Tony Lindgren @ 2010-09-25 0:19 UTC (permalink / raw)
To: linux-arm-kernel
* G, Manjunath Kondaiah <manjugk@ti.com> [100924 12:33]:
>
> Tony,
> Here is new pull request which is rebased to 2.6.36-rc5.
>
> -Manjunath
>
> The following changes since commit b30a3f6257ed2105259b404d419b4964e363928c:
> Linus Torvalds (1):
> Linux 2.6.36-rc5
>
> are available in the git repository at:
>
> git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes
>
> G, Manjunath Kondaiah (10):
> OMAP: mach-omap2: Fix incorrect assignment warnings
> OMAP: mach-omap2: Fix static declaration warnings
> OMAP: mach-omap2: Fix static function warnings
> OMAP: mach-omap2: Fix miscellaneous sparse warnings
> OMAP: plat-omap: Fix static function warnings
> OMAP: NAND: Fix static declaration warning
> TWL CORE: Fix sparse warning
> TWL IRQ: Fix fucntion declaration warnings
> OMAP2/3: Convert write/read functions to raw read/write
> OMAP3: Keypad: Fix incorrect type initializer
Hmm tried pulling these, but ran into an issue where at least 2430
takes about a minute to boot with these patches with no output
on the console intially.
Can you please check that? Will not merge for now until we
figure out what changes with these patches.
Then, I also noticed the following exports getting added:
+EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
+EXPORT_SYMBOL(omapfb_reserve_sram);
+EXPORT_SYMBOL(omap_sram_init);
These should not be exported, they are only intended to be called
from the low-level platform init code. So exporting them is not
the right fix for these.
Regards,
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-25 0:19 ` Tony Lindgren
@ 2010-09-25 6:21 ` G, Manjunath Kondaiah
2010-09-27 13:41 ` G, Manjunath Kondaiah
2010-09-28 8:12 ` G, Manjunath Kondaiah
2 siblings, 0 replies; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-25 6:21 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Saturday, September 25, 2010 5:49 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100924 12:33]:
> >
> > Tony,
> > Here is new pull request which is rebased to 2.6.36-rc5.
> >
> > -Manjunath
> >
> > The following changes since commit
> b30a3f6257ed2105259b404d419b4964e363928c:
> > Linus Torvalds (1):
> > Linux 2.6.36-rc5
> >
> > are available in the git repository at:
> >
> > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > sparse_fixes
> >
> > G, Manjunath Kondaiah (10):
> > OMAP: mach-omap2: Fix incorrect assignment warnings
> > OMAP: mach-omap2: Fix static declaration warnings
> > OMAP: mach-omap2: Fix static function warnings
> > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > OMAP: plat-omap: Fix static function warnings
> > OMAP: NAND: Fix static declaration warning
> > TWL CORE: Fix sparse warning
> > TWL IRQ: Fix fucntion declaration warnings
> > OMAP2/3: Convert write/read functions to raw read/write
> > OMAP3: Keypad: Fix incorrect type initializer
>
> Hmm tried pulling these, but ran into an issue where at least
> 2430 takes about a minute to boot with these patches with no
> output on the console intially.
>
> Can you please check that? Will not merge for now until we
> figure out what changes with these patches.
Sure. I will check and verify this issue.
>
> Then, I also noticed the following exports getting added:
>
> +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
> +EXPORT_SYMBOL(omapfb_reserve_sram);
> +EXPORT_SYMBOL(omap_sram_init);
How about having it as extern functions in header file instead of
exporting?
-Manjunath
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-25 0:19 ` Tony Lindgren
2010-09-25 6:21 ` G, Manjunath Kondaiah
@ 2010-09-27 13:41 ` G, Manjunath Kondaiah
2010-09-27 14:07 ` Russell King - ARM Linux
2010-09-28 8:12 ` G, Manjunath Kondaiah
2 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-27 13:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tony,
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Saturday, September 25, 2010 5:49 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100924 12:33]:
> >
> > Tony,
> > Here is new pull request which is rebased to 2.6.36-rc5.
> >
> > -Manjunath
> >
> > The following changes since commit
> b30a3f6257ed2105259b404d419b4964e363928c:
> > Linus Torvalds (1):
> > Linux 2.6.36-rc5
> >
> > are available in the git repository at:
> >
> > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > sparse_fixes
> >
> > G, Manjunath Kondaiah (10):
> > OMAP: mach-omap2: Fix incorrect assignment warnings
> > OMAP: mach-omap2: Fix static declaration warnings
> > OMAP: mach-omap2: Fix static function warnings
> > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > OMAP: plat-omap: Fix static function warnings
> > OMAP: NAND: Fix static declaration warning
> > TWL CORE: Fix sparse warning
> > TWL IRQ: Fix fucntion declaration warnings
> > OMAP2/3: Convert write/read functions to raw read/write
> > OMAP3: Keypad: Fix incorrect type initializer
>
> Hmm tried pulling these, but ran into an issue where at least
> 2430 takes about a minute to boot with these patches with no
> output on the console intially.
Here is test report for all the boards:
1. omap3_defconfig with 2.6.36-rc5 code as is does not seems to be
boot. Enabled early printk and found it was due to musb driver.
Boot log is here:
2430sdp_omap3_defconfig_bootlog_nochanges2code.txt
http://pastebin.com/wd92PMmE
2. Disabled musb in omap3_defconfig and boot seems be fine.
2430sdp_omap3_defconfig_bootlog_usbdisable
http://pastebin.com/eExED5q4
3. With sparse fix series, booting is as expected with omap3_defconfig
2430sdp_omap3_defconfig_bootlog_usbdisable_sparse_fixes.txt
http://pastebin.com/GMX4y2fS
4. Here zoom3 boot log:
Zoom3_omap3_defconfig_bootlog_usbdisable_sparse_fixes.
http://pastebin.com/C2A6YXAL
5. omap4 sdp boot log(with es2.0 patches pulled from for-next branch)
omap4sdp_es2.0_omap3_defconfig_bootlog_sparse_fixes.
http://pastebin.com/ebiP1X2h
>
> Can you please check that? Will not merge for now until we
> figure out what changes with these patches.
>
> Then, I also noticed the following exports getting added:
>
> +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
> +EXPORT_SYMBOL(omapfb_reserve_sram);
> +EXPORT_SYMBOL(omap_sram_init);
>
> These should not be exported, they are only intended to be
> called from the low-level platform init code. So exporting
> them is not the right fix for these.
I have declared these API's as extern functions in respective
header files. If it is ok, I can push the changes to git branch
for pull request.
-Manjunath
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-27 13:41 ` G, Manjunath Kondaiah
@ 2010-09-27 14:07 ` Russell King - ARM Linux
2010-09-27 15:00 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 17+ messages in thread
From: Russell King - ARM Linux @ 2010-09-27 14:07 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 27, 2010 at 07:11:37PM +0530, G, Manjunath Kondaiah wrote:
> > Can you please check that? Will not merge for now until we
> > figure out what changes with these patches.
> >
> > Then, I also noticed the following exports getting added:
> >
> > +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
> > +EXPORT_SYMBOL(omapfb_reserve_sram);
> > +EXPORT_SYMBOL(omap_sram_init);
> >
> > These should not be exported, they are only intended to be
> > called from the low-level platform init code. So exporting
> > them is not the right fix for these.
>
> I have declared these API's as extern functions in respective
> header files.
It's hard to tell whether you're justifying having the EXPORT_SYMBOLs
there or not from your reply.
Just because you add them as declarations to a header file does not mean
you have to add EXPORT_SYMBOLs for them. The only thing that this macro
does is make them available to modules.
In any case, if functions are marked as __init (or similar, which some
are) then they must not be exported - they won't exist when modules are
available to be loaded. Instead, their symbols will point to some
random data which has replaced the code.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-27 14:07 ` Russell King - ARM Linux
@ 2010-09-27 15:00 ` G, Manjunath Kondaiah
0 siblings, 0 replies; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-27 15:00 UTC (permalink / raw)
To: linux-arm-kernel
Hi Russell,
> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Sent: Monday, September 27, 2010 7:38 PM
> To: G, Manjunath Kondaiah
> Cc: Tony Lindgren; linux-omap at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> On Mon, Sep 27, 2010 at 07:11:37PM +0530, G, Manjunath Kondaiah wrote:
> > > Can you please check that? Will not merge for now until we figure
> > > out what changes with these patches.
> > >
> > > Then, I also noticed the following exports getting added:
> > >
> > > +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
> > > +EXPORT_SYMBOL(omapfb_reserve_sram);
> > > +EXPORT_SYMBOL(omap_sram_init);
> > >
> > > These should not be exported, they are only intended to be called
> > > from the low-level platform init code. So exporting them
> is not the
> > > right fix for these.
> >
> > I have declared these API's as extern functions in
> respective header
> > files.
>
> It's hard to tell whether you're justifying having the
> EXPORT_SYMBOLs there or not from your reply.
I tried following approches in order to fix these warnings:
1. Having these defines in .c files as extern functions.
It will generate checkpatch error if it is declared as
extern in .c file.
2. Moving/creating header file to source code location.
This will resolve only "omap2_gp_clockevent_set_gptimer" function
since other functions are used in source files in different directories.
Only option came to my mind is, having it in header file either
in plat or mach headers. As you said, even though it is not explicitely
declared as "EXPORT", the functions are available for all other files.
-Manjunath
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-25 0:19 ` Tony Lindgren
2010-09-25 6:21 ` G, Manjunath Kondaiah
2010-09-27 13:41 ` G, Manjunath Kondaiah
@ 2010-09-28 8:12 ` G, Manjunath Kondaiah
2010-09-28 15:21 ` Tony Lindgren
2 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-28 8:12 UTC (permalink / raw)
To: linux-arm-kernel
Tony,
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Saturday, September 25, 2010 5:49 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100924 12:33]:
> >
> > Tony,
> > Here is new pull request which is rebased to 2.6.36-rc5.
> >
> > -Manjunath
> >
> > The following changes since commit
> b30a3f6257ed2105259b404d419b4964e363928c:
> > Linus Torvalds (1):
> > Linux 2.6.36-rc5
> >
> > are available in the git repository at:
> >
> > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > sparse_fixes
> >
> > G, Manjunath Kondaiah (10):
> > OMAP: mach-omap2: Fix incorrect assignment warnings
> > OMAP: mach-omap2: Fix static declaration warnings
> > OMAP: mach-omap2: Fix static function warnings
> > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > OMAP: plat-omap: Fix static function warnings
> > OMAP: NAND: Fix static declaration warning
> > TWL CORE: Fix sparse warning
> > TWL IRQ: Fix fucntion declaration warnings
> > OMAP2/3: Convert write/read functions to raw read/write
> > OMAP3: Keypad: Fix incorrect type initializer
>
> Hmm tried pulling these, but ran into an issue where at least
> 2430 takes about a minute to boot with these patches with no
> output on the console intially.
>
> Can you please check that? Will not merge for now until we
> figure out what changes with these patches.
>
> Then, I also noticed the following exports getting added:
>
> +EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
> +EXPORT_SYMBOL(omapfb_reserve_sram);
> +EXPORT_SYMBOL(omap_sram_init);
>
> These should not be exported, they are only intended to be
> called from the low-level platform init code. So exporting
> them is not the right fix for these.
Similar comments received for twl irq apis's hence it was aligned
to declare these functions as extern functions in local header(if exists)
or create new header in the source file directory for these declarations.
Three patches are fixed using above method which are:
OMAP: mach-omap2: Fix static function warnings
OMAP: plat-omap: Fix static function warnings
TWL IRQ: Fix fucntion declaration warnings
The patch series is tested on below boards(with omap3_defconfig)
and links for boot logs is provided below:
beagle boot log:
http://pastebin.com/jz6ZGHsH
zoom3 boot log:
http://pastebin.com/T0YjunCk
2430sdp boot log:
http://pastebin.com/7BbpieYS
As I mentioned in other e-mail, 2430sdp with omap3_defconfig boots
only after disabling usb. OMAP4SDPES2.0 boots with ES2.0 patches from
for-next branch.
Here is all parse errors fixed with this series:
Sparse warns before fixes:
http://pastebin.com/yct2p201
Sparse warns after fixes:
http://pastebin.com/qpnTbYwL
All the tested patches are pushed to new branch at:
The following changes since commit b30a3f6257ed2105259b404d419b4964e363928c:
Linus Torvalds (1):
Linux 2.6.36-rc5
are available in the git repository at:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes_v3
G, Manjunath Kondaiah (10):
OMAP: mach-omap2: Fix incorrect assignment warnings
OMAP: mach-omap2: Fix static declaration warnings
OMAP2plus: Fix static function warnings
OMAP: mach-omap2: Fix miscellaneous sparse warnings
OMAP: plat-omap: Fix static function warnings
OMAP: NAND: Fix static declaration warning
TWL CORE: Fix sparse warning
TWL IRQ: Fix fucntion declaration warnings
OMAP2/3: Convert write/read functions to raw read/write
OMAP3: Keypad: Fix incorrect type initializer
-Manjunath
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-28 8:12 ` G, Manjunath Kondaiah
@ 2010-09-28 15:21 ` Tony Lindgren
2010-09-28 15:35 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2010-09-28 15:21 UTC (permalink / raw)
To: linux-arm-kernel
* G, Manjunath Kondaiah <manjugk@ti.com> [100928 01:04]:
>
> Three patches are fixed using above method which are:
> OMAP: mach-omap2: Fix static function warnings
> OMAP: plat-omap: Fix static function warnings
> TWL IRQ: Fix fucntion declaration warnings
OK thanks.
> are available in the git repository at:
>
> git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git sparse_fixes_v3
>
> G, Manjunath Kondaiah (10):
> OMAP: mach-omap2: Fix incorrect assignment warnings
> OMAP: mach-omap2: Fix static declaration warnings
> OMAP2plus: Fix static function warnings
> OMAP: mach-omap2: Fix miscellaneous sparse warnings
> OMAP: plat-omap: Fix static function warnings
> OMAP: NAND: Fix static declaration warning
> TWL CORE: Fix sparse warning
> TWL IRQ: Fix fucntion declaration warnings
Didn't Samuel just reply that he has applied these two TWL fixes?
> OMAP2/3: Convert write/read functions to raw read/write
> OMAP3: Keypad: Fix incorrect type initializer
Regards,
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-28 15:21 ` Tony Lindgren
@ 2010-09-28 15:35 ` G, Manjunath Kondaiah
2010-09-28 18:31 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-28 15:35 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Tuesday, September 28, 2010 8:52 PM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Dmitry
> Torokhov; linux-mtd at lists.infradead.org; Russell King - ARM Linux
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100928 01:04]:
> >
> > Three patches are fixed using above method which are:
> > OMAP: mach-omap2: Fix static function warnings
> > OMAP: plat-omap: Fix static function warnings TWL IRQ: Fix fucntion
> > declaration warnings
>
> OK thanks.
>
> > are available in the git repository at:
> >
> > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > sparse_fixes_v3
> >
> > G, Manjunath Kondaiah (10):
> > OMAP: mach-omap2: Fix incorrect assignment warnings
> > OMAP: mach-omap2: Fix static declaration warnings
> > OMAP2plus: Fix static function warnings
> > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > OMAP: plat-omap: Fix static function warnings
> > OMAP: NAND: Fix static declaration warning
> > TWL CORE: Fix sparse warning
> > TWL IRQ: Fix fucntion declaration warnings
>
> Didn't Samuel just reply that he has applied these two TWL fixes?
Samuel applied only one patch and other patch is yet to be applied.
Do you want me to pull out these two twl patches from the series?
-Manjunath
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-28 15:35 ` G, Manjunath Kondaiah
@ 2010-09-28 18:31 ` Tony Lindgren
2010-09-29 19:51 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2010-09-28 18:31 UTC (permalink / raw)
To: linux-arm-kernel
* G, Manjunath Kondaiah <manjugk@ti.com> [100928 08:26]:
>
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony at atomide.com]
> > Sent: Tuesday, September 28, 2010 8:52 PM
> > To: G, Manjunath Kondaiah
> > Cc: linux-omap at vger.kernel.org;
> > linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Dmitry
> > Torokhov; linux-mtd at lists.infradead.org; Russell King - ARM Linux
> > Subject: Re: [GIT PULL] omap2 sparse fixes
> >
> > * G, Manjunath Kondaiah <manjugk@ti.com> [100928 01:04]:
> > >
> > > Three patches are fixed using above method which are:
> > > OMAP: mach-omap2: Fix static function warnings
> > > OMAP: plat-omap: Fix static function warnings TWL IRQ: Fix fucntion
> > > declaration warnings
> >
> > OK thanks.
> >
> > > are available in the git repository at:
> > >
> > > git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git
> > > sparse_fixes_v3
> > >
> > > G, Manjunath Kondaiah (10):
> > > OMAP: mach-omap2: Fix incorrect assignment warnings
> > > OMAP: mach-omap2: Fix static declaration warnings
> > > OMAP2plus: Fix static function warnings
> > > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > > OMAP: plat-omap: Fix static function warnings
> > > OMAP: NAND: Fix static declaration warning
> > > TWL CORE: Fix sparse warning
> > > TWL IRQ: Fix fucntion declaration warnings
> >
> > Didn't Samuel just reply that he has applied these two TWL fixes?
>
> Samuel applied only one patch and other patch is yet to be applied.
> Do you want me to pull out these two twl patches from the series?
Yes please take out all patches that are not in arch/arm/*omap*/ path.
The others really should go to the driver maintainers.
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-28 18:31 ` Tony Lindgren
@ 2010-09-29 19:51 ` G, Manjunath Kondaiah
2010-09-29 21:56 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-29 19:51 UTC (permalink / raw)
To: linux-arm-kernel
Tony,
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Wednesday, September 29, 2010 12:02 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Dmitry
> Torokhov; linux-mtd at lists.infradead.org; Russell King - ARM Linux
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100928 08:26]:
...
> Yes please take out all patches that are not in arch/arm/*omap*/ path.
> The others really should go to the driver maintainers.
>
> Tony
Here is new branch which has only arch/arm/*omap*/ related patches.
-Manjunath
The following changes since commit 899611ee7d373e5eeda08e9a8632684e1ebbbf00:
Linus Torvalds (1):
Linux 2.6.36-rc6
are available in the git repository at:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git omap_sparse_fixes
G, Manjunath Kondaiah (7):
OMAP: mach-omap2: Fix incorrect assignment warnings
OMAP: mach-omap2: Fix static declaration warnings
OMAP: mach-omap2: Fix static function warnings
OMAP: mach-omap2: Fix miscellaneous sparse warnings
OMAP: plat-omap: Fix static function warnings
OMAP: Convert write/read functions to raw read/write
OMAP3: Keypad: Fix incorrect type initializer
arch/arm/mach-omap2/board-3430sdp.c | 2 +-
arch/arm/mach-omap2/board-4430sdp.c | 3 +-
arch/arm/mach-omap2/board-am3517evm.c | 5 +--
arch/arm/mach-omap2/board-cm-t35.c | 2 +-
arch/arm/mach-omap2/board-devkit8000.c | 4 +-
arch/arm/mach-omap2/board-igep0020.c | 4 +-
arch/arm/mach-omap2/board-ldp.c | 2 +-
arch/arm/mach-omap2/board-n8x0.c | 16 +----------
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
arch/arm/mach-omap2/board-omap3evm.c | 8 +++---
arch/arm/mach-omap2/board-omap3stalker.c | 6 ++--
arch/arm/mach-omap2/board-omap3touchbook.c | 4 +-
arch/arm/mach-omap2/board-omap4panda.c | 2 +-
arch/arm/mach-omap2/board-rx51-peripherals.c | 4 ++-
arch/arm/mach-omap2/board-rx51-sdram.c | 2 +-
arch/arm/mach-omap2/board-rx51-video.c | 2 +
arch/arm/mach-omap2/board-zoom-debugboard.c | 2 +
arch/arm/mach-omap2/board-zoom-peripherals.c | 4 ++-
arch/arm/mach-omap2/control.c | 5 ++-
arch/arm/mach-omap2/gpmc-onenand.c | 8 +++---
arch/arm/mach-omap2/include/mach/board-flash.h | 2 +
arch/arm/mach-omap2/include/mach/board-rx51.h | 11 ++++++++
arch/arm/mach-omap2/io.c | 1 +
arch/arm/mach-omap2/io.h | 7 +++++
arch/arm/mach-omap2/irq.c | 1 -
arch/arm/mach-omap2/mux2420.c | 2 +-
arch/arm/mach-omap2/mux2430.c | 2 +-
arch/arm/mach-omap2/mux34xx.c | 12 ++++----
arch/arm/mach-omap2/pm-debug.c | 2 +-
arch/arm/mach-omap2/pm34xx.c | 2 +-
arch/arm/mach-omap2/powerdomain.c | 28 --------------------
arch/arm/mach-omap2/prcm.c | 2 +-
.../include/plat => mach-omap2}/timer-gp.h | 3 +-
arch/arm/plat-omap/cpu-omap.c | 4 +-
arch/arm/plat-omap/dmtimer.c | 6 ++--
arch/arm/plat-omap/fb.c | 2 +
arch/arm/plat-omap/fb.h | 10 +++++++
arch/arm/plat-omap/include/plat/dmtimer.h | 4 ++-
arch/arm/plat-omap/include/plat/sdrc.h | 1 +
arch/arm/plat-omap/include/plat/sram.h | 1 -
arch/arm/plat-omap/mcbsp.c | 10 +++---
arch/arm/plat-omap/sram.c | 21 ++++++--------
arch/arm/plat-omap/sram.h | 6 ++++
43 files changed, 115 insertions(+), 112 deletions(-)
create mode 100644 arch/arm/mach-omap2/include/mach/board-rx51.h
create mode 100644 arch/arm/mach-omap2/io.h
rename arch/arm/{plat-omap/include/plat => mach-omap2}/timer-gp.h (86%)
create mode 100644 arch/arm/plat-omap/fb.h
create mode 100644 arch/arm/plat-omap/sram.h
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-29 19:51 ` G, Manjunath Kondaiah
@ 2010-09-29 21:56 ` Tony Lindgren
2010-09-29 23:46 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2010-09-29 21:56 UTC (permalink / raw)
To: linux-arm-kernel
* G, Manjunath Kondaiah <manjugk@ti.com> [100929 12:42]:
>
> Tony,
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony at atomide.com]
> > Sent: Wednesday, September 29, 2010 12:02 AM
> > To: G, Manjunath Kondaiah
> > Cc: linux-omap at vger.kernel.org;
> > linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Dmitry
> > Torokhov; linux-mtd at lists.infradead.org; Russell King - ARM Linux
> > Subject: Re: [GIT PULL] omap2 sparse fixes
> >
> > * G, Manjunath Kondaiah <manjugk@ti.com> [100928 08:26]:
> ...
>
> > Yes please take out all patches that are not in arch/arm/*omap*/ path.
> > The others really should go to the driver maintainers.
> >
> > Tony
>
> Here is new branch which has only arch/arm/*omap*/ related patches.
Thanks. Noticed one more thing though:
In your patch "OMAP: mach-omap2: Fix static function warnings" looks like
you're adding omap2_gp_clockevent_set_gptimer twice:
--- a/arch/arm/plat-omap/include/plat/timer-gp.h
+++ b/arch/arm/mach-omap2/timer-gp.h
@@ -11,7 +11,6 @@
#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_MACH_TIMER_GP_H
#define __ARCH_ARM_PLAT_OMAP_INCLUDE_MACH_TIMER_GP_H
-int __init omap2_gp_clockevent_set_gptimer(u8 id);
+extern int __init omap2_gp_clockevent_set_gptimer(u8 id);
#endif
-
--- a/arch/arm/plat-omap/include/plat/dmtimer.h
+++ b/arch/arm/plat-omap/include/plat/dmtimer.h
@@ -81,6 +81,6 @@ unsigned int omap_dm_timer_read_counter(struct omap_dm_timer *timer);
void omap_dm_timer_write_counter(struct omap_dm_timer *timer, unsigned int value);
int omap_dm_timers_active(void);
-
+int omap2_gp_clockevent_set_gptimer(u8 id);
#endif /* __ASM_ARCH_DMTIMER_H */
Please also be careful that your branch contains the same patches
as you've posted for review. Nobody wants to pull different stuff
than what was posted! Also looks like Paul had one comment related
to the same patch.
Regards,
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-29 21:56 ` Tony Lindgren
@ 2010-09-29 23:46 ` G, Manjunath Kondaiah
2010-10-05 2:14 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-29 23:46 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Thursday, September 30, 2010 3:27 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Dmitry
> Torokhov; linux-mtd at lists.infradead.org; Russell King - ARM Linux
> Subject: Re: [GIT PULL] omap2 sparse fixes
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100929 12:42]:
> >
> > Tony,
> >
> > > -----Original Message-----
> > > From: Tony Lindgren [mailto:tony at atomide.com]
> > > Sent: Wednesday, September 29, 2010 12:02 AM
> > > To: G, Manjunath Kondaiah
> > > Cc: linux-omap at vger.kernel.org;
> > > linux-arm-kernel at lists.infradead.org; Samuel Ortiz;
> Dmitry Torokhov;
> > > linux-mtd at lists.infradead.org; Russell King - ARM Linux
> > > Subject: Re: [GIT PULL] omap2 sparse fixes
> > >
> > > * G, Manjunath Kondaiah <manjugk@ti.com> [100928 08:26]:
> > ...
> >
> > > Yes please take out all patches that are not in
> arch/arm/*omap*/ path.
> > > The others really should go to the driver maintainers.
> > >
> > > Tony
> >
> > Here is new branch which has only arch/arm/*omap*/ related patches.
>
> Thanks. Noticed one more thing though:
>
> In your patch "OMAP: mach-omap2: Fix static function
> warnings" looks like you're adding
> omap2_gp_clockevent_set_gptimer twice:
Sorry I missed removing this while adding it in timer-gp.h. Also, I noticed
in the same patch, the board_nand_init nd board_flash_init functions are
exported thrgough board-flash.h.
I moved board-flash.h from mach/board-flash.h to mach-omap2/board-flash.h so
that only board files can access these functions.
>
> --- a/arch/arm/plat-omap/include/plat/timer-gp.h
> +++ b/arch/arm/mach-omap2/timer-gp.h
> @@ -11,7 +11,6 @@
> #ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_MACH_TIMER_GP_H
> #define __ARCH_ARM_PLAT_OMAP_INCLUDE_MACH_TIMER_GP_H
>
> -int __init omap2_gp_clockevent_set_gptimer(u8 id);
> +extern int __init omap2_gp_clockevent_set_gptimer(u8 id);
>
> #endif
> -
> --- a/arch/arm/plat-omap/include/plat/dmtimer.h
> +++ b/arch/arm/plat-omap/include/plat/dmtimer.h
> @@ -81,6 +81,6 @@ unsigned int
> omap_dm_timer_read_counter(struct omap_dm_timer *timer);
> void omap_dm_timer_write_counter(struct omap_dm_timer *timer,
> unsigned int value);
>
> int omap_dm_timers_active(void);
> -
> +int omap2_gp_clockevent_set_gptimer(u8 id);
Removed.
>
> #endif /* __ASM_ARCH_DMTIMER_H */
>
> Please also be careful that your branch contains the same
> patches as you've posted for review. Nobody wants to pull
> different stuff than what was posted! Also looks like Paul
> had one comment related to the same patch.
Patches are same except pulling out twl and driver patches from
the series.
Paul's comment is addressed and changes are pushed to git branch.
Build tested with omap3_defconfig and boot tested with beagle board.
The following changes since commit 899611ee7d373e5eeda08e9a8632684e1ebbbf00:
Linus Torvalds (1):
Linux 2.6.36-rc6
are available in the git repository at:
git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git omap_sparse_fixesv2
G, Manjunath Kondaiah (7):
OMAP: mach-omap2: Fix incorrect assignment warnings
OMAP: mach-omap2: Fix static declaration warnings
OMAP2plus: Fix static function warnings
OMAP: mach-omap2: Fix miscellaneous sparse warnings
OMAP: plat-omap: Fix static function warnings
OMAP: Convert write/read functions to raw read/write
OMAP3: Keypad: Fix incorrect type initializer
-Manjunath
^ permalink raw reply [flat|nested] 17+ messages in thread
* [GIT PULL] omap2 sparse fixes
2010-09-29 23:46 ` G, Manjunath Kondaiah
@ 2010-10-05 2:14 ` Tony Lindgren
0 siblings, 0 replies; 17+ messages in thread
From: Tony Lindgren @ 2010-10-05 2:14 UTC (permalink / raw)
To: linux-arm-kernel
* G, Manjunath Kondaiah <manjugk@ti.com> [100929 16:38]:
>
> Patches are same except pulling out twl and driver patches from
> the series.
>
> Paul's comment is addressed and changes are pushed to git branch.
> Build tested with omap3_defconfig and boot tested with beagle board.
Thanks, pulling this into omap-for-linus.
Tony
> The following changes since commit 899611ee7d373e5eeda08e9a8632684e1ebbbf00:
> Linus Torvalds (1):
> Linux 2.6.36-rc6
>
> are available in the git repository at:
>
> git://dev.omapzoom.org/pub/scm/manju/kernel-omap3-dev.git omap_sparse_fixesv2
>
> G, Manjunath Kondaiah (7):
> OMAP: mach-omap2: Fix incorrect assignment warnings
> OMAP: mach-omap2: Fix static declaration warnings
> OMAP2plus: Fix static function warnings
> OMAP: mach-omap2: Fix miscellaneous sparse warnings
> OMAP: plat-omap: Fix static function warnings
> OMAP: Convert write/read functions to raw read/write
> OMAP3: Keypad: Fix incorrect type initializer
>
> -Manjunath
>
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2010-10-05 2:14 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-22 8:56 [GIT PULL] omap2 sparse fixes G, Manjunath Kondaiah
2010-09-23 22:58 ` Tony Lindgren
2010-09-24 19:43 ` G, Manjunath Kondaiah
2010-09-25 0:19 ` Tony Lindgren
2010-09-25 6:21 ` G, Manjunath Kondaiah
2010-09-27 13:41 ` G, Manjunath Kondaiah
2010-09-27 14:07 ` Russell King - ARM Linux
2010-09-27 15:00 ` G, Manjunath Kondaiah
2010-09-28 8:12 ` G, Manjunath Kondaiah
2010-09-28 15:21 ` Tony Lindgren
2010-09-28 15:35 ` G, Manjunath Kondaiah
2010-09-28 18:31 ` Tony Lindgren
2010-09-29 19:51 ` G, Manjunath Kondaiah
2010-09-29 21:56 ` Tony Lindgren
2010-09-29 23:46 ` G, Manjunath Kondaiah
2010-10-05 2:14 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-09-22 8:49 G, Manjunath Kondaiah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).