From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/14] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONCACHED L1 entries
Date: Wed, 29 Sep 2010 16:02:42 +0100 [thread overview]
Message-ID: <20100929150242.GA21646@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <tnxzkv0hac6.fsf@e102109-lin.cambridge.arm.com>
On Wed, Sep 29, 2010 at 03:51:21PM +0100, Catalin Marinas wrote:
> Hi Santosh,
>
> Santosh Shilimkar <santosh.shilimkar@ti.com> wrote:
> > This patch populates the L1 entries for MT_MEMORY and MT_MEMORY_NONCACHED
> > types so that at boot-up, we can map memories outside system memory
> > at page level granularity
> >
> > Previously the mapping was limiting to section level, which creates
> > unnecessary addiotional mapping for which physical memory may not
> > present. On the newer ARM with speculation, this is dangerous and can
> > result in untraceable aborts.
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Reviewed-by: Russell King <linux@arm.linux.org.uk>
> > ---
> > arch/arm/mm/mmu.c | 17 +++++++++++++++--
> > 1 files changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> > index 6e1c4f6..3e986a6 100644
> > --- a/arch/arm/mm/mmu.c
> > +++ b/arch/arm/mm/mmu.c
> > @@ -246,6 +246,9 @@ static struct mem_type mem_types[] = {
> > .domain = DOMAIN_USER,
> > },
> > [MT_MEMORY] = {
> > + .prot_pte = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
> > + L_PTE_USER | L_PTE_EXEC,
> > + .prot_l1 = PMD_TYPE_TABLE,
>
> Just a quick question - does this need to have L_PTE_USER? Is it
> read-only or it needs L_PTE_WRITE as well?
Eek. It should not have L_PTE_USER or else it will be accessible to
userspace.
next prev parent reply other threads:[~2010-09-29 15:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 9:47 [PATCH 00/14] omap sram, omap4 control module and es2.0 support Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 01/14] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONCACHED L1 entries Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 02/14] omap: Map only available sram memory Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 03/14] davinci: map sram using MT_MEMORY_NONCACHED instead of MT_DEVICE Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 04/14] omap4: control: Add ctrl_pad_base to omap_globals Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 05/14] omap4: control: Add accessor api's for pad control module Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 06/14] omap4: control: Add the register definition headers Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 07/14] omap4: control: Fix the control module register accesses Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 08/14] omap: sram: fix is_sram_locked check Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 09/14] omap4: sram: Fix start address Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 10/14] omap4: Update id.c and cpu.h for es2.0 Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 11/14] omap4: Fix silicon version detection for early samples Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 12/14] omap4: l2x0: Fix init parameter for es2.0 Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 13/14] omap4: Panda: Add DEBUG_LL support Santosh Shilimkar
2010-09-17 9:47 ` [PATCH 14/14] omap4: Fix bootup crash observed with higher CPU clocks Santosh Shilimkar
2010-09-17 10:14 ` Menon, Nishanth
2010-09-17 10:16 ` Shilimkar, Santosh
2010-09-17 10:27 ` Menon, Nishanth
2010-09-17 10:30 ` Shilimkar, Santosh
2010-09-17 10:41 ` Felipe Balbi
2010-09-17 11:17 ` Shilimkar, Santosh
2010-09-17 11:19 ` Felipe Balbi
2010-09-17 11:24 ` Shilimkar, Santosh
2010-09-17 10:37 ` Felipe Balbi
2010-09-17 10:18 ` [PATCH 11/14] omap4: Fix silicon version detection for early samples Menon, Nishanth
2010-09-17 10:23 ` Shilimkar, Santosh
2010-09-17 10:17 ` [PATCH 05/14] omap4: control: Add accessor api's for pad control module Menon, Nishanth
2010-09-17 10:16 ` [PATCH 03/14] davinci: map sram using MT_MEMORY_NONCACHED instead of MT_DEVICE Russell King - ARM Linux
2010-09-17 10:18 ` Shilimkar, Santosh
2010-09-17 10:15 ` [PATCH 02/14] omap: Map only available sram memory Russell King - ARM Linux
2010-09-17 11:11 ` Shilimkar, Santosh
2010-10-01 20:15 ` Grazvydas Ignotas
2010-10-01 22:53 ` Tony Lindgren
2010-10-02 7:49 ` Shilimkar, Santosh
2010-10-04 9:03 ` Grazvydas Ignotas
2010-10-04 9:38 ` Shilimkar, Santosh
2010-10-04 13:24 ` Shilimkar, Santosh
2010-10-04 23:44 ` Grazvydas Ignotas
2010-10-05 0:34 ` Tony Lindgren
2010-10-05 0:36 ` Tony Lindgren
2010-10-05 5:15 ` Shilimkar, Santosh
2010-09-17 16:41 ` [PATCH 01/14] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONCACHED L1 entries Tony Lindgren
2010-09-29 14:51 ` Catalin Marinas
2010-09-29 15:01 ` Shilimkar, Santosh
2010-09-29 15:02 ` Russell King - ARM Linux [this message]
2010-09-17 15:06 ` [PATCH 00/14] omap sram, omap4 control module and es2.0 support Bryan Wu
2010-09-17 15:10 ` Shilimkar, Santosh
2010-09-17 17:50 ` Paul Walmsley
2010-09-18 7:32 ` Shilimkar, Santosh
2010-09-24 1:13 ` Tony Lindgren
2010-09-24 4:51 ` Shilimkar, Santosh
2010-09-24 6:42 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929150242.GA21646@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).