From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] omap2 sparse fixes
Date: Wed, 29 Sep 2010 14:56:36 -0700 [thread overview]
Message-ID: <20100929215635.GC3117@atomide.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DB7FE8F9@dbde02.ent.ti.com>
* G, Manjunath Kondaiah <manjugk@ti.com> [100929 12:42]:
>
> Tony,
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony at atomide.com]
> > Sent: Wednesday, September 29, 2010 12:02 AM
> > To: G, Manjunath Kondaiah
> > Cc: linux-omap at vger.kernel.org;
> > linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Dmitry
> > Torokhov; linux-mtd at lists.infradead.org; Russell King - ARM Linux
> > Subject: Re: [GIT PULL] omap2 sparse fixes
> >
> > * G, Manjunath Kondaiah <manjugk@ti.com> [100928 08:26]:
> ...
>
> > Yes please take out all patches that are not in arch/arm/*omap*/ path.
> > The others really should go to the driver maintainers.
> >
> > Tony
>
> Here is new branch which has only arch/arm/*omap*/ related patches.
Thanks. Noticed one more thing though:
In your patch "OMAP: mach-omap2: Fix static function warnings" looks like
you're adding omap2_gp_clockevent_set_gptimer twice:
--- a/arch/arm/plat-omap/include/plat/timer-gp.h
+++ b/arch/arm/mach-omap2/timer-gp.h
@@ -11,7 +11,6 @@
#ifndef __ARCH_ARM_PLAT_OMAP_INCLUDE_MACH_TIMER_GP_H
#define __ARCH_ARM_PLAT_OMAP_INCLUDE_MACH_TIMER_GP_H
-int __init omap2_gp_clockevent_set_gptimer(u8 id);
+extern int __init omap2_gp_clockevent_set_gptimer(u8 id);
#endif
-
--- a/arch/arm/plat-omap/include/plat/dmtimer.h
+++ b/arch/arm/plat-omap/include/plat/dmtimer.h
@@ -81,6 +81,6 @@ unsigned int omap_dm_timer_read_counter(struct omap_dm_timer *timer);
void omap_dm_timer_write_counter(struct omap_dm_timer *timer, unsigned int value);
int omap_dm_timers_active(void);
-
+int omap2_gp_clockevent_set_gptimer(u8 id);
#endif /* __ASM_ARCH_DMTIMER_H */
Please also be careful that your branch contains the same patches
as you've posted for review. Nobody wants to pull different stuff
than what was posted! Also looks like Paul had one comment related
to the same patch.
Regards,
Tony
next prev parent reply other threads:[~2010-09-29 21:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 8:56 [GIT PULL] omap2 sparse fixes G, Manjunath Kondaiah
2010-09-23 22:58 ` Tony Lindgren
2010-09-24 19:43 ` G, Manjunath Kondaiah
2010-09-25 0:19 ` Tony Lindgren
2010-09-25 6:21 ` G, Manjunath Kondaiah
2010-09-27 13:41 ` G, Manjunath Kondaiah
2010-09-27 14:07 ` Russell King - ARM Linux
2010-09-27 15:00 ` G, Manjunath Kondaiah
2010-09-28 8:12 ` G, Manjunath Kondaiah
2010-09-28 15:21 ` Tony Lindgren
2010-09-28 15:35 ` G, Manjunath Kondaiah
2010-09-28 18:31 ` Tony Lindgren
2010-09-29 19:51 ` G, Manjunath Kondaiah
2010-09-29 21:56 ` Tony Lindgren [this message]
2010-09-29 23:46 ` G, Manjunath Kondaiah
2010-10-05 2:14 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-09-22 8:49 G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929215635.GC3117@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).