* [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
@ 2010-09-30 4:48 Kyungmin Park
2010-09-30 8:45 ` Lothar Waßmann
2010-10-07 1:29 ` Kukjin Kim
0 siblings, 2 replies; 6+ messages in thread
From: Kyungmin Park @ 2010-09-30 4:48 UTC (permalink / raw)
To: linux-arm-kernel
From: Kyungmin Park <kyungmin.park@samsung.com>
Use the correct I2C2 interrupt.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/dev-i2c2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-samsung/dev-i2c2.c b/arch/arm/plat-samsung/dev-i2c2.c
index 07036de..ff4ba69 100644
--- a/arch/arm/plat-samsung/dev-i2c2.c
+++ b/arch/arm/plat-samsung/dev-i2c2.c
@@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
.flags = IORESOURCE_MEM,
},
[1] = {
- .start = IRQ_CAN0,
- .end = IRQ_CAN0,
+ .start = IRQ_IIC2,
+ .end = IRQ_IIC2,
.flags = IORESOURCE_IRQ,
},
};
--
1.5.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
2010-09-30 4:48 [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt Kyungmin Park
@ 2010-09-30 8:45 ` Lothar Waßmann
2010-09-30 9:16 ` Kyungmin Park
2010-10-07 1:29 ` Kukjin Kim
1 sibling, 1 reply; 6+ messages in thread
From: Lothar Waßmann @ 2010-09-30 8:45 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park writes:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Use the correct I2C2 interrupt.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/dev-i2c2.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/dev-i2c2.c b/arch/arm/plat-samsung/dev-i2c2.c
> index 07036de..ff4ba69 100644
> --- a/arch/arm/plat-samsung/dev-i2c2.c
> +++ b/arch/arm/plat-samsung/dev-i2c2.c
> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
> .flags = IORESOURCE_MEM,
> },
> [1] = {
> - .start = IRQ_CAN0,
> - .end = IRQ_CAN0,
> + .start = IRQ_IIC2,
> + .end = IRQ_IIC2,
>
Is there any reason for using 'IIC' here to refer to 'I2C'?
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
2010-09-30 8:45 ` Lothar Waßmann
@ 2010-09-30 9:16 ` Kyungmin Park
2010-09-30 9:45 ` Jongsun Han
0 siblings, 1 reply; 6+ messages in thread
From: Kyungmin Park @ 2010-09-30 9:16 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 30, 2010 at 5:45 PM, Lothar Wa?mann <LW@karo-electronics.de> wrote:
> Kyungmin Park writes:
>> From: Kyungmin Park <kyungmin.park@samsung.com>
>>
>> Use the correct I2C2 interrupt.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> ?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
>> ?1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/dev-i2c2.c b/arch/arm/plat-samsung/dev-i2c2.c
>> index 07036de..ff4ba69 100644
>> --- a/arch/arm/plat-samsung/dev-i2c2.c
>> +++ b/arch/arm/plat-samsung/dev-i2c2.c
>> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
>> ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
>> ? ? ? },
>> ? ? ? [1] = {
>> - ? ? ? ? ? ? .start = IRQ_CAN0,
>> - ? ? ? ? ? ? .end ? = IRQ_CAN0,
>> + ? ? ? ? ? ? .start = IRQ_IIC2,
>> + ? ? ? ? ? ? .end ? = IRQ_IIC2,
>>
> Is there any reason for using 'IIC' here to refer to 'I2C'?
Historical reason previous s3c24xx series use this name. I don't want
to break the s3c24xx series codes.
Instead I use the I2C after S5P series. I2C3, I2C4 and so on.
If all person who works on s3c24xx and s5p series agree that use the
I2C. It can be used.
Thank you,
Kyungmin Park
>
>
> Lothar Wa?mann
> --
> ___________________________________________________________
>
> Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
> Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
> Gesch?ftsf?hrer: Matthias Kaussen
> Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
>
> www.karo-electronics.de | info at karo-electronics.de
> ___________________________________________________________
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
2010-09-30 9:16 ` Kyungmin Park
@ 2010-09-30 9:45 ` Jongsun Han
2010-09-30 9:50 ` Kyungmin Park
0 siblings, 1 reply; 6+ messages in thread
From: Jongsun Han @ 2010-09-30 9:45 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 30, 2010 at 5:45 PM, Lothar Wa?mann <LW@karo-electronics.de>
> wrote:
> > Kyungmin Park writes:
> >> From: Kyungmin Park <kyungmin.park@samsung.com>
> >>
> >> Use the correct I2C2 interrupt.
> >>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> ?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
> >> ?1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-samsung/dev-i2c2.c b/arch/arm/plat-
> samsung/dev-i2c2.c
> >> index 07036de..ff4ba69 100644
> >> --- a/arch/arm/plat-samsung/dev-i2c2.c
> >> +++ b/arch/arm/plat-samsung/dev-i2c2.c
> >> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
> >> ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
> >> ? ? ? },
> >> ? ? ? [1] = {
> >> - ? ? ? ? ? ? .start = IRQ_CAN0,
> >> - ? ? ? ? ? ? .end ? = IRQ_CAN0,
> >> + ? ? ? ? ? ? .start = IRQ_IIC2,
> >> + ? ? ? ? ? ? .end ? = IRQ_IIC2,
> >>
> > Is there any reason for using 'IIC' here to refer to 'I2C'?
>
> Historical reason previous s3c24xx series use this name. I don't want
> to break the s3c24xx series codes.
> Instead I use the I2C after S5P series. I2C3, I2C4 and so on.
>
> If all person who works on s3c24xx and s5p series agree that use the
> I2C. It can be used.
>
> Thank you,
> Kyungmin Park
Hi, Kyungmin
IRQ_CAN0 is also used in arch/arm/mach-s5pc100/include/mach/irqs.h
Best Regards
Jongsun Han
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
2010-09-30 9:45 ` Jongsun Han
@ 2010-09-30 9:50 ` Kyungmin Park
0 siblings, 0 replies; 6+ messages in thread
From: Kyungmin Park @ 2010-09-30 9:50 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 30, 2010 at 6:45 PM, Jongsun Han <jongsun.han@samsung.com> wrote:
> On Thu, Sep 30, 2010 at 5:45 PM, Lothar Wa?mann <LW@karo-electronics.de>
>> wrote:
>> > Kyungmin Park writes:
>> >> From: Kyungmin Park <kyungmin.park@samsung.com>
>> >>
>> >> Use the correct I2C2 interrupt.
>> >>
>> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> >> ---
>> >> ?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
>> >> ?1 files changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> diff --git a/arch/arm/plat-samsung/dev-i2c2.c b/arch/arm/plat-
>> samsung/dev-i2c2.c
>> >> index 07036de..ff4ba69 100644
>> >> --- a/arch/arm/plat-samsung/dev-i2c2.c
>> >> +++ b/arch/arm/plat-samsung/dev-i2c2.c
>> >> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
>> >> ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
>> >> ? ? ? },
>> >> ? ? ? [1] = {
>> >> - ? ? ? ? ? ? .start = IRQ_CAN0,
>> >> - ? ? ? ? ? ? .end ? = IRQ_CAN0,
>> >> + ? ? ? ? ? ? .start = IRQ_IIC2,
>> >> + ? ? ? ? ? ? .end ? = IRQ_IIC2,
>> >>
>> > Is there any reason for using 'IIC' here to refer to 'I2C'?
>>
>> Historical reason previous s3c24xx series use this name. I don't want
>> to break the s3c24xx series codes.
>> Instead I use the I2C after S5P series. I2C3, I2C4 and so on.
>>
>> If all person who works on s3c24xx and s5p series agree that use the
>> I2C. It can be used.
>>
>> Thank you,
>> Kyungmin Park
>
> Hi, Kyungmin
> IRQ_CAN0 is also used in arch/arm/mach-s5pc100/include/mach/irqs.h
Yes it's defined and will be used. but not I2C2
I already check it. at least my manual it's s5pc100 don't have I2C2.
Thank you,
Kyungmin Park
>
> Best Regards
> Jongsun Han
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
2010-09-30 4:48 [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt Kyungmin Park
2010-09-30 8:45 ` Lothar Waßmann
@ 2010-10-07 1:29 ` Kukjin Kim
1 sibling, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2010-10-07 1:29 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park wrote:
>
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Use the correct I2C2 interrupt.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/dev-i2c2.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/dev-i2c2.c
b/arch/arm/plat-samsung/dev-i2c2.c
> index 07036de..ff4ba69 100644
> --- a/arch/arm/plat-samsung/dev-i2c2.c
> +++ b/arch/arm/plat-samsung/dev-i2c2.c
> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
> .flags = IORESOURCE_MEM,
> },
> [1] = {
> - .start = IRQ_CAN0,
> - .end = IRQ_CAN0,
> + .start = IRQ_IIC2,
> + .end = IRQ_IIC2,
> .flags = IORESOURCE_IRQ,
> },
> };
> --
Hi,
Looks ok...
In my opinion, could you please merge your 2nd and this patch to one,
changing I2C2 interrupt name?
And need to add s5pc100's I2C2 interrupt name changing in there.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-07 1:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 4:48 [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt Kyungmin Park
2010-09-30 8:45 ` Lothar Waßmann
2010-09-30 9:16 ` Kyungmin Park
2010-09-30 9:45 ` Jongsun Han
2010-09-30 9:50 ` Kyungmin Park
2010-10-07 1:29 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).