From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fixing ethernet driver compilation error for i.MX31 ADS board
Date: Thu, 30 Sep 2010 15:29:14 +0200 [thread overview]
Message-ID: <20100930132914.GP29811@pengutronix.de> (raw)
In-Reply-To: <1285851444-18123-1-git-send-email-ian@opensource.wolfsonmicro.com>
Hi Ian,
On Thu, Sep 30, 2010 at 01:57:24PM +0100, Ian Lartey wrote:
> This is only a partial revert of "ARM: mx3/mx31ads: fold board header in its only user"
> [commit ccfa7c269843001077df02d98918c6c9bde91395)]
>
> As some of the the board defines are also used in the cs89x0 ethernet driver by the i.MX31 ADS.
Can you please line break the commit log. AFAIK up to 76 chars are
usual for the kernel.
Hmmm, I took a look into drivers/net/cs89x0.c. This driver definitly
needs a cleanup, e.g. should start to provide a platform driver.
Maybe it can even be merged with drivers/net/mac89x0.c?
I think the best for know would be the following:
- reintroduce mach/board-mx31ads.h but only defining the symbols used
by cs89x0 together with a comment saying that the constants are
needed for the cs89x0 ethernet driver.
- In a second patch add CS89x0 to mx31_defconfig
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-09-30 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 12:57 [PATCH] Fixing ethernet driver compilation error for i.MX31 ADS board Ian Lartey
2010-09-30 13:29 ` Uwe Kleine-König [this message]
2010-09-30 14:49 ` Ian Lartey
-- strict thread matches above, loose matches on Subject: below --
2010-10-14 11:07 Ian Lartey
2010-09-23 15:32 Ian Lartey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930132914.GP29811@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).