linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init
Date: Thu, 30 Sep 2010 09:51:04 -0700	[thread overview]
Message-ID: <20100930165104.GJ3117@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1009301040390.5439@utopia.booyaka.com>

* Paul Walmsley <paul@pwsan.com> [100930 09:34]:
> Hello Charu,
> 
> On Thu, 30 Sep 2010, Varadarajan, Charulatha wrote:
> 
> > > > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> > > > index 8e2f0aa..9f44fc6 100644
> > > > --- a/arch/arm/mach-omap2/devices.c
> > > > +++ b/arch/arm/mach-omap2/devices.c
> > > > +
> > > > +static void __init omap_disable_wdt(void)
> > > > +{
> > > > +	if (cpu_class_is_omap2())
> > > 
> > > This code is already in mach-omap2/devices.c, so that test should be 
> > > useless.
> > 
> > I do not see a cpu_class_is_omap2() check in omap2_init_devices(). Please
> > point out where this check is done while/before calling omap_disable_wdt()?
> 
> It's implicit, due to the directory arch/arm/mach-omap2/ -- code in that 
> directory is only built for OMAP2+ systems -- and right now there are no 
> plans for OMAP1+ multi-arch booting.  So it's safe to assume that any code 
> in arch/arm/mach-omap2 will only run on OMAP2+ boards.

That might change pretty fast though. There are already experimental patches
to build in multiple ARM archs into a single kernel binary.

So we should already have these checks in place to avoid the initcalls running
on other ARM archs.

Regards,

Tony

  reply	other threads:[~2010-09-30 16:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30  8:11 [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Varadarajan, Charulatha
2010-09-30  9:07 ` Cousson, Benoit
2010-09-30 13:55   ` Kevin Hilman
2010-09-30 14:12     ` Cousson, Benoit
2010-09-30 14:51       ` Kevin Hilman
2010-09-30 15:07       ` Tony Lindgren
2010-09-30 15:55         ` Varadarajan, Charulatha
2010-09-30 16:32           ` Varadarajan, Charulatha
2010-09-30 16:43             ` Paul Walmsley
2010-09-30 16:51               ` Tony Lindgren [this message]
2010-09-30 16:46             ` Cousson, Benoit
2010-09-30 16:57           ` Cousson, Benoit
2010-09-30 17:06             ` Varadarajan, Charulatha
2010-09-30 17:05           ` Shilimkar, Santosh
2010-09-30 17:11             ` Kevin Hilman
2010-10-01  7:26               ` Shilimkar, Santosh
2010-10-01 13:33                 ` Varadarajan, Charulatha
2010-10-01 14:43                   ` Kevin Hilman
2010-10-01 17:12                     ` Cousson, Benoit
2010-09-30 13:57 ` Kevin Hilman
2010-09-30 16:36   ` Varadarajan, Charulatha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930165104.GJ3117@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).