From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Fixing ethernet driver compilation error for i.MX31 ADS board
Date: Thu, 30 Sep 2010 20:14:33 +0200 [thread overview]
Message-ID: <20100930181433.GS29811@pengutronix.de> (raw)
In-Reply-To: <1285861655-6513-1-git-send-email-ian@opensource.wolfsonmicro.com>
Hello,
On Thu, Sep 30, 2010 at 04:47:34PM +0100, Ian Lartey wrote:
> This is only a partial revert of "ARM: mx3/mx31ads: fold board header in
> its only user" [commit ccfa7c269843001077df02d98918c6c9bde91395)]
>
> As some of the the board defines are also used in the cs89x0 ethernet
> driver by the i.MX31 ADS.
>
> Signed-off-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
It seems you got me wrong. I wanted you to just define the constants in
arch/arm/plat-mxc/include/mach/board-mx31ads.h that are needed by the
cs89x0 driver. That is PBC_BASE_ADDRESS, PBC_CS8900A_IOBASE and
EXPIO_INT_ENET_INT. And I wanted a comment like:
/*
* These symbols are used by drivers/net/cs89x0.c.
* This is ugly as hell, but we have to provide them until
* someone fixed the driver.
*/
And you definitly shouldn't reintroduce these doxygen comments.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-09-30 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 15:47 [PATCH 1/2] Fixing ethernet driver compilation error for i.MX31 ADS board Ian Lartey
2010-09-30 15:47 ` [PATCH 2/2] Adding cs89x0, standard ethernet driver for iMX31 platform Ian Lartey
2010-09-30 18:23 ` Uwe Kleine-König
2010-10-01 10:46 ` Ian Lartey
2010-10-01 12:49 ` Uwe Kleine-König
2010-10-13 15:25 ` Ian Lartey
2010-10-13 16:11 ` Uwe Kleine-König
2010-10-13 16:32 ` Ian Lartey
2010-09-30 18:14 ` Uwe Kleine-König [this message]
2010-10-01 10:33 ` [PATCH 1/2] Fixing ethernet driver compilation error for i.MX31 ADS board Ian Lartey
2010-10-01 12:42 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930181433.GS29811@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).