From mboxrd@z Thu Jan  1 00:00:00 1970
From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=)
Date: Thu, 30 Sep 2010 20:14:33 +0200
Subject: [PATCH 1/2] Fixing ethernet driver compilation error for
	i.MX31 ADS board
In-Reply-To: <1285861655-6513-1-git-send-email-ian@opensource.wolfsonmicro.com>
References: <1285861655-6513-1-git-send-email-ian@opensource.wolfsonmicro.com>
Message-ID: <20100930181433.GS29811@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hello,

On Thu, Sep 30, 2010 at 04:47:34PM +0100, Ian Lartey wrote:
> This is only a partial revert of "ARM: mx3/mx31ads: fold board header in
> its only user" [commit ccfa7c269843001077df02d98918c6c9bde91395)]
> 
> As some of the the board defines are also used in the cs89x0 ethernet
> driver by the i.MX31 ADS.
> 
> Signed-off-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
It seems you got me wrong.  I wanted you to just define the constants in
arch/arm/plat-mxc/include/mach/board-mx31ads.h that are needed by the
cs89x0 driver.  That is PBC_BASE_ADDRESS, PBC_CS8900A_IOBASE and
EXPIO_INT_ENET_INT.  And I wanted a comment like:

	/* 
	 * These symbols are used by drivers/net/cs89x0.c.
	 * This is ugly as hell, but we have to provide them until
	 * someone fixed the driver.
	 */

And you definitly shouldn't reintroduce these doxygen comments.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |