[PATCH 2/4] arm: dis-allow hotplug on MSM

[pavel@ucw.cz (Pavel Machek)]

Hi!

> > > > > This is goodbye to s2ram support, AFAICT.
> > > > 
> > > > This depends on SMP tho. It's like saying,
> > > > 
> > > > depends on 
> > > 
> > > That's weird, there was more to this email..
> > > 
> > > It's like saying,
> > > 
> > > depends on SMP && HOTPLUG && EXPERIMENTAL && !ARCH_MSM
> > > 
> > > But ARCH_MSM has no SMP, so the whole thing should short circuit right
> > > at the start. It's only when you bring in SMP that it get interesting.
> > 
> > If arch_msm has no SMP, then why is change needed?
> 
> I'm getting it ready for SMP .. It's not there yet but will be.

Ok. It makes sense, then.

> > (I was trying to warn you that you'll need HOTPLUG support to get SMP
> > suspend support.)
> 
> Yeah, I'm aware of it.. We haven't implemented hotplug yet, so we don't
> have suspend support yet for SMP.

Still, it might be better to just provide stubs that return -ENOTSUPP
or something, and leave it enabled in config. Same results, you'll
need to provide full functions in future, anyway, and no churn in
shared config files.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html