public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: l2x0: Optimise the range based operations
Date: Mon, 4 Oct 2010 22:22:50 +0100	[thread overview]
Message-ID: <20101004212250.GD25241@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1283846243-11600-7-git-send-email-santosh.shilimkar@ti.com>

On Tue, Sep 07, 2010 at 01:27:23PM +0530, Santosh Shilimkar wrote:
> For the big buffers which are in excess of cache size, the maintaince
> operations by PA are very slow. For such buffers the maintainace
> operations can be speeded up by using the WAY based method.

This causes my Versatile Express to corrupt MMC transfers.  Reverting
both this and the 'Determine cache size' patches makes it work again.

(Note that just reverting this one doesn't result in a working situation.)

Good boot:

L310 cache controller enabled                                                   
l2x0: 8 ways, CACHE_ID 0x410000c3, AUX_CTRL 0x02460000                          
...
mmci-pl18x mb:mmci: mmc0: MMCI rev 0 cfg 00 at 0x0000000010005000 irq 41,42     
aaci-pl041 mb:aaci: ARM AC'97 Interface at 0x0000000010004000, irq 43, fifo 512 
ALSA device list:                                                               
  #0: ARM AC'97 Interface at 0x0000000010004000, irq 43                         
TCP cubic registered                                                            
mmc0: host does not support reading read-only switch. assuming write-enable.    
mmc0: new SD card at address e624                                               
mmcblk0: mmc0:e624 SD02G 1.89 GiB                                               
NET: Registered protocol family 17                                              
VFP support v0.3: implementor 41 architecture 3 part 30 variant 9 rev 0         
 mmcblk0: p1                                                                    
Initalizing network drop monitor service                                        
Waiting 5sec before mounting root device...                                     
port 1 high speed                                                               

Bad boot (with just 'Determine cache size' patch applied):

L310 cache controller enabled                                                   
l2x0: 8 ways, CACHE_ID 0x410000c3, AUX_CTRL 0x02460000, Cache size: 512 KB      
...
mmci-pl18x mb:mmci: mmc0: MMCI rev 0 cfg 00 at 0x0000000010005000 irq 41,42     
aaci-pl041 mb:aaci: ARM AC'97 Interface at 0x0000000010004000, irq 43, fifo 512 
ALSA device list:                                                               
  #0: ARM AC'97 Interface at 0x0000000010004000, irq 43                         
mmc0: host does not support reading read-only switch. assuming write-enable.    
mmc0: new SD card at address e624                                               
mmcblk0: mmc0:e624 SD02G 1.89 GiB                                               
TCP cubic registered                                                            
NET: Registered protocol family 17                                              
mmcblk0: retrying using single block read                                       
VFP support v0.3: implementor 41 architecture 3 part 30 variant 9 rev 0         
mmcblk0: error -5 transferring data, sector 0, nr 8, card status 0x900          
Initalizing network drop monitor service                                        
<random garbage>
mmcblk0: error -5 transferring data, sector 1, nr 7, card status 0x900
end_request: I/O error, dev mmcblk0, sector 1                                   
Buffer I/O error on device mmcblk0, logical block 0                             
port 1 high speed                                                               

-5 is -EIO, which is a FIFO overrun error, so somehow these changes are
causing the CPU or bus accesses to be slower.

  reply	other threads:[~2010-10-04 21:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07  7:57 [PATCH 0/6] ARM: l2x0: kexex, cleanup and optimisation Santosh Shilimkar
     [not found] ` <1283846243-11600-2-git-send-email-santosh.shilimkar@ti.com>
     [not found]   ` <1283846243-11600-3-git-send-email-santosh.shilimkar@ti.com>
2010-09-07  7:57     ` [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable Santosh Shilimkar
2010-09-07  7:57       ` [PATCH 4/6] ARM: l2x0: Fix coding-style in the cache-l2x0.h Santosh Shilimkar
2010-09-07  7:57         ` [PATCH 5/6] ARM: l2x0: Determine the cache size Santosh Shilimkar
2010-09-07  7:57           ` [PATCH 6/6] ARM: l2x0: Optimise the range based operations Santosh Shilimkar
2010-10-04 21:22             ` Russell King - ARM Linux [this message]
2010-10-05  4:54               ` Shilimkar, Santosh
2010-10-06  5:12                 ` Shilimkar, Santosh
2012-06-18 17:41             ` Antti P Miettinen
2010-09-16  0:21       ` [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable Tony Lindgren
2010-09-16  5:56         ` Shilimkar, Santosh
2010-09-07 18:18 ` [PATCH 0/6] ARM: l2x0: kexex, cleanup and optimisation Linus Walleij
2010-09-08  7:34   ` Shilimkar, Santosh
2010-09-08 12:35     ` Linus Walleij
2010-09-08 15:01     ` Catalin Marinas
2010-09-08 15:09       ` Shilimkar, Santosh
2010-09-08 15:25         ` Catalin Marinas
2010-09-08 15:29           ` Shilimkar, Santosh
2010-09-08 15:46             ` Shilimkar, Santosh
2010-09-08 15:49               ` Catalin Marinas
2010-09-09  5:18                 ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101004212250.GD25241@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox