From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ASoC: EDB93xx machine sound driver
Date: Wed, 6 Oct 2010 20:12:44 -0700 [thread overview]
Message-ID: <20101007031243.GA32312@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CAD1952.9030702@bluewatersys.com>
On Thu, Oct 07, 2010 at 01:50:26PM +1300, Ryan Mallon wrote:
> + ret = gpio_request(EP93XX_GPIO_LINE_EGPIO6, "CS4271 SFRM1 Disable");
> + if (ret)
> + return ret;
> + ret = gpio_direction_output(EP93XX_GPIO_LINE_EGPIO6, 0);
> + if (ret)
> + goto free_EGPIO6;
> +
> + ret = gpio_request(EP93XX_GPIO_LINE_EGPIO1, "CS4271 Reset");
> + if (ret)
> + goto free_EGPIO6;
> + ret = gpio_direction_output(EP93XX_GPIO_LINE_EGPIO1, 1);
> + if (ret)
> + goto free_EGPIO1;
It'd seem to make sense for these to be handled by the CODEC driver,
using platform data to supply the GPIOs so that their management can be
integrated with the CODEC flow?
Otherwise this looks good.
next prev parent reply other threads:[~2010-10-07 3:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 0:39 [PATCH 1/2] ASoC: Add CS4271 codec support Ryan Mallon
2010-10-07 0:49 ` Mark Brown
2010-10-07 0:53 ` Ryan Mallon
2010-10-07 0:50 ` Mark Brown
2010-10-07 0:50 ` [PATCH 2/2] ASoC: EDB93xx machine sound driver Ryan Mallon
2010-10-07 3:12 ` Mark Brown [this message]
2010-10-07 21:46 ` [PATCH 1/2] ASoC: Add CS4271 codec support Timur Tabi
2010-10-07 21:59 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007031243.GA32312@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).