linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/3] OMAP2/3: DMA: FIFO drain errata fixes
Date: Fri, 8 Oct 2010 15:17:46 -0700	[thread overview]
Message-ID: <20101008221746.GS7558@atomide.com> (raw)
In-Reply-To: <20101005181525.GL3117@atomide.com>

* Tony Lindgren <tony@atomide.com> [101005 11:07]:
> * Peter Ujfalusi <peter.ujfalusi@nokia.com> [101004 23:37]:
> > Hello,
> > 
> > This v5 series is based on the v3.
> > The first two patch is the actual fix for the original problems without any
> > major change in the code (only handling the corresponding erratas in the legacy
> > way).
> > The third patch in the series is optional, and it is implementing (in one patch)
> > the errata handling via flags. This patch converts all errata cases to use the
> > introduced dma_errata variable via macros.
> > 
> > Tony: the first two patch need to go for 2.6.36, and if it is possible it shall
> > be backported to .33, .34, and .35 as well.
> 
> OK, I'll the first two into omap-fixes.

Guys, as we're so late into getting 2.6.36 tagged, I'm thinking about just
queueing these for 2.6.37 for the following reasons:

- The 24xx patch is a fix for commit c12abc0 that's was merged over a
  year ago. We've lived with it for over a year now. What difference does
  extra few more months make if we have it in 2.6.37 instead of 2.6.36?

- The second 34xx fix seems to happen only when disabling DMA on the fly.
  Again, we've had support for 34xx in the mainline kernel for a few
  years, and we're not seeing unrecoverable issues with MMC or USB or
  any other code calling omap_dma_stop().

Sure these fix major issues with the DMA, but are these really critical
for 2.6.36?

So if you really want me to argue for merging these into 2.6.36, please let
me know some oops causing cases or data corruption that happens without
these patches.

Cheers,

Tony

  reply	other threads:[~2010-10-08 22:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05  6:45 [PATCH v5 0/3] OMAP2/3: DMA: FIFO drain errata fixes Peter Ujfalusi
2010-10-05  6:45 ` [PATCH v5 1/3] omap: dma: Fix buffering disable bit setting for omap24xx Peter Ujfalusi
2010-10-05  9:41   ` G, Manjunath Kondaiah
2010-10-05  6:45 ` [PATCH v5 2/3] OMAP3: DMA: Errata i541: sDMA FIFO draining does not finish Peter Ujfalusi
2010-11-10 13:46   ` Adrian Hunter
2010-11-10 13:52   ` Adrian Hunter
2010-11-10 23:30     ` Paul Walmsley
2010-11-11  7:17       ` Adrian Hunter
2010-10-05  6:45 ` [PATCH v5 3/3] OMAP: DMA: Use flags for errata handling Peter Ujfalusi
2010-10-05  9:55 ` [PATCH v5 0/3] OMAP2/3: DMA: FIFO drain errata fixes G, Manjunath Kondaiah
2010-10-05 18:15 ` Tony Lindgren
2010-10-08 22:17   ` Tony Lindgren [this message]
2010-10-21 10:05     ` Peter Ujfalusi
2010-11-05 21:29       ` Tony Lindgren
2010-12-07 19:45         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101008221746.GS7558@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).