From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sat, 9 Oct 2010 00:22:37 +0100 Subject: [PATCH v4] ARM: Fix sparse warnings due to variables conflicts. In-Reply-To: <4CAF014D.7000909@ti.com> References: <1286517186-29934-1-git-send-email-sourav.poddar@ti.com> <4CAF014D.7000909@ti.com> Message-ID: <20101008232237.GC10975@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 08, 2010 at 06:32:29AM -0500, Nishanth Menon wrote: > Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following: >> Fix the sparse warnings generated due to conflicts in variables used in readl/writel. >> >> >> drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows an earlier one >> drivers/net/smc91x.c:312:8: originally declared here >> >> With this change, about 200 sparse warnings are fixed. > The commit message could be a little more detailed. > see http://marc.info/?l=linux-omap&m=128648102511076&w=2 > > also should $subject say ARM: io: fix namespace conflict > to better reflect the fix? sparse warnings are just an indication IMHO afaics, this patch will cause checkpatch to issue warnings due to lines over 80 characters. I can't check that because I don't have the original patch via the linux-arm-kernel mailing list.