From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ASoC: add ep93xx AC97 audio driver
Date: Mon, 11 Oct 2010 11:43:36 +0100 [thread overview]
Message-ID: <20101011104335.GC9231@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20101011100742.GE27142@gw.healthdatacare.com>
On Mon, Oct 11, 2010 at 01:07:42PM +0300, Mika Westerberg wrote:
> On Mon, Oct 11, 2010 at 10:47:18AM +0100, Mark Brown wrote:
> > On Sun, Oct 10, 2010 at 01:54:10PM +0300, Mika Westerberg wrote:
> > > + mutex_lock(&info->lock);
> > > + INIT_COMPLETION(info->done);
> > Do you really need to do this on every single register I/O?
> Sorry, didn't quite understand you. Do you mean that should I take
> the mutex and init the completion or wait for an interrupt?
You're doing INIT_COMPLETION every single time you use it - is that
really required?
> Yeah, sorry about that. I had the impression that using the latest
> mainline would be right thing to do :( I will base the next version
> against that tree pointed by Jassi.
Latest mainline means you're missing any changes that are ready for the
next merge window, once code has gone to Linus it's bugfix only outside
of the merge window so actual development happens in -next.
next prev parent reply other threads:[~2010-10-11 10:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 10:54 [PATCH 0/4] ASoC AC97 audio support for ep93xx Mika Westerberg
2010-10-10 10:54 ` [PATCH 1/4] ARM: ep93xx: DMA: fix channel_disable Mika Westerberg
2010-10-10 19:34 ` Ryan Mallon
2010-10-10 10:54 ` [PATCH 2/4] ASoC: add ep93xx AC97 audio driver Mika Westerberg
2010-10-11 9:47 ` Mark Brown
2010-10-11 10:07 ` Mika Westerberg
2010-10-11 10:43 ` Mark Brown [this message]
2010-10-11 12:17 ` Mika Westerberg
2010-10-10 10:54 ` [PATCH 3/4] ARM: ep93xx: add AC97 platform support Mika Westerberg
2010-10-10 19:39 ` Ryan Mallon
2010-10-11 7:47 ` Mika Westerberg
2010-10-10 10:54 ` [PATCH 4/4] ASoC: ep93xx: add Simplemachines Sim.One AC97 audio support Mika Westerberg
2010-10-11 0:22 ` [alsa-devel] " Jassi Brar
2010-10-11 7:38 ` Mika Westerberg
2010-10-11 7:46 ` Jassi Brar
2010-10-10 17:02 ` [PATCH 0/4] ASoC AC97 audio support for ep93xx Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011104335.GC9231@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).