Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: rabin.vincent@stericsson.com (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] amba: add name based matching
Date: Tue, 12 Oct 2010 14:16:23 +0530	[thread overview]
Message-ID: <20101012084623.GA20407@bnru01.bnr.st.com> (raw)
In-Reply-To: <20101012082449.GA14109@n2100.arm.linux.org.uk>

On Tue, Oct 12, 2010 at 10:24:49 +0200, Russell King - ARM Linux wrote:
> On Sat, Oct 09, 2010 at 08:31:20PM +0530, Rabin Vincent wrote:
> > Some peripherals on the DBx500 family of SoCs have changes in their
> > functionality and registers between different variants in the family but
> > retain the same AMBA peripheral ID, making it impossible to distinguish
> > between them in AMBA drivers with the current AMBA id_table.
> > 
> > To support this, add a name parameter to the amba_device and the amba_id
> > and allow name based matching as a second level filter after the
> > periphid match.
> 
> I am really not very happy with this without an explaination of the kinds
> of differences there are.

For example:

 - The PL180 derivate has the ID 0x00480180 on both DB8500v1 and
   DB8500v2, but the DB8500v2 version moves the BLOCKSIZE in the
   DATACTRL register from a power of two at bits 7:4 to a normal value
   at bits 30:16.  The bits 7:4 become reserved in DB8500v2.

 - The PL022 derivate has the ID 0x00080023 on DB8500 and DB5500, but
   the DB5500 version has the "Loopback enable" bit, while the DB8500
   version doesn't.

Rabin

      reply	other threads:[~2010-10-12  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-09 15:01 [PATCH] amba: add name based matching Rabin Vincent
2010-10-12  8:24 ` Russell King - ARM Linux
2010-10-12  8:46   ` Rabin Vincent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012084623.GA20407@bnru01.bnr.st.com \
    --to=rabin.vincent@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox