From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped
Date: Wed, 13 Oct 2010 01:49:53 -0700 [thread overview]
Message-ID: <20101013084952.GB29239@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <003101cb6ab3$753ca4f0$5fb5eed0$%kim@samsung.com>
On Wed, Oct 13, 2010 at 05:48:48PM +0900, Kukjin Kim wrote:
> You mean following?
> arch/arm/mach-s3c64xx/setup-keypad.c:16:6: warning: symbol
> 'samsung_keypad_cfg_gpio' was not declared. Should it be static?
Yup, that's the one.
> I didn't check sparse :-(
> Ok...Ben seems to be busy now...so will apply in my tree.
> And I will also fix it our Samsung stuff.
Thanks!
prev parent reply other threads:[~2010-10-13 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 17:23 [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped Mark Brown
2010-10-12 17:23 ` [PATCH 2/2] S3C64XX: Ensure s3c64xx_ide_setup_gpio() " Mark Brown
2010-10-13 8:14 ` [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() " Kukjin Kim
2010-10-13 8:19 ` Mark Brown
2010-10-13 8:48 ` Kukjin Kim
2010-10-13 8:49 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013084952.GB29239@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).