* [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped @ 2010-10-12 17:23 Mark Brown 2010-10-12 17:23 ` [PATCH 2/2] S3C64XX: Ensure s3c64xx_ide_setup_gpio() " Mark Brown 2010-10-13 8:14 ` [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() " Kukjin Kim 0 siblings, 2 replies; 6+ messages in thread From: Mark Brown @ 2010-10-12 17:23 UTC (permalink / raw) To: linux-arm-kernel Since it's exported we should make sure we're using the prototype others see. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- arch/arm/mach-s3c64xx/setup-keypad.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/setup-keypad.c b/arch/arm/mach-s3c64xx/setup-keypad.c index d1fd722..f8ed0d2 100644 --- a/arch/arm/mach-s3c64xx/setup-keypad.c +++ b/arch/arm/mach-s3c64xx/setup-keypad.c @@ -12,6 +12,7 @@ #include <linux/gpio.h> #include <plat/gpio-cfg.h> +#include <plat/keypad.h> void samsung_keypad_cfg_gpio(unsigned int rows, unsigned int cols) { -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] S3C64XX: Ensure s3c64xx_ide_setup_gpio() is prototyped 2010-10-12 17:23 [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped Mark Brown @ 2010-10-12 17:23 ` Mark Brown 2010-10-13 8:14 ` [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() " Kukjin Kim 1 sibling, 0 replies; 6+ messages in thread From: Mark Brown @ 2010-10-12 17:23 UTC (permalink / raw) To: linux-arm-kernel Since it's exported we should make sure we're using the prototype others see. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- arch/arm/mach-s3c64xx/setup-ide.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s3c64xx/setup-ide.c b/arch/arm/mach-s3c64xx/setup-ide.c index de645e9..41b4256 100644 --- a/arch/arm/mach-s3c64xx/setup-ide.c +++ b/arch/arm/mach-s3c64xx/setup-ide.c @@ -17,6 +17,7 @@ #include <mach/map.h> #include <mach/regs-clock.h> #include <plat/gpio-cfg.h> +#include <plat/ata.h> void s3c64xx_ide_setup_gpio(void) { -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped 2010-10-12 17:23 [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped Mark Brown 2010-10-12 17:23 ` [PATCH 2/2] S3C64XX: Ensure s3c64xx_ide_setup_gpio() " Mark Brown @ 2010-10-13 8:14 ` Kukjin Kim 2010-10-13 8:19 ` Mark Brown 1 sibling, 1 reply; 6+ messages in thread From: Kukjin Kim @ 2010-10-13 8:14 UTC (permalink / raw) To: linux-arm-kernel Mark Brown wrote: > > Since it's exported we should make sure we're using the prototype > others see. > Hi Mark, Hmm...I'm not sure that we need really this. Of course, it can be helpful. But if so, we have to apply this policy/rule to all of ours...but I think we don't need it now. > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > arch/arm/mach-s3c64xx/setup-keypad.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/setup-keypad.c b/arch/arm/mach- > s3c64xx/setup-keypad.c > index d1fd722..f8ed0d2 100644 > --- a/arch/arm/mach-s3c64xx/setup-keypad.c > +++ b/arch/arm/mach-s3c64xx/setup-keypad.c > @@ -12,6 +12,7 @@ > > #include <linux/gpio.h> > #include <plat/gpio-cfg.h> > +#include <plat/keypad.h> > > void samsung_keypad_cfg_gpio(unsigned int rows, unsigned int cols) > { > -- Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped 2010-10-13 8:14 ` [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() " Kukjin Kim @ 2010-10-13 8:19 ` Mark Brown 2010-10-13 8:48 ` Kukjin Kim 0 siblings, 1 reply; 6+ messages in thread From: Mark Brown @ 2010-10-13 8:19 UTC (permalink / raw) To: linux-arm-kernel On Wed, Oct 13, 2010 at 05:14:37PM +0900, Kukjin Kim wrote: > Mark Brown wrote: > > Since it's exported we should make sure we're using the prototype > > others see. > Hmm...I'm not sure that we need really this. Of course, it can be helpful. > But if so, we have to apply this policy/rule to all of ours...but I think we > don't need it now. sparse warns about this issue so fixing issues like this is required to get a clean build for sparse users (I do pretty much all my builds with sparse). I am sending fixes for everything I build, though obviously I don't have access to all Samsung systems, and it does make life easier when doing updates on the arch code. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped 2010-10-13 8:19 ` Mark Brown @ 2010-10-13 8:48 ` Kukjin Kim 2010-10-13 8:49 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Kukjin Kim @ 2010-10-13 8:48 UTC (permalink / raw) To: linux-arm-kernel Mark Brown wrote: > > On Wed, Oct 13, 2010 at 05:14:37PM +0900, Kukjin Kim wrote: > > Mark Brown wrote: > > > > Since it's exported we should make sure we're using the prototype > > > others see. > > > Hmm...I'm not sure that we need really this. Of course, it can be helpful. > > But if so, we have to apply this policy/rule to all of ours...but I think we > > don't need it now. > > sparse warns about this issue so fixing issues like this is required to > get a clean build for sparse users (I do pretty much all my builds with > sparse). I am sending fixes for everything I build, though obviously I > don't have access to all Samsung systems, and it does make life easier > when doing updates on the arch code. You mean following? arch/arm/mach-s3c64xx/setup-keypad.c:16:6: warning: symbol 'samsung_keypad_cfg_gpio' was not declared. Should it be static? I didn't check sparse :-( Ok...Ben seems to be busy now...so will apply in my tree. And I will also fix it our Samsung stuff. Ben, if any problems, please let me know. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped 2010-10-13 8:48 ` Kukjin Kim @ 2010-10-13 8:49 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2010-10-13 8:49 UTC (permalink / raw) To: linux-arm-kernel On Wed, Oct 13, 2010 at 05:48:48PM +0900, Kukjin Kim wrote: > You mean following? > arch/arm/mach-s3c64xx/setup-keypad.c:16:6: warning: symbol > 'samsung_keypad_cfg_gpio' was not declared. Should it be static? Yup, that's the one. > I didn't check sparse :-( > Ok...Ben seems to be busy now...so will apply in my tree. > And I will also fix it our Samsung stuff. Thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-13 8:49 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-10-12 17:23 [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() is prototyped Mark Brown 2010-10-12 17:23 ` [PATCH 2/2] S3C64XX: Ensure s3c64xx_ide_setup_gpio() " Mark Brown 2010-10-13 8:14 ` [PATCH 1/2] S3C64XX: Ensure samsung_keypad_cfg_gpio() " Kukjin Kim 2010-10-13 8:19 ` Mark Brown 2010-10-13 8:48 ` Kukjin Kim 2010-10-13 8:49 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).