From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] video: omap: vram: remove from normal memory
Date: Mon, 18 Oct 2010 15:55:34 -0700 [thread overview]
Message-ID: <20101018225534.GH13341@atomide.com> (raw)
In-Reply-To: <1287410618.6781.110.camel@tubuntu>
* Tomi Valkeinen <tomi.valkeinen@nokia.com> [101018 06:55]:
> On Mon, 2010-10-18 at 16:10 +0300, Tomi Valkeinen wrote:
> > Hi,
> >
> > On Fri, 2010-10-15 at 14:46 +0200, ext Felipe Contreras wrote:
> > > So that we can ioremap happily.
> > >
> > > Cc: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > > ---
> > > drivers/video/omap2/vram.c | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/video/omap2/vram.c b/drivers/video/omap2/vram.c
> > > index f6fdc20..1a99777 100644
> > > --- a/drivers/video/omap2/vram.c
> > > +++ b/drivers/video/omap2/vram.c
> > > @@ -575,6 +575,8 @@ void __init omap_vram_reserve_sdram_memblock(void)
> > > }
> > > } else {
> > > paddr = memblock_alloc_base(size, PAGE_SIZE, MEMBLOCK_REAL_LIMIT);
> > > + memblock_free(paddr, size);
> > > + memblock_remove(paddr, size);
> > > }
> > >
> > > omap_vram_add_region(paddr, size);
> >
> > I tested this on OMAP3 SDP board, on top of my DSS2 tree. I can boot up
> > fine, but my test program crashes the kernel (dump below).
> >
> > This crash doesn't happen if I have the "HACK: OMAP: DSS2: OMAPFB: use
> > phys_to_virt for RAM mappings" patch in (I removed that during testing
> > this patch).
> >
> > I don't know yet what is crashing the kernel, but I'd guess it's the
> > fact that my test program reallocates the framebuffer memory with
> > OMAPFB_SETUP_MEM ioctl.
>
> Ah, sorry, I was missing the patch from Russel which you mentioned in
> another mail (http://article.gmane.org/gmane.linux.kernel/1047146). With
> that patch included things seem to work.
Tomi, I assume you're queuing these? If so, for both:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2010-10-18 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTik_6byuzkZ+mKunTi6HJTHu49C4XGebfTjCaEeE@mail.gmail.com>
2010-10-15 12:46 ` [PATCH 1/2] video: omap: vram: remove from normal memory Felipe Contreras
2010-10-18 13:10 ` Tomi Valkeinen
2010-10-18 14:03 ` Tomi Valkeinen
2010-10-18 22:55 ` Tony Lindgren [this message]
2010-10-19 7:27 ` Felipe Contreras
2010-10-19 12:03 ` Tomi Valkeinen
2010-11-07 22:49 ` Felipe Contreras
2010-11-08 11:40 ` Tomi Valkeinen
2010-10-15 12:46 ` [PATCH 2/2] omap: rx51: mark reserved memory earlier Felipe Contreras
2010-10-15 12:49 ` Felipe Contreras
2010-11-12 13:28 ` Tomi Valkeinen
2011-02-10 14:40 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018225534.GH13341@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).