[PATCH v3] OMAP: NAND: Fix static declaration warning

[PATCH v3] OMAP: NAND: Fix static declaration warning

[Vimal Singh]

On Wed, Oct 6, 2010 at 3:26 AM, G, Manjunath Kondaiah <manjugk@ti.com> wrote:
> This patch fixes sparse warning for static declaration of variable "use_dma"
>
> drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. Should it be static?
>
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-mtd at lists.infradead.org
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> Changes since v1:
> ?- no logical changes, patch seperated from series based Tony's suggestion.
>
> ?drivers/mtd/nand/omap2.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 133d515..439e80d 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -111,11 +111,11 @@ static int use_dma = 1;
> ?module_param(use_dma, bool, 0);
> ?MODULE_PARM_DESC(use_dma, "enable/disable use of DMA");
> ?#else
> -const int use_dma;
> +static const int use_dma;
> ?#endif
> ?#else
> ?const int use_prefetch;
> -const int use_dma;
> +static const int use_dma;

I did not understand, why did it not pointed same error for 'const int
use_prefetch'?

-- 
Regards,
Vimal Singh

[PATCH v3] OMAP: NAND: Fix static declaration warning

[Artem Bityutskiy]

On Wed, 2010-10-06 at 03:26 +0530, G, Manjunath Kondaiah wrote:
> This patch fixes sparse warning for static declaration of variable "use_dma"
> 
> drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. Should it be static?
> 
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-mtd at lists.infradead.org
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>

I've pushed this patch to my l2-mtd-2.6.git.

-- 
Best Regards,
Artem Bityutskiy (???????? ?????)

[PATCH v3] OMAP2/3: NAND: Convert write/read functions to raw read/write

[Artem Bityutskiy]

On Wed, 2010-10-06 at 03:26 +0530, G, Manjunath Kondaiah wrote:
> Following sparse warnings exists due to use of writel/w and readl/w functions.
> 
> This patch fixes the sparse warnings by converting readl/w functions usage into
> __raw_readl/__raw_readw functions.
> 
> drivers/mtd/nand/omap2.c:484:15: warning: symbol '__v' shadows an earlier one
> drivers/mtd/nand/omap2.c:484:15: originally declared here
> 
> drivers/mtd/onenand/omap2.c:86:9: warning: symbol '__v' shadows an earlier one
> drivers/mtd/onenand/omap2.c:86:9: originally declared here
> 
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-mtd at lists.infradead.org

I've pushed this patch to my l2-mtd-2.6.git.

-- 
Best Regards,
Artem Bityutskiy (???????? ?????)

[PATCH v3] TWL IRQ: Fix fucntion declaration warnings

[G, Manjunath Kondaiah]

Hi Samuel,

> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org 
> [mailto:linux-omap-owner at vger.kernel.org] On Behalf Of G, 
> Manjunath Kondaiah
> Sent: Wednesday, October 06, 2010 3:27 AM
> To: linux-omap at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org; Samuel Ortiz; Tony 
> Lindgren; Menon, Nishanth
> Subject: [PATCH v3] TWL IRQ: Fix fucntion declaration warnings
> 
> Fixes following sparse warnings for twl4030 and twl6030 irq files.
> 
> 
If there are no further comments, can you please push this patch?

-Manjunath 

[PATCH v3] TWL IRQ: Fix fucntion declaration warnings

[Samuel Ortiz]

Hi Manjunath,

On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote:
> Fixes following sparse warnings for twl4030 and twl6030 irq files.
> 
> drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?
> drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?
> drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static?
> 
> drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static?
> drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static?
>
Patch applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

[PATCH v3] TWL IRQ: Fix fucntion declaration warnings

[Uwe Kleine-König]

On Tue, Oct 19, 2010 at 11:06:14AM +0200, Samuel Ortiz wrote:
> Hi Manjunath,
> 
> On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote:
> > Fixes following sparse warnings for twl4030 and twl6030 irq files.
> > 
> > drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?
> > drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?
> > drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static?
> > 
> > drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static?
> > drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static?
> >
> Patch applied, thanks.
I didn't get the original patch, so I just now noticed the typo in the
Subject.  You might want to do s/fucntion/function/

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH v3] TWL IRQ: Fix fucntion declaration warnings

[Samuel Ortiz]

Hi Uwe,

On Tue, Oct 19, 2010 at 11:28:16AM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Oct 19, 2010 at 11:06:14AM +0200, Samuel Ortiz wrote:
> > Hi Manjunath,
> > 
> > On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote:
> > > Fixes following sparse warnings for twl4030 and twl6030 irq files.
> > > 
> > > drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static?
> > > 
> > > drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static?
> > >
> > Patch applied, thanks.
> I didn't get the original patch, so I just now noticed the typo in the
> Subject.  You might want to do s/fucntion/function/
Yes, I noticed as well and fixed it, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/