[PATCH] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

[PATCH] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

[Eric Bénard]

this patch fix timeout problems on i.MX51 as suggested by
Richard Zhu.
more tests are needed to check if this quirk can be removed
for i.MX25 and 35.

Signed-off-by: Eric B?nard <eric@eukrea.com>
Tested-by: Shawn Guo <shawn.gsc@gmail.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 2e9cca1..e8f7048 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -134,7 +134,8 @@ static struct sdhci_ops sdhci_esdhc_ops = {
 
 struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = {
 	.quirks = ESDHC_DEFAULT_QUIRKS | SDHCI_QUIRK_NO_MULTIBLOCK
-			| SDHCI_QUIRK_BROKEN_ADMA,
+			| SDHCI_QUIRK_BROKEN_ADMA
+			| SDHCI_QUIRK_BROKEN_TIMEOUT_VAL,
 	/* ADMA has issues. Might be fixable */
 	/* NO_MULTIBLOCK might be MX35 only (Errata: ENGcm07207) */
 	.ops = &sdhci_esdhc_ops,
-- 
1.7.0.4

[PATCH] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

[Wolfram Sang]

On Tue, Oct 19, 2010 at 02:49:01PM +0200, Eric B?nard wrote:
> this patch fix timeout problems on i.MX51 as suggested by
> Richard Zhu.
> more tests are needed to check if this quirk can be removed
> for i.MX25 and 35.

Didn't you have such boards?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101019/92a987f0/attachment.sig>

[PATCH] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

[Eric Bénard]

Hi Wolfram,

Le 19/10/2010 17:07, Wolfram Sang a ?crit :
> On Tue, Oct 19, 2010 at 02:49:01PM +0200, Eric B?nard wrote:
>> this patch fix timeout problems on i.MX51 as suggested by
>> Richard Zhu.
>> more tests are needed to check if this quirk can be removed
>> for i.MX25 and 35.
>
> Didn't you have such boards?

I do have, but I can't do the tests until next week because of other priorities.

Eric

[PATCH] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

[Wolfram Sang]

On Tue, Oct 19, 2010 at 05:17:40PM +0200, Eric B?nard wrote:
> Hi Wolfram,
>
> Le 19/10/2010 17:07, Wolfram Sang a ?crit :
>> On Tue, Oct 19, 2010 at 02:49:01PM +0200, Eric B?nard wrote:
>>> this patch fix timeout problems on i.MX51 as suggested by
>>> Richard Zhu.
>>> more tests are needed to check if this quirk can be removed
>>> for i.MX25 and 35.
>>
>> Didn't you have such boards?
>
> I do have, but I can't do the tests until next week because of other priorities.

I'd suggest to add a proper patch next week then (maybe together with correct
usage of the MULTIBLOCK-quirk, too?). It's a new driver, so adding update
patches late in the cycle should not cause problems? Of course, Chris makes the
final decision about that.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101019/d51cbf10/attachment.sig>

[PATCH] sdhci-esdhc-imx: fix timeout on i.MX's sdhci

[Chris Ball]

On Tue, Oct 19, 2010 at 09:36:38PM +0200, Wolfram Sang wrote:
> > I do have, but I can't do the tests until next week because of other priorities.
> 
> I'd suggest to add a proper patch next week then (maybe together with correct
> usage of the MULTIBLOCK-quirk, too?). It's a new driver, so adding update
> patches late in the cycle should not cause problems? Of course, Chris makes the
> final decision about that.

Fine with me, tested patches are good.  There's no need to rush to get
it in before -rc1. 

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child