public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] mx35pdk: add debug board support
Date: Wed, 20 Oct 2010 12:05:54 +0200	[thread overview]
Message-ID: <20101020100553.GD2691@jasper.tkos.co.il> (raw)
In-Reply-To: <1287567283-19488-1-git-send-email-jgq516@gmail.com>

Hi jgq516,

On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote:
> From: Xiao Jiang <jgq516@gmail.com>
> 
> Enable debug board support for mx35pdk. As suggested
> by Fabio, add MXC_DEBUG_BOARD config and redefinition
> EXPIO_PARENT_INT.
> 
> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/mach-mx3/Kconfig         |    1 +
>  arch/arm/mach-mx3/mach-mx35_3ds.c |    8 ++++++++
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig
> index 85beece..cdf6ac5 100644
> --- a/arch/arm/mach-mx3/Kconfig
> +++ b/arch/arm/mach-mx3/Kconfig

[snip]

> @@ -95,6 +99,10 @@ static void __init mxc_board_init(void)
>  	imx35_add_imx_uart0(&uart_pdata);
>  
>  	mxc_register_device(&mxc_otg_udc_device, &usb_pdata);
> +
> +	if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT))
> +		pr_warn("Init of the debugboard failed, all "
> +			"devices on the board are unusable.\n");
                            ^^^^^
You probably mean debugboard here. I'd change the wording.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2010-10-20 10:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  9:34 [PATCH v2 1/1] mx35pdk: add debug board support jgq516 at gmail.com
2010-10-20 10:05 ` Baruch Siach [this message]
2010-10-21  2:00   ` xiao jiang
2010-10-21  2:08     ` xiao jiang
2010-10-21  6:07       ` Baruch Siach
2010-10-21  6:18         ` xiao jiang
2010-10-21  6:25         ` Jason Wang
2010-10-20 13:17 ` Fabio Estevam
2010-10-20 13:29   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101020100553.GD2691@jasper.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox