* [PATCH v2 1/1] mx35pdk: add debug board support @ 2010-10-20 9:34 jgq516 at gmail.com 2010-10-20 10:05 ` Baruch Siach 2010-10-20 13:17 ` Fabio Estevam 0 siblings, 2 replies; 9+ messages in thread From: jgq516 at gmail.com @ 2010-10-20 9:34 UTC (permalink / raw) To: linux-arm-kernel From: Xiao Jiang <jgq516@gmail.com> Enable debug board support for mx35pdk. As suggested by Fabio, add MXC_DEBUG_BOARD config and redefinition EXPIO_PARENT_INT. Signed-off-by: Xiao Jiang <jgq516@gmail.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- arch/arm/mach-mx3/Kconfig | 1 + arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig index 85beece..cdf6ac5 100644 --- a/arch/arm/mach-mx3/Kconfig +++ b/arch/arm/mach-mx3/Kconfig @@ -139,6 +139,7 @@ config MACH_ARMADILLO5X0 config MACH_MX35_3DS bool "Support MX35PDK platform" select ARCH_MX35 + select MXC_DEBUG_BOARD select IMX_HAVE_PLATFORM_IMX_UART default n help diff --git a/arch/arm/mach-mx3/mach-mx35_3ds.c b/arch/arm/mach-mx3/mach-mx35_3ds.c index 1c30d72..326b90a 100644 --- a/arch/arm/mach-mx3/mach-mx35_3ds.c +++ b/arch/arm/mach-mx3/mach-mx35_3ds.c @@ -35,10 +35,14 @@ #include <mach/hardware.h> #include <mach/common.h> #include <mach/iomux-mx35.h> +#include <mach/irqs.h> +#include <mach/3ds_debugboard.h> #include "devices-imx35.h" #include "devices.h" +#define EXPIO_PARENT_INT (MXC_INTERNAL_IRQS + GPIO_PORTA + 1) + static const struct imxuart_platform_data uart_pdata __initconst = { .flags = IMXUART_HAVE_RTSCTS, }; @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) imx35_add_imx_uart0(&uart_pdata); mxc_register_device(&mxc_otg_udc_device, &usb_pdata); + + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) + pr_warn("Init of the debugboard failed, all " + "devices on the board are unusable.\n"); } static void __init mx35pdk_timer_init(void) -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-20 9:34 [PATCH v2 1/1] mx35pdk: add debug board support jgq516 at gmail.com @ 2010-10-20 10:05 ` Baruch Siach 2010-10-21 2:00 ` xiao jiang 2010-10-20 13:17 ` Fabio Estevam 1 sibling, 1 reply; 9+ messages in thread From: Baruch Siach @ 2010-10-20 10:05 UTC (permalink / raw) To: linux-arm-kernel Hi jgq516, On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote: > From: Xiao Jiang <jgq516@gmail.com> > > Enable debug board support for mx35pdk. As suggested > by Fabio, add MXC_DEBUG_BOARD config and redefinition > EXPIO_PARENT_INT. > > Signed-off-by: Xiao Jiang <jgq516@gmail.com> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > arch/arm/mach-mx3/Kconfig | 1 + > arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig > index 85beece..cdf6ac5 100644 > --- a/arch/arm/mach-mx3/Kconfig > +++ b/arch/arm/mach-mx3/Kconfig [snip] > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) > imx35_add_imx_uart0(&uart_pdata); > > mxc_register_device(&mxc_otg_udc_device, &usb_pdata); > + > + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) > + pr_warn("Init of the debugboard failed, all " > + "devices on the board are unusable.\n"); ^^^^^ You probably mean debugboard here. I'd change the wording. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-20 10:05 ` Baruch Siach @ 2010-10-21 2:00 ` xiao jiang 2010-10-21 2:08 ` xiao jiang 0 siblings, 1 reply; 9+ messages in thread From: xiao jiang @ 2010-10-21 2:00 UTC (permalink / raw) To: linux-arm-kernel Hi Baruch, 2010/10/20 Baruch Siach <baruch@tkos.co.il> > Hi jgq516, > > On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote: > > From: Xiao Jiang <jgq516@gmail.com> > > > > Enable debug board support for mx35pdk. As suggested > > by Fabio, add MXC_DEBUG_BOARD config and redefinition > > EXPIO_PARENT_INT. > > > > Signed-off-by: Xiao Jiang <jgq516@gmail.com> > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > --- > > arch/arm/mach-mx3/Kconfig | 1 + > > arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ > > 2 files changed, 9 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig > > index 85beece..cdf6ac5 100644 > > --- a/arch/arm/mach-mx3/Kconfig > > +++ b/arch/arm/mach-mx3/Kconfig > > [snip] > > > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) > > imx35_add_imx_uart0(&uart_pdata); > > > > mxc_register_device(&mxc_otg_udc_device, &usb_pdata); > > + > > + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) > > + pr_warn("Init of the debugboard failed, all " > > + "devices on the board are unusable.\n"); > ^^^^^ > You probably mean debugboard here. I'd change the wording. > > There are some devices in the debug board, such as lan9217 ethernet. If mxc_expio_init failed, then the lan9217 can't be use. BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn messages are same. if (mxc_expio_init(MX51_CS5_BASE_ADDR, EXPIO_PARENT_INT)) printk(KERN_WARNING "Init of the debugboard failed, all " "devices on the board are unusable.\n"); baruch > > -- > ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/f3d71487/attachment-0002.html> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-21 2:00 ` xiao jiang @ 2010-10-21 2:08 ` xiao jiang 2010-10-21 6:07 ` Baruch Siach 0 siblings, 1 reply; 9+ messages in thread From: xiao jiang @ 2010-10-21 2:08 UTC (permalink / raw) To: linux-arm-kernel 2010/10/21 xiao jiang <jgq516@gmail.com> > Hi Baruch, > > 2010/10/20 Baruch Siach <baruch@tkos.co.il> > > Hi jgq516, >> >> On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote: >> > From: Xiao Jiang <jgq516@gmail.com> >> > >> > Enable debug board support for mx35pdk. As suggested >> > by Fabio, add MXC_DEBUG_BOARD config and redefinition >> > EXPIO_PARENT_INT. >> > >> > Signed-off-by: Xiao Jiang <jgq516@gmail.com> >> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >> > --- >> > arch/arm/mach-mx3/Kconfig | 1 + >> > arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ >> > 2 files changed, 9 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig >> > index 85beece..cdf6ac5 100644 >> > --- a/arch/arm/mach-mx3/Kconfig >> > +++ b/arch/arm/mach-mx3/Kconfig >> >> [snip] >> >> > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) >> > imx35_add_imx_uart0(&uart_pdata); >> > >> > mxc_register_device(&mxc_otg_udc_device, &usb_pdata); >> > + >> > + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) >> > + pr_warn("Init of the debugboard failed, all " >> > + "devices on the board are unusable.\n"); >> ^^^^^ >> You probably mean debugboard here. I'd change the wording. >> >> There are some devices in the debug board, such as lan9217 ethernet. If > mxc_expio_init failed, > then the lan9217 can't be use. > BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn messages > are same. > if (mxc_expio_init(MX51_CS5_BASE_ADDR, > EXPIO_PARENT_INT)) > > printk(KERN_WARNING "Init of the debugboard failed, all " > > "devices on the board are > unusable.\n"); > > Ooo, I pressed the keyboard neglectfully[?], and you can see below sentence in mach-mx31_3ds.c. if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT)) printk(KERN_WARNING "Init of the debugboard failed, all " "devices on the board are unusable.\n"); Thanks, Xiao Jiang > baruch >> >> -- >> ~. .~ Tk Open >> Systems >> >> =}------------------------------------------------ooO--U--Ooo------------{= >> - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/13e5fb59/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/png Size: 630 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/13e5fb59/attachment-0001.png> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-21 2:08 ` xiao jiang @ 2010-10-21 6:07 ` Baruch Siach 2010-10-21 6:18 ` xiao jiang 2010-10-21 6:25 ` Jason Wang 0 siblings, 2 replies; 9+ messages in thread From: Baruch Siach @ 2010-10-21 6:07 UTC (permalink / raw) To: linux-arm-kernel Hi xiao, On Thu, Oct 21, 2010 at 10:08:02AM +0800, xiao jiang wrote: > 2010/10/21 xiao jiang <jgq516@gmail.com> > > 2010/10/20 Baruch Siach <baruch@tkos.co.il> > >> On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote: > >> > From: Xiao Jiang <jgq516@gmail.com> > >> > > >> > Enable debug board support for mx35pdk. As suggested > >> > by Fabio, add MXC_DEBUG_BOARD config and redefinition > >> > EXPIO_PARENT_INT. > >> > > >> > Signed-off-by: Xiao Jiang <jgq516@gmail.com> > >> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > >> > --- > >> > arch/arm/mach-mx3/Kconfig | 1 + > >> > arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ > >> > 2 files changed, 9 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig > >> > index 85beece..cdf6ac5 100644 > >> > --- a/arch/arm/mach-mx3/Kconfig > >> > +++ b/arch/arm/mach-mx3/Kconfig > >> > >> [snip] > >> > >> > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) > >> > imx35_add_imx_uart0(&uart_pdata); > >> > > >> > mxc_register_device(&mxc_otg_udc_device, &usb_pdata); > >> > + > >> > + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) > >> > + pr_warn("Init of the debugboard failed, all " > >> > + "devices on the board are unusable.\n"); > >> ^^^^^ > >> You probably mean debugboard here. I'd change the wording. > >> > >> There are some devices in the debug board, such as lan9217 ethernet. If > > mxc_expio_init failed, > > then the lan9217 can't be use. Of course. But this does not make devices on the main board unusable, isn't it? The user might think that his whole system is unusable because of this init failure. > > BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn messages > > are same. > > if (mxc_expio_init(MX51_CS5_BASE_ADDR, > > EXPIO_PARENT_INT)) > > > > printk(KERN_WARNING "Init of the debugboard failed, all " > > > > "devices on the board are > > unusable.\n"); > > > > Ooo, I pressed the keyboard neglectfully[?], and you can see below > sentence in mach-mx31_3ds.c. > if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT)) > printk(KERN_WARNING "Init of the debugboard failed, all " > "devices on the board are unusable.\n"); Then this wording should also change there. Adding Jason Wang to Cc. baruch > Thanks, > Xiao Jiang -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-21 6:07 ` Baruch Siach @ 2010-10-21 6:18 ` xiao jiang 2010-10-21 6:25 ` Jason Wang 1 sibling, 0 replies; 9+ messages in thread From: xiao jiang @ 2010-10-21 6:18 UTC (permalink / raw) To: linux-arm-kernel 2010/10/21 Baruch Siach <baruch@tkos.co.il> > Hi xiao, > > On Thu, Oct 21, 2010 at 10:08:02AM +0800, xiao jiang wrote: > > 2010/10/21 xiao jiang <jgq516@gmail.com> > > > 2010/10/20 Baruch Siach <baruch@tkos.co.il> > > >> On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote: > > >> > From: Xiao Jiang <jgq516@gmail.com> > > >> > > > >> > Enable debug board support for mx35pdk. As suggested > > >> > by Fabio, add MXC_DEBUG_BOARD config and redefinition > > >> > EXPIO_PARENT_INT. > > >> > > > >> > Signed-off-by: Xiao Jiang <jgq516@gmail.com> > > >> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > >> > --- > > >> > arch/arm/mach-mx3/Kconfig | 1 + > > >> > arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ > > >> > 2 files changed, 9 insertions(+), 0 deletions(-) > > >> > > > >> > diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig > > >> > index 85beece..cdf6ac5 100644 > > >> > --- a/arch/arm/mach-mx3/Kconfig > > >> > +++ b/arch/arm/mach-mx3/Kconfig > > >> > > >> [snip] > > >> > > >> > @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) > > >> > imx35_add_imx_uart0(&uart_pdata); > > >> > > > >> > mxc_register_device(&mxc_otg_udc_device, &usb_pdata); > > >> > + > > >> > + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) > > >> > + pr_warn("Init of the debugboard failed, all " > > >> > + "devices on the board are unusable.\n"); > > >> ^^^^^ > > >> You probably mean debugboard here. I'd change the wording. > > >> > > >> There are some devices in the debug board, such as lan9217 ethernet. > If > > > mxc_expio_init failed, > > > then the lan9217 can't be use. > > Of course. But this does not make devices on the main board unusable, isn't > it? The user might think that his whole system is unusable because of this > init failure. > > Ok, no relation with main board, to avoid confuse, maybe "all devices on the *debug* board are unusable" is more make sense, is it ok? Thanks, Xiao Jiang > > > BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn > messages > > > are same. > > > if (mxc_expio_init(MX51_CS5_BASE_ADDR, > > > EXPIO_PARENT_INT)) > > > > > > printk(KERN_WARNING "Init of the debugboard failed, > all " > > > > > > "devices on the board are > > > unusable.\n"); > > > > > > Ooo, I pressed the keyboard neglectfully[?], and you can see below > > sentence in mach-mx31_3ds.c. > > if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT)) > > printk(KERN_WARNING "Init of the debugboard failed, all " > > "devices on the board are unusable.\n"); > > Then this wording should also change there. Adding Jason Wang to Cc. > > baruch > > > Thanks, > > Xiao Jiang > > -- > ~. .~ Tk Open > Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/a17d2d10/attachment.html> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-21 6:07 ` Baruch Siach 2010-10-21 6:18 ` xiao jiang @ 2010-10-21 6:25 ` Jason Wang 1 sibling, 0 replies; 9+ messages in thread From: Jason Wang @ 2010-10-21 6:25 UTC (permalink / raw) To: linux-arm-kernel Baruch Siach wrote: > Hi xiao, > > On Thu, Oct 21, 2010 at 10:08:02AM +0800, xiao jiang wrote: > >> 2010/10/21 xiao jiang <jgq516@gmail.com> >> >>> 2010/10/20 Baruch Siach <baruch@tkos.co.il> >>> >>>> On Wed, Oct 20, 2010 at 05:34:43PM +0800, jgq516 at gmail.com wrote: >>>> >>>>> From: Xiao Jiang <jgq516@gmail.com> >>>>> >>>>> Enable debug board support for mx35pdk. As suggested >>>>> by Fabio, add MXC_DEBUG_BOARD config and redefinition >>>>> EXPIO_PARENT_INT. >>>>> >>>>> Signed-off-by: Xiao Jiang <jgq516@gmail.com> >>>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> >>>>> --- >>>>> arch/arm/mach-mx3/Kconfig | 1 + >>>>> arch/arm/mach-mx3/mach-mx35_3ds.c | 8 ++++++++ >>>>> 2 files changed, 9 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/arch/arm/mach-mx3/Kconfig b/arch/arm/mach-mx3/Kconfig >>>>> index 85beece..cdf6ac5 100644 >>>>> --- a/arch/arm/mach-mx3/Kconfig >>>>> +++ b/arch/arm/mach-mx3/Kconfig >>>>> >>>> [snip] >>>> >>>> >>>>> @@ -95,6 +99,10 @@ static void __init mxc_board_init(void) >>>>> imx35_add_imx_uart0(&uart_pdata); >>>>> >>>>> mxc_register_device(&mxc_otg_udc_device, &usb_pdata); >>>>> + >>>>> + if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) >>>>> + pr_warn("Init of the debugboard failed, all " >>>>> + "devices on the board are unusable.\n"); >>>>> >>>> ^^^^^ >>>> You probably mean debugboard here. I'd change the wording. >>>> >>>> There are some devices in the debug board, such as lan9217 ethernet. If >>>> >>> mxc_expio_init failed, >>> then the lan9217 can't be use. >>> > > Of course. But this does not make devices on the main board unusable, isn't > it? The user might think that his whole system is unusable because of this > init failure. > > >>> BTW: In mach-mx5/board-mx51_3ds.c and mach-mx31_3ds.c, the warn messages >>> are same. >>> if (mxc_expio_init(MX51_CS5_BASE_ADDR, >>> EXPIO_PARENT_INT)) >>> >>> printk(KERN_WARNING "Init of the debugboard failed, all " >>> >>> "devices on the board are >>> unusable.\n"); >>> >>> Ooo, I pressed the keyboard neglectfully[?], and you can see below >>> >> sentence in mach-mx31_3ds.c. >> if (!mxc_expio_init(CS5_BASE_ADDR, EXPIO_PARENT_INT)) >> printk(KERN_WARNING "Init of the debugboard failed, all " >> "devices on the board are unusable.\n"); >> > > Then this wording should also change there. Adding Jason Wang to Cc. > > baruch > > Yes, you are right, this is a misleading word. should s/board/debugboard/. In addition, for mach-mx31_3ds.c, we should remove "!" before mxc_expio_init(). I will fix it ASAP. Thanks, Jason. >> Thanks, >> Xiao Jiang >> > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-20 9:34 [PATCH v2 1/1] mx35pdk: add debug board support jgq516 at gmail.com 2010-10-20 10:05 ` Baruch Siach @ 2010-10-20 13:17 ` Fabio Estevam 2010-10-20 13:29 ` Fabio Estevam 1 sibling, 1 reply; 9+ messages in thread From: Fabio Estevam @ 2010-10-20 13:17 UTC (permalink / raw) To: linux-arm-kernel Xiao. On Wed, Oct 20, 2010 at 7:34 AM, <jgq516@gmail.com> wrote: ... > ? ? ? ?mxc_register_device(&mxc_otg_udc_device, &usb_pdata); > + > + ? ? ? if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) > + ? ? ? ? ? ? ? pr_warn("Init of the debugboard failed, all " > + ? ? ? ? ? ? ? ? ? ? ? "devices on the board are unusable.\n"); ' if (!mxc_expio_init' should be used here as I mentioned previously. mxc_expio_init returns 0 if succesful. Regards, Fabio Estevam ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] mx35pdk: add debug board support 2010-10-20 13:17 ` Fabio Estevam @ 2010-10-20 13:29 ` Fabio Estevam 0 siblings, 0 replies; 9+ messages in thread From: Fabio Estevam @ 2010-10-20 13:29 UTC (permalink / raw) To: linux-arm-kernel On Wed, Oct 20, 2010 at 11:17 AM, Fabio Estevam <festevam@gmail.com> wrote: > Xiao. > > On Wed, Oct 20, 2010 at 7:34 AM, ?<jgq516@gmail.com> wrote: > ... >> ? ? ? ?mxc_register_device(&mxc_otg_udc_device, &usb_pdata); >> + >> + ? ? ? if (mxc_expio_init(MX35_CS5_BASE_ADDR, EXPIO_PARENT_INT)) >> + ? ? ? ? ? ? ? pr_warn("Init of the debugboard failed, all " >> + ? ? ? ? ? ? ? ? ? ? ? "devices on the board are unusable.\n"); > > ?' if (!mxc_expio_init' ?should be used here as I mentioned previously. > > mxc_expio_init returns 0 if succesful. Ops, sorry. 'if (mxc_expio_init' check is correct. So I think the only thing you need to address in v3 is the comment from Baruch. Thanks, Fabio Estevam ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-10-21 6:25 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-10-20 9:34 [PATCH v2 1/1] mx35pdk: add debug board support jgq516 at gmail.com 2010-10-20 10:05 ` Baruch Siach 2010-10-21 2:00 ` xiao jiang 2010-10-21 2:08 ` xiao jiang 2010-10-21 6:07 ` Baruch Siach 2010-10-21 6:18 ` xiao jiang 2010-10-21 6:25 ` Jason Wang 2010-10-20 13:17 ` Fabio Estevam 2010-10-20 13:29 ` Fabio Estevam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
