[patch v2 00/10] efikamx support improvements - try 2

[patch v2 00/10] efikamx support improvements - try 2

[Arnaud Patard (Rtp)]

Hi,

This patchset aims at improving current efikamx support. It adds support for :
- board id detection
- sdhc
- leds
- power button
- spi nor
- reset

I also had to fix/improve some imx51 iomux header so there are patches for
iomux-mx51.h.

v2:
- split iomux patch 3 into 2 patches
- reorder patches
- fix space comment
- fix Amit's comments
- decrease board id msleep

Arnaud

[patch v2 01/10] efikamx: read board id

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_boardid.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/65ae40f7/attachment.ksh>

[patch v2 02/10] imx51: fix iomux configuration

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: imx51_fix_iomux_gpio_1_x.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/a830bfae/attachment.ksh>

[patch v2 03/10] imx51: enhance iomux configuration for esdhc support

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: imx51_add_esdhc_pad_mode.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/59bec48a/attachment.ksh>

[patch v2 04/10] efikamx: add mmc support

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efika_mmc.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/bb96f8ac/attachment.ksh>

[patch v2 05/10] imx51: add gpio mode for csi1 {h,v}sync

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: imx51_add_csi1_hvsync_gpio.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/fc23d43e/attachment.ksh>

[patch v2 06/10] efikamx: add leds support

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efikamx_add_leds.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/35e3b650/attachment.ksh>

[patch v2 07/10] efikamx: add support for power key

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efikamx_add_powerkey.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/bf56ded2/attachment.ksh>

[patch v2 08/10] imx51: fix gpio_4_24 and gpio_4_25 pad configuration

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: imx51_fix_iomux_gpio_4_24_25.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/57e7b7f8/attachment.ksh>

[patch v2 09/10] efikamx: add spi nor support

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efikamx_add_nor.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/d742d5f6/attachment.ksh>

[patch v2 10/10] efikamx: add reset

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: efikamx_reset.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101021/29c15b78/attachment.ksh>

[patch v2 07/10] efikamx: add support for power key

[Fabio Estevam]

Hi Arnaud,

On Thu, Oct 21, 2010 at 8:39 AM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> This patch adds support for power key button of the efika mx. It's connected
> on ?GPIO 3 31.

Here you mention GPIO 3 31

> +#define EFIKAMX_POWER_KEY ? ? ?(1*32 + 31)

,but here you define it as GPIO 2 31

Regards,

Fabio Estevam

[patch v2 07/10] efikamx: add support for power key

[Arnaud Patard (Rtp)]

Fabio Estevam <festevam@gmail.com> writes:

> Hi Arnaud,

Hi,

>
> On Thu, Oct 21, 2010 at 8:39 AM, Arnaud Patard
> <arnaud.patard@rtp-net.org> wrote:
>> This patch adds support for power key button of the efika mx. It's connected
>> on ?GPIO 3 31.
>
> Here you mention GPIO 3 31
>
>> +#define EFIKAMX_POWER_KEY ? ? ?(1*32 + 31)
>
> ,but here you define it as GPIO 2 31

It's a typo in the patch description [ I wouldn't have sent the patch if
it was not working :) ]. The reset is on 2 31.

Arnaud

[patch v2 07/10] efikamx: add support for power key

[Arnaud Patard (Rtp)]

Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org> writes:

> Fabio Estevam <festevam@gmail.com> writes:
>
>> Hi Arnaud,
>
> Hi,
>
>>
>> On Thu, Oct 21, 2010 at 8:39 AM, Arnaud Patard
>> <arnaud.patard@rtp-net.org> wrote:
>>> This patch adds support for power key button of the efika mx. It's connected
>>> on ?GPIO 3 31.
>>
>> Here you mention GPIO 3 31
>>
>>> +#define EFIKAMX_POWER_KEY ? ? ?(1*32 + 31)
>>
>> ,but here you define it as GPIO 2 31
>
> It's a typo in the patch description [ I wouldn't have sent the patch if
> it was not working :) ]. The reset is on 2 31.
>

oops. s/reset is on 2 31/power key is on 2 31/ sorry for the confusion :(

Arnaud

[patch v2 00/10] efikamx support improvements - try 2

[Amit Kucheria]

On 10 Oct 21, Arnaud Patard wrote:
> 
> Hi,
> 
> This patchset aims at improving current efikamx support. It adds support for :
> - board id detection
> - sdhc
> - leds
> - power button
> - spi nor
> - reset
> 
> I also had to fix/improve some imx51 iomux header so there are patches for
> iomux-mx51.h.
> 
> v2:
> - split iomux patch 3 into 2 patches
> - reorder patches
> - fix space comment
> - fix Amit's comments
> - decrease board id msleep
> 
> Arnaud
> 

Please fix the typo in 07/10 description. Or perhaps Sascha will fix it while committing.

Also Dinh has added mx51_add_buttons() to platform code. 07/10 should be
modified to use that. Search for "ARM: imx: Add gpio-keys to mx51 babbage
board" on LAKML.

After that, for the whole series, you can add,

Acked-by: Amit Kucheria <amit.kucheria@linaro.org>

[patch v2 00/10] efikamx support improvements - try 2

[Arnaud Patard (Rtp)]

Amit Kucheria <amit.kucheria@linaro.org> writes:

Hi,

> On 10 Oct 21, Arnaud Patard wrote:
>> 
>> Hi,
>> 
>> This patchset aims at improving current efikamx support. It adds support for :
>> - board id detection
>> - sdhc
>> - leds
>> - power button
>> - spi nor
>> - reset
>> 
>> I also had to fix/improve some imx51 iomux header so there are patches for
>> iomux-mx51.h.
>> 
>> v2:
>> - split iomux patch 3 into 2 patches
>> - reorder patches
>> - fix space comment
>> - fix Amit's comments
>> - decrease board id msleep
>> 
>> Arnaud
>> 
>
> Please fix the typo in 07/10 description. Or perhaps Sascha will fix it while committing.
>
> Also Dinh has added mx51_add_buttons() to platform code. 07/10 should be
> modified to use that. Search for "ARM: imx: Add gpio-keys to mx51 babbage
> board" on LAKML.

uh ? You mean that a patch sent with a subject containing 'mx51
babbage' is containing changes which are generic for all imx51
platforms ? that's rather counter-intuitive and unfortunate imho :(

Moreover, from the archives, it's making what looks like babbage
specific changes in iomux-mx51.h file as noted Uwe Kleine-Koenig. I'll
wait then that all this stuff has been sorted and merged to send a new
patchset.

Thanks,
Arnaud