From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: UART: fix wakeup registers for OMAP24xx UART2
Date: Fri, 22 Oct 2010 11:07:50 -0700 [thread overview]
Message-ID: <20101022180750.GE17595@atomide.com> (raw)
In-Reply-To: <1287616743-23434-1-git-send-email-khilman@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [101020 16:10]:
> On OMAP24xx, UART2 WKEN and WKST registers are in PM_WKEN2_CORE and
> PM_WKST2_CORE respecitvely. Fix the OMAP2 register init to use the
> correct registers on OMAP24xx.
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> Tony, this should probably squeeze in for 2.6.37 as well.
OK, adding into omap-for-linus.
Regards,
Tony
> arch/arm/mach-omap2/serial.c | 17 ++++++++++-------
> 1 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index ba8a5cc..becf0e3 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -515,14 +515,8 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
> uart->padconf = padconf;
> } else if (cpu_is_omap24xx()) {
> u32 wk_mask = 0;
> + u32 wk_en = PM_WKEN1, wk_st = PM_WKST1;
>
> - if (cpu_is_omap2430()) {
> - uart->wk_en = OMAP2430_PRM_REGADDR(CORE_MOD, PM_WKEN1);
> - uart->wk_st = OMAP2430_PRM_REGADDR(CORE_MOD, PM_WKST1);
> - } else if (cpu_is_omap2420()) {
> - uart->wk_en = OMAP2420_PRM_REGADDR(CORE_MOD, PM_WKEN1);
> - uart->wk_st = OMAP2420_PRM_REGADDR(CORE_MOD, PM_WKST1);
> - }
> switch (uart->num) {
> case 0:
> wk_mask = OMAP24XX_ST_UART1_MASK;
> @@ -531,10 +525,19 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
> wk_mask = OMAP24XX_ST_UART2_MASK;
> break;
> case 2:
> + wk_en = OMAP24XX_PM_WKEN2;
> + wk_st = OMAP24XX_PM_WKST2;
> wk_mask = OMAP24XX_ST_UART3_MASK;
> break;
> }
> uart->wk_mask = wk_mask;
> + if (cpu_is_omap2430()) {
> + uart->wk_en = OMAP2430_PRM_REGADDR(CORE_MOD, wk_en);
> + uart->wk_st = OMAP2430_PRM_REGADDR(CORE_MOD, wk_st);
> + } else if (cpu_is_omap2420()) {
> + uart->wk_en = OMAP2420_PRM_REGADDR(CORE_MOD, wk_en);
> + uart->wk_st = OMAP2420_PRM_REGADDR(CORE_MOD, wk_st);
> + }
> } else {
> uart->wk_en = NULL;
> uart->wk_st = NULL;
> --
> 1.7.2.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-10-22 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 23:19 [PATCH] OMAP: UART: fix wakeup registers for OMAP24xx UART2 Kevin Hilman
2010-10-22 18:07 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022180750.GE17595@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).