linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi/pl022: fix erroneous platform data in U300
@ 2010-10-21 19:05 Linus Walleij
  2010-11-01  5:01 ` Grant Likely
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2010-10-21 19:05 UTC (permalink / raw)
  To: linux-arm-kernel

This fixes an erroneous use of LSB first in the U300 machine, the
PL022 used in U300 is a standard ARM core that doesn't support this
bit so it should never have been set.

Cc: Kevin Wells <wellsk40@gmail.com>OA
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
 arch/arm/mach-u300/spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-u300/spi.c b/arch/arm/mach-u300/spi.c
index 779abf7..5767208 100644
--- a/arch/arm/mach-u300/spi.c
+++ b/arch/arm/mach-u300/spi.c
@@ -67,7 +67,7 @@ static struct spi_board_info u300_spi_devices[] = {
 		.bus_num        = 0, /* Only one bus on this chip */
 		.chip_select    = 0,
 		/* Means SPI_CS_HIGH, change if e.g low CS */
-		.mode           = SPI_MODE_1 | SPI_LSB_FIRST | SPI_LOOP,
+		.mode           = SPI_MODE_1 | SPI_LOOP,
 	},
 #endif
 };
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] spi/pl022: fix erroneous platform data in U300
  2010-10-21 19:05 [PATCH] spi/pl022: fix erroneous platform data in U300 Linus Walleij
@ 2010-11-01  5:01 ` Grant Likely
  0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2010-11-01  5:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Oct 21, 2010 at 09:05:25PM +0200, Linus Walleij wrote:
> This fixes an erroneous use of LSB first in the U300 machine, the
> PL022 used in U300 is a standard ARM core that doesn't support this
> bit so it should never have been set.
> 
> Cc: Kevin Wells <wellsk40@gmail.com>OA
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>

Applied, thanks.

> ---
>  arch/arm/mach-u300/spi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-u300/spi.c b/arch/arm/mach-u300/spi.c
> index 779abf7..5767208 100644
> --- a/arch/arm/mach-u300/spi.c
> +++ b/arch/arm/mach-u300/spi.c
> @@ -67,7 +67,7 @@ static struct spi_board_info u300_spi_devices[] = {
>  		.bus_num        = 0, /* Only one bus on this chip */
>  		.chip_select    = 0,
>  		/* Means SPI_CS_HIGH, change if e.g low CS */
> -		.mode           = SPI_MODE_1 | SPI_LSB_FIRST | SPI_LOOP,
> +		.mode           = SPI_MODE_1 | SPI_LOOP,
>  	},
>  #endif
>  };
> -- 
> 1.6.3.3
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-01  5:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-21 19:05 [PATCH] spi/pl022: fix erroneous platform data in U300 Linus Walleij
2010-11-01  5:01 ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).