From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: fix the building failue on saar
Date: Thu, 4 Nov 2010 16:57:35 +0100 [thread overview]
Message-ID: <20101104155735.GE16938@pengutronix.de> (raw)
In-Reply-To: <1288882401-14859-1-git-send-email-haojian.zhuang@marvell.com>
Hello,
On Thu, Nov 04, 2010 at 10:53:21PM +0800, Haojian Zhuang wrote:
> Since CONFIG_FB_PXA_SMARTPANEL is introduced and it's depend on CONFIG_FB_PXA.
> We can't compile CONFIG_FB_PXA as module.
I don't know if choosing CONFIG_FB_PXA=m without
CONFIG_FB_PXA_SMARTPANEL makes sense. If yes, just letting
CONFIG_FB_PXA_SMARTPANEL depend on CONFIG_FB_PXA=y should work.
If this doesn't work (e.g. because arch/arm/mach-pxa/saar.c calls
functions that are only available in the fb_pxa kernel module) there is
no need to talk about CONFIG_FB_PXA_SMARTPANEL in the commit log, this
only confuses the readers.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-11-04 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 14:53 [PATCH] ARM: pxa: fix the building failue on saar Haojian Zhuang
2010-11-04 15:57 ` Uwe Kleine-König [this message]
2010-11-04 16:01 ` Eric Miao
2010-11-05 8:22 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104155735.GE16938@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox