linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: omap1: devices: need to return with a value
Date: Fri, 5 Nov 2010 14:31:06 -0700	[thread overview]
Message-ID: <20101105213106.GV9264@atomide.com> (raw)
In-Reply-To: <20101019080150.GC11713@pengutronix.de>

* Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> [101019 00:53]:
> On Tue, Oct 19, 2010 at 10:30:54AM +0300, Felipe Balbi wrote:
> > Get rid of the following warning:
> > 
> > arch/arm/mach-omap1/devices.c: In function 'omap_init_wdt':
> > arch/arm/mach-omap1/devices.c:298: warning: 'return' with
> > no value, in function returning non-void
> > 
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >  arch/arm/mach-omap1/devices.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c
> > index 63d68cf..a037aba 100644
> > --- a/arch/arm/mach-omap1/devices.c
> > +++ b/arch/arm/mach-omap1/devices.c
> > @@ -295,7 +295,7 @@ static struct platform_device omap_wdt_device = {
> >  static int __init omap_init_wdt(void)
> >  {
> >  	if (!cpu_is_omap16xx())
> > -		return;
> > +		return -ENODEV;
> >  
> >  	platform_device_register(&omap_wdt_device);
> >  	return 0;
> It's unrelated to this patch, but using
> 
> 	return platform_device_register(&omap_wdt_device);
> 
> would be a bit cleaner.

Felipe, care to update this one?

Tony

  reply	other threads:[~2010-11-05 21:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  7:30 [PATCH 0/2] Trivial series Felipe Balbi
2010-10-19  7:30 ` [PATCH 1/2] arm: omap1: devices: need to return with a value Felipe Balbi
2010-10-19  8:01   ` Uwe Kleine-König
2010-11-05 21:31     ` Tony Lindgren [this message]
2010-11-08  6:48       ` [PATCH] " Felipe Balbi
2010-10-19  7:30 ` [PATCH 2/2] arm: omap1: remove unused variables Felipe Balbi
2010-11-05 16:47   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101105213106.GV9264@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).