From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect
Date: Mon, 8 Nov 2010 09:18:08 +0100 [thread overview]
Message-ID: <20101108081808.GN16938@pengutronix.de> (raw)
In-Reply-To: <1289164215.29216.315.camel@Joe-Laptop>
Hi Joe,
On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/plat-mxc/cpufreq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
> index 039538e..9f358af 100644
> --- a/arch/arm/plat-mxc/cpufreq.c
> +++ b/arch/arm/plat-mxc/cpufreq.c
> @@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
> ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
>
> if (ret < 0) {
> - printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> - with error code %d\n", __func__, ret);
> + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> + __func__, ret);
I'd prefer
+ printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
+ "with error code %d\n", __func__, ret);
(actually I'd consider
+ pr_err("failed to register i.MXC CPUfreq (error: %d)\n", ret)
even better, but this is out of scope for this patch, isn't it?)
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-11-08 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 21:10 [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect Joe Perches
2010-11-08 8:18 ` Uwe Kleine-König [this message]
2010-11-08 9:08 ` Russell King - ARM Linux
2010-11-08 17:39 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108081808.GN16938@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox