[PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect

[PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/arm/plat-mxc/cpufreq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
index 039538e..9f358af 100644
--- a/arch/arm/plat-mxc/cpufreq.c
+++ b/arch/arm/plat-mxc/cpufreq.c
@@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
 	ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
 
 	if (ret < 0) {
-		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
-				with error code %d\n", __func__, ret);
+		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
+		       __func__, ret);
 		goto err;
 	}
 

[PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect

[Uwe Kleine-König]

Hi Joe,

On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/arm/plat-mxc/cpufreq.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
> index 039538e..9f358af 100644
> --- a/arch/arm/plat-mxc/cpufreq.c
> +++ b/arch/arm/plat-mxc/cpufreq.c
> @@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
>  	ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
>  
>  	if (ret < 0) {
> -		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> -				with error code %d\n", __func__, ret);
> +		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> +		       __func__, ret);
I'd prefer
+		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
+				"with error code %d\n", __func__, ret);

(actually I'd consider

+		pr_err("failed to register i.MXC CPUfreq (error: %d)\n", ret)

even better, but this is out of scope for this patch, isn't it?)

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect

[Russell King - ARM Linux]

On Mon, Nov 08, 2010 at 09:18:08AM +0100, Uwe Kleine-K?nig wrote:
> Hi Joe,
> 
> On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >  arch/arm/plat-mxc/cpufreq.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
> > index 039538e..9f358af 100644
> > --- a/arch/arm/plat-mxc/cpufreq.c
> > +++ b/arch/arm/plat-mxc/cpufreq.c
> > @@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
> >  	ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
> >  
> >  	if (ret < 0) {
> > -		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> > -				with error code %d\n", __func__, ret);
> > +		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> > +		       __func__, ret);
> I'd prefer
> +		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
> +				"with error code %d\n", __func__, ret);

No - you don't wrap error messages.  It's the one exception to the 80
column rule.

[PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect

[Joe Perches]

On Mon, 2010-11-08 at 09:18 +0100, Uwe Kleine-K?nig wrote:
> On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> > diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
[]
> > -		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> > -				with error code %d\n", __func__, ret);
> > +		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> > +		       __func__, ret);
> I'd prefer
> +		printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
> +				"with error code %d\n", __func__, ret);
> (actually I'd consider
> +		pr_err("failed to register i.MXC CPUfreq (error: %d)\n", ret)
> even better, but this is out of scope for this patch, isn't it?)

Yes, it's out of scope.

I do have a perl & emacs script that converts
printk(KERN_<level> to pr_<level>, coalesces formats,
and wraps/aligns arguments.

It's around 2K lines of changes though for arch/arm.

Anyone want that all at once or by platform by platform?