* [PATCH] mv78xx: wrong cpu1 window base register address
@ 2010-11-09 19:46 Evgeniy Dushistov
2010-11-22 6:25 ` Lennert Buytenhek
0 siblings, 1 reply; 2+ messages in thread
From: Evgeniy Dushistov @ 2010-11-09 19:46 UTC (permalink / raw)
To: linux-arm-kernel
The constant DDR_WINDOW_CPU1_BASE has wrong value.
Because of that mv78xx0_mbus_dram_info is not filled properly on
start, and in its turn drivers, that used mv78xx0_mbus_dram_info,
in my case mv643xx_eth.c, not work on second core.
According to
MV76100, MV78100, and MV78200 DiscoveryTM Innovation Series
CPU Family
Functional Specifications
address should be 0x1570.
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
---
arch/arm/mach-mv78xx0/include/mach/mv78xx0.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mv78xx0/include/mach/mv78xx0.h b/arch/arm/mach-mv78xx0/include/mach/mv78xx0.h
index 788bdac..3eff399 100644
--- a/arch/arm/mach-mv78xx0/include/mach/mv78xx0.h
+++ b/arch/arm/mach-mv78xx0/include/mach/mv78xx0.h
@@ -65,7 +65,7 @@
*/
#define DDR_VIRT_BASE (MV78XX0_REGS_VIRT_BASE | 0x00000)
#define DDR_WINDOW_CPU0_BASE (DDR_VIRT_BASE | 0x1500)
-#define DDR_WINDOW_CPU1_BASE (DDR_VIRT_BASE | 0x1700)
+#define DDR_WINDOW_CPU1_BASE (DDR_VIRT_BASE | 0x1570)
#define DEV_BUS_PHYS_BASE (MV78XX0_REGS_PHYS_BASE | 0x10000)
#define DEV_BUS_VIRT_BASE (MV78XX0_REGS_VIRT_BASE | 0x10000)
--
1.7.2.2
--
/Evgeniy
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] mv78xx: wrong cpu1 window base register address
2010-11-09 19:46 [PATCH] mv78xx: wrong cpu1 window base register address Evgeniy Dushistov
@ 2010-11-22 6:25 ` Lennert Buytenhek
0 siblings, 0 replies; 2+ messages in thread
From: Lennert Buytenhek @ 2010-11-22 6:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 09, 2010 at 10:46:18PM +0300, Evgeniy Dushistov wrote:
> The constant DDR_WINDOW_CPU1_BASE has wrong value.
> Because of that mv78xx0_mbus_dram_info is not filled properly on
> start, and in its turn drivers, that used mv78xx0_mbus_dram_info,
> in my case mv643xx_eth.c, not work on second core.
> According to
>
> MV76100, MV78100, and MV78200 DiscoveryTM Innovation Series
> CPU Family
> Functional Specifications
>
> address should be 0x1570.
>
> Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
Acked-by: Lennert Buytenhek <buytenh@wantstofly.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-22 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-09 19:46 [PATCH] mv78xx: wrong cpu1 window base register address Evgeniy Dushistov
2010-11-22 6:25 ` Lennert Buytenhek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).