From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/2] ARM: imx: Add mx53 support to common msl functions.
Date: Tue, 9 Nov 2010 23:26:45 +0100 [thread overview]
Message-ID: <20101109222645.GJ6017@pengutronix.de> (raw)
In-Reply-To: <20101109221213.GC16938@pengutronix.de>
On Tue, Nov 09, 2010 at 11:12:13PM +0100, Uwe Kleine-K?nig wrote:
> Hello,
>
> > > - if (!cpu_is_mx51())
> > > + if (!cpu_is_mx51() || !cpu_is_mx53())
> > > return 0;
> >
> > The code below runs for every SoC except i.MX51 and i.MX53. This is
> > surely not what you want.
> Hmm, for i.MX51 !cpu_is_mx53() is true, so the return 0 is always taken,
> isn't it? :-)
Gna, I remember I ran in this trap not so long time ago ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2010-11-09 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 15:55 [PATCHv3 1/2] ARM: imx: Add core definitions for MX53 Dinh.Nguyen at freescale.com
2010-11-05 15:55 ` [PATCHv3 2/2] ARM: imx: Add mx53 support to common msl functions Dinh.Nguyen at freescale.com
2010-11-09 22:02 ` Sascha Hauer
2010-11-09 22:12 ` Uwe Kleine-König
2010-11-09 22:26 ` Sascha Hauer [this message]
2010-11-09 21:46 ` [PATCHv3 1/2] ARM: imx: Add core definitions for MX53 Sascha Hauer
2010-11-10 15:51 ` Nguyen Dinh-R00091
2010-11-10 16:46 ` Sascha Hauer
2010-11-10 17:04 ` Fabio Estevam
2010-11-10 17:09 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109222645.GJ6017@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).