From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] ARM: Thumb-2: Restore sensible zImage header layout for CONFIG_THUMB2_KERNEL
Date: Tue, 16 Nov 2010 18:26:43 +0000 [thread overview]
Message-ID: <20101116182643.GC21926@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1289913277-8822-7-git-send-email-dave.martin@linaro.org>
On Tue, Nov 16, 2010 at 01:14:37PM +0000, Dave Martin wrote:
> The code which makes up the zImage header clearly intends to
> leave a vector-table-sized gap of 8 words (NOPs, in fact),
> followed by a branch to the real entry point, a magic number,
> and a word containing the absolute entry point address.
That's an incorrect assumption. The set of 8 words have nothing to do
with the CPUs vector table at all - it has more to do with compatibility
with a.out built kernels, where the a.out header was 32 bytes.
> This gets messed up with with CONFIG_THUMB2_KERNEL:
>
> * The NOPs making up the vector table become halfword-
> sized.
Doesn't matter.
> * The magic number and absolute entry point occur too early
> and become misaligned.
Not used anymore - it's practically zero (and unused) for most cases
now anyway.
> * The absolute entry point fails to indicate that the entry
> point is Thumb code, which will cause incorrect execution
> if the bootloader uses this to enter the kernel.
And as such...
next prev parent reply other threads:[~2010-11-16 18:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 13:14 [PATCH 1/7] ARM: kexec: Correct data alignment for CONFIG_THUMB2_KERNEL Dave Martin
2010-11-16 13:14 ` [PATCH 2/7] ARM: vfp: " Dave Martin
2010-11-16 13:14 ` [PATCH 3/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in bootp/init.S Dave Martin
2010-11-16 13:14 ` [PATCH 4/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in kernel/head.S Dave Martin
2010-11-16 18:22 ` Russell King - ARM Linux
2010-11-17 10:16 ` Catalin Marinas
2010-11-17 10:16 ` Dave Martin
2010-11-16 13:14 ` [PATCH 5/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in mm/proc-v7.S Dave Martin
2010-11-16 13:14 ` [PATCH 6/7] ARM: Thumb-2: Fix CONFIG_THUMB2_KERNEL breakage in compressed/head.S Dave Martin
2010-11-16 13:14 ` [PATCH 7/7] ARM: Thumb-2: Restore sensible zImage header layout for CONFIG_THUMB2_KERNEL Dave Martin
2010-11-16 18:26 ` Russell King - ARM Linux [this message]
2010-11-16 20:28 ` Nicolas Pitre
2010-11-16 20:35 ` Russell King - ARM Linux
2010-11-16 20:58 ` Uwe Kleine-König
2010-11-17 9:16 ` Dave Martin
2010-11-17 9:19 ` Dave Martin
2010-11-17 10:21 ` Catalin Marinas
2010-11-17 11:11 ` [PATCH 7/7 v1.1] " Dave Martin
2010-11-17 16:17 ` Nicolas Pitre
2010-11-17 16:46 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116182643.GC21926@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).