From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] arm: imx: share imx5x_register_gpios for mach-mx5
Date: Thu, 25 Nov 2010 13:17:09 +0100 [thread overview]
Message-ID: <20101125121709.GH4693@pengutronix.de> (raw)
In-Reply-To: <AANLkTimy3qV+ZXs9urdTX2rq=0XrKEtbt2m8x+eBvMce@mail.gmail.com>
Hi Richard,
On Thu, Nov 25, 2010 at 07:10:27PM +0800, Richard Zhao wrote:
> Thanks. I go through the code again. Here is mx50 adding plan:
> 1. basic memory map definitions
> Add it in individual arch/arm/plat-mxc/include/mach/mx50.h
I hope the memory map itself goes into arch/arm/mach-mx5/mm-mx50.c or
similar. The constants go into include/mach/mx50.h though.
> 2. clock.c crm_regs.h
> clock tree is different. mx50 use arch/arm/mach-mx5/clock-mx50.c.
> Possibly individual crm_regs.h too.
Then please use proper prefixes (and maybe make the definitions local to
a .c file if possible).
> 3. iomux
> individual arch/arm/plat-mxc/include/mach/iomux-mx50.h
is mx50 using iomux-v3?
> 4. gpio
> Add it in arch/arm/plat-mxc/gpio.c under macro CONFIG_SOC_IMX50.
yes
> 5. irq
> Add it in individual arch/arm/plat-mxc/include/mach/mx50.h
yes, the constants go there
> 6. device and resource.
> Dynamicly add device. SoC level data is in arch/arm/plat-mxc/devices
> init section, plat data is in board level file.
most of the time yes.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-11-25 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 14:28 [PATCH 1/1] arm: imx: share imx5x_register_gpios for mach-mx5 Richard Zhao
2010-11-25 6:29 ` Uwe Kleine-König
2010-11-25 6:44 ` Richard Zhao
2010-11-25 7:42 ` Uwe Kleine-König
2010-11-25 8:01 ` Richard Zhao
2010-11-25 8:14 ` Uwe Kleine-König
2010-11-25 8:43 ` Sascha Hauer
2010-11-25 11:10 ` Richard Zhao
2010-11-25 12:17 ` Uwe Kleine-König [this message]
2010-11-25 14:40 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125121709.GH4693@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox