From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] ARM: hw_breakpoint: fixes and improvements
Date: Sat, 27 Nov 2010 12:39:39 +0000 [thread overview]
Message-ID: <20101127123939.GA5998@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1290704899-13051-1-git-send-email-will.deacon@arm.com>
On Thu, Nov 25, 2010 at 05:08:15PM +0000, Will Deacon wrote:
> All feedback welcome!
While in the subject of fixes, sparse seems to have a problem with
hw_breakpoint's usage of percpu stuff:
CHECK arch/arm/kernel/hw_breakpoint.c
arch/arm/kernel/hw_breakpoint.c:326:23: warning: incorrect type in assignment (different modifiers)
arch/arm/kernel/hw_breakpoint.c:326:23: expected struct perf_event **slots
arch/arm/kernel/hw_breakpoint.c:326:23: got struct perf_event *[noderef] *<noident>
arch/arm/kernel/hw_breakpoint.c:339:23: warning: incorrect type in assignment (different modifiers)
arch/arm/kernel/hw_breakpoint.c:339:23: expected struct perf_event **slots
arch/arm/kernel/hw_breakpoint.c:339:23: got struct perf_event *[noderef] *<noident>
arch/arm/kernel/hw_breakpoint.c:377:23: warning: incorrect type in assignment (different modifiers)
arch/arm/kernel/hw_breakpoint.c:377:23: expected struct perf_event **slots
arch/arm/kernel/hw_breakpoint.c:377:23: got struct perf_event *[noderef] *<noident>
arch/arm/kernel/hw_breakpoint.c:388:23: warning: incorrect type in assignment (different modifiers)
arch/arm/kernel/hw_breakpoint.c:388:23: expected struct perf_event **slots t perf_event *[noderef] *<noident>
arch/arm/kernel/hw_breakpoint.c:635:42: warning: incorrect type in initializer (different modifiers)
arch/arm/kernel/hw_breakpoint.c:635:42: expected struct perf_event **slots
arch/arm/kernel/hw_breakpoint.c:635:42: got struct perf_event *[noderef] *<noident>
arch/arm/kernel/hw_breakpoint.c:687:42: warning: incorrect type in initializer (different modifiers)
arch/arm/kernel/hw_breakpoint.c:687:42: expected struct perf_event **slots
arch/arm/kernel/hw_breakpoint.c:687:42: got struct perf_event *[noderef] *<noident>
perf_event.c seems to also have problems too:
CHECK arch/arm/kernel/perf_event.c
arch/arm/kernel/perf_event.c:37:1: warning: symbol 'pmu_lock' was not declared. Should it be static?
arch/arm/kernel/perf_event.c:70:1: warning: symbol 'cpu_hw_events' was not declared. Should it be static?
arch/arm/kernel/perf_event.c:1006:1: warning: symbol 'armv6pmu_enable_event' was not declared. Should it be static?
arch/arm/kernel/perf_event.c:1113:1: warning: symbol 'armv6pmu_stop' was not declared. Should it be static?
arch/arm/kernel/perf_event.c:1956:6: warning: symbol 'armv7pmu_enable_event' was not declared. Should it be static?
arch/arm/kernel/perf_event.c:3072:14: warning: incorrect type in argument 1 (different address spaces)
arch/arm/kernel/perf_event.c:3072:14: expected void const volatile [noderef] <asn:1>*<noident>
arch/arm/kernel/perf_event.c:3072:14: got struct frame_tail *tail
arch/arm/kernel/perf_event.c:3074:49: warning: incorrect type in argument 2 (different address spaces)
arch/arm/kernel/perf_event.c:3074:49: expected void const [noderef] <asn:1>*from
arch/arm/kernel/perf_event.c:3074:49: got struct frame_tail *tail
next prev parent reply other threads:[~2010-11-27 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 17:08 [PATCH 0/4] ARM: hw_breakpoint: fixes and improvements Will Deacon
2010-11-25 17:08 ` [PATCH 1/4] ARM: hw_breakpoint: ensure OS lock is clear before writing to debug registers Will Deacon
2010-11-25 17:08 ` [PATCH 2/4] ARM: hw_breakpoint: reset control registers in hotplug path Will Deacon
2010-11-25 17:08 ` [PATCH 3/4] ARM: hw_breakpoint: correct and simplify alignment fixup code Will Deacon
2010-11-25 17:08 ` [PATCH 4/4] ARM: ptrace: fix style issue with hw_breakpoint interface Will Deacon
2010-11-27 12:39 ` Russell King - ARM Linux [this message]
2010-11-27 21:12 ` [PATCH 0/4] ARM: hw_breakpoint: fixes and improvements Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101127123939.GA5998@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).